-1
\$\begingroup\$

I'm trying to play a sound on death, but keep getting a null error. I know it is something in my code, and I have already tried looking at an alternate question.

This is my code:

public class BallHealth : MonoBehaviour 
{
    public float maxPositionY = -10.0f;

    void Update () 
    {
        float positionBallY = transform.position.y;

        if (positionBallY <= maxPositionY)
        {
            StartCoroutine (RestartLevel ());
        }
    }

    IEnumerator RestartLevel()
    {
        AudioSource audio = new AudioSource ();

        audio.clip = (AudioClip)Resources.Load("GameOver") as AudioClip;
        audio.Play();
        yield return new WaitForSeconds(audio.clip.length);
        Debug.Log("You Died....");
        SceneManager.LoadScene("LevelOne");
    }
}

I already locate my file, in the resource folder.

Project structure

How do I fix the null error?

\$\endgroup\$
2
  • \$\begingroup\$ Can you be specific about what variable is null? It would be helpful if you posted the whole error from the Unity Log. \$\endgroup\$ Commented Oct 12, 2016 at 2:23
  • \$\begingroup\$ @honeybunch My problem was that the game object don't have a audio source attached , once I create and attach it to the game object I solve the problem, thanks to bmac help \$\endgroup\$ Commented Oct 13, 2016 at 12:54

1 Answer 1

Reset to default
2
\$\begingroup\$

You can't allocate components without attaching them to a GameObject (with gameObject.AddComponent). Unity will return a "null" object if you try to call a component constructor directly.

You should replace this line:

AudioSource audio = new AudioSource ();

With something like this:

AudioSource audio = GetComponent<AudioSource>();
if (audio == null) audio = gameObject.AddComponent<AudioSource>();

Which will use the existing AudioSource component on the object if you already made one, and will create and attach a new one if not.

Unrelatedly, you are unnecessarily casting the same object twice here (with (AudioClip) and as AudioClip):

audio.clip = (AudioClip)Resources.Load("GameOver") as AudioClip;

You only need one or the other, or even better:

audio.clip = Resources.Load<AudioClip>("GameOver");
\$\endgroup\$
3
  • \$\begingroup\$ Thanks, that solve my problem, at least at script, but still not hearing the sound. \$\endgroup\$ Commented Oct 11, 2016 at 21:43
  • 1
    \$\begingroup\$ You can also use the static method AudioSource.PlayOneShot or PlayClipAtPoint to fire off one-off cues without explicitly creating an AudioSource instance first. This gives less control over the falloff settings than creating a custom AudioSource, but is often "good enough" for simple cues. \$\endgroup\$ Commented Oct 11, 2016 at 22:40
  • \$\begingroup\$ Yeah, i manage to reproduce the sound by using the method PlayOneShot, Thank you. \$\endgroup\$ Commented Oct 11, 2016 at 23:49

You must log in to answer this question.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.