Questions tagged [conditions]
The conditions tag has no summary.
131 questions
18
votes
7
answers
4k
views
Is there a reason "replace conditional with table" isn't a standard refactoring?
I'm preparing a lecture where I will start with a many-branched conditional statement and replace it with a table. For example, I could start with:
function getMonthName(monthNumber) {
if (...
- 1,007
19
votes
7
answers
5k
views
Debugging a performance issue, do I commit the timing code?
I am working in small company, having a lead position in a group of 5. We are developing a C++ application. One requirement is that it needs to run fast.
Today, I noticed one function, say f1(), and ...
- 301
1
vote
1
answer
340
views
Could conditions be used with Data Flow Diagrams?
I'm trying to make a DFD for this scenario:
after admission, the patient gets the service he needs.
I've been trying to do it using this diagram (there are 3 available services):
but I don't think it'...
- 27
5
votes
5
answers
1k
views
Is it bad practice to use nullptr in ternary operation?
I've set up a ternary operator in place of a pile of if-else's, the final expression being nullptr in order to finish the loop, like so:
int menuSelect;
std::string operation="";
(...
- 61
0
votes
4
answers
222
views
Should we create a new function for every multiple conditions?
I have the existing code provided below:
if (!$existing_records && !$has_required_field) {
return 'Skip Update, no records found';
} elseif (!$existing_records && $...
0
votes
2
answers
179
views
Where to check preconditions in multi functions
In a library, there could exist three types of functions. The first are those which are visible to the user i.e. their declarations are installed in the library's include directory. The third are ...
- 111
0
votes
1
answer
216
views
Many if conditions
I have the code but I want to be pseudo as possible so I learn from other ways as much as possible.
So what I am building is web based tool and in one section we have a table.
This table renders lines ...
- 21
4
votes
2
answers
364
views
How to structure many complex conditionals on a class
I have a class (as a protobuf) OrderChange, that represents when an order (imagine Amazon.com) changes:
message OrderChange {
Order old_order = 1;
Order new_order = 2;
}
message Order {
...
- 169
2
votes
1
answer
3k
views
Multiple if condition optimization
Often I find conditional statements such as:
if (life_max < max):
if (expand):
do life_max = max
else:
if (life_max > max) and not (expand):
do life_max = max;
Although readable, ...
- 1,355
3
votes
4
answers
850
views
Is the strategy pattern for 3 variants overuse?
I am curious about it because I talked with a friend about the strategy pattern, and we diverge about when we have to use it.
Our scenario is that I have to build a view component with 3 variants. All ...
- 139
2
votes
1
answer
299
views
What is the name of this pattern / style?
We have a "workflow orchestration" system at work.
It works something like this:
You configure what to run (in a database table), such as:
NameOfStepATHingToRun ="weather_data"
...
- 1,403
3
votes
0
answers
103
views
Refactoring nested if-else statement [duplicate]
I have an app where every object is checked based on various types of business rules. For this, i used multiple nested if-else statement which was done in one class. I am not happy with this situation ...
- 39
3
votes
1
answer
4k
views
Why does a condition variable's wait() release the associated mutex before blocking and reacquire it before returning?
Stallings' Operating System book says about condition variable in Solaris,
A condition variable is used to wait until a particular condition is
true. Condition variables must be used in ...
- 5,565
-2
votes
1
answer
818
views
Refactoring nested if-else interface method in Java8
I have the below default method in an interface and it seems to be pretty complex because of the many if-else conditions.
default void validate() {
Application application = application().get();
...
- 173
-2
votes
1
answer
985
views
Conditional command pattern
I have an abstraction that defines something like a command pattern,
interface Participant {
void proceed();
}
Participants are grouped in a collection and are called all together. But each ...
- 141
4
votes
5
answers
285
views
Dealing with unwanted usages of a function
I am writing a function that I would not like to get called given a certain context and am wondering how best to convey that to possible users of the function. Assume, for exemplification, I am ...
- 150
1
vote
3
answers
271
views
Is there an elegant way to structure consecutive short-circuited assignments?
The following code works and is clear, but it's also verbose. I suspect that there's a way to make it more terse, so that it could be skimmed quickly and it'd be more obvious what's happening.
// The ...
- 125
3
votes
5
answers
1k
views
When to extract boolean conditions into their own function?
I commonly use a boolean condition/variable when it's something too big or complicated and takes too much space by itself inside ifs - basically to avoid repeatability and thus improve readability. E....
- 47
3
votes
1
answer
167
views
Is there a pattern for choosing one of a set of options at random when their selection criteria are equal?
I want to choose between several options, and if the criteria I'm using for selection happen to be equal, I want one at random (reasonably so, so it's equal-chance each time, rather than arbitrary). ...
- 149
-2
votes
2
answers
542
views
Conditional jump statements in middle- and high-level languages
In Java, C, and C++ we have the following jump statements: break, continue, goto, and return. In C#, there is also throw.
I'm not really familiar with either of these languages. This is simply what I ...
- 501
8
votes
5
answers
1k
views
Is it bad practice to add "false or" or "true and" to conditionals?
Is it bad practice to add false or ... or true and ... for the sake of promoting code genericness and/or ease of use?
As in:
SELECT *
FROM table
WHERE TRUE
AND IsEnabled
AND SomeField = some_value
...
- 197
3
votes
2
answers
330
views
Does removing unused features from libraries through compiler flags increase or reduce security risks?
Software libraries targetting resource constrained environments like embedded systems use conditional compilation to allow consumers to shave space and thus increase performance by removing unused ...
- 443
7
votes
2
answers
899
views
How does conditional compilation impact product quality, security and code complexity? [closed]
Software libraries targetting resource constrained environments like embedded systems use conditional compilation to allow consumers to shave space by removing unused features from the final binaries ...
- 443
0
votes
1
answer
71
views
Analyse/show user why data has been filtered out by SQL
Sorry for the bad title. Couldn't really think of a good name without an explanation.
In our system (source is inside Oracle PL/SQL packages) we have quite a lot large SQL queries with a sh..load of ...
- 133
1
vote
1
answer
119
views
Using define in a conditional expression in Scheme
In Scheme, the general form of a procedure definition is:
(define (<name> <parameters>) <body>)
where <body> accepts a sequence of expressions, allowing this kind of procedure ...
- 612
10
votes
5
answers
792
views
If-else ladder that is supposed to catch all conditions - should a redundant final clause be added?
This is a thing I'm doing a lot lately.
Example:
setCircle(circle, i, { current }) {
if (i == current) {
circle.src = 'images/25CE.svg'
circle.alt = 'Now picking'
} else if (...
- 4,529
2
votes
4
answers
584
views
Conditional vs Logical Testing
I would like to get your code thought and views on using conditional vs logical testing.
For example:
To test the conditions of truthness of all of the following variables, their currect status is ...
- 135
2
votes
2
answers
389
views
API Race conditions
I have an API in which we expect a emailID and a certain deal data.
The case is we want to keep the dealId and contactId(email) to be unique.
Creating a deal requires data insertion in multiple ...
- 21
2
votes
2
answers
3k
views
Avoid if-else block in favor of default assignment followed by if
A colleague, and frankly better software engineer that me, is telling me that this pattern
let variable = someDefaultVariable();
if (some_boolean) {
variable = someOtherValue();
}
is better than ...
- 139
2
votes
3
answers
1k
views
Reconciling MVC with a strategy pattern
I am working on a Rails application which employs a classic MVC as its fundamental structure. In that structure the controller is supposed to be responsible for "which view to render when".
Now after ...
- 143
2
votes
2
answers
202
views
Should special case be inside or outside the for loop here?
For example, suppose I have 2 arrays:
let arr1=[5,2,1];
let arr2=["abcde","ab","a"];
my work is simple : to check if length of strings in arr2 are larger than corresponding element with same index in ...
- 5,760
3
votes
5
answers
7k
views
What is the most concise way to test a boolean condition with many AND clauses?
I have a function which returns the availability of a module, where the module is only available if multiple conditions are all met. The code looks like this:
bool isShipAvailable() {
bool ...
- 149
0
votes
3
answers
151
views
Approaches for not complex conditions
I encountered code like this below. I was told its fine, and boilerplate is not always better. I agree boilerplate might be bad, but I am not sure about something like this:
if (entity....
- 103
-1
votes
1
answer
182
views
Enforcing IF, ELSEIF and ELSE on collection of ojects
I am designing a project where I have to enforce IF, ELSEIF and ELSE conditions on collection of objects.
For example:
public class Box {
private List<Item> items;
}
I want to define IF ...
- 163
1
vote
1
answer
1k
views
How to compute cyclomatic complexity for empty whiles and if + breaks?
This is closely related to this question which asks about the complexity of the following:
while (x > level)
x = x – 1;
x = 0
Using the graph method it has a Complexity = 2. Fred Swartz ...
- 452
5
votes
6
answers
12k
views
Best approach - convert multiple conditional if -else in a more handy design
I have a class that handles the state of a response, called StockResponse.
The code has multiple ifs to handle each state of the stock. Most of the cases has a default behaviour, but some conditions ...
- 622
4
votes
3
answers
2k
views
Best practice to avoid partial branches
I do a lot of coding in python and got a lot of if conditions without an else statement so to say partial branches.
E.g.:
# if a certain kwarg was passed to a function call
if kwargs.get('a_option'):...
- 149
0
votes
3
answers
4k
views
Which is more readable: early returns, or conditionals? [duplicate]
I’m writing an asynchronous, Promise-returning function. In the processing I test some conditions, and if the conditions pass, the promise should be fulfilled (resolved), but if one fails, then the ...
- 264
0
votes
1
answer
105
views
Multi-dimensional if-elseif-else block to call different functions
I have a function a plugin that is called whenever the WebAPI's "Plugin" endpoint is called in the main project, and that has to process the HTTP request. The request holds more information about what ...
- 181
46
votes
13
answers
20k
views
How do I edit a chain of if-else if statements to adhere to Uncle Bob's Clean Code principles?
I'm trying to follow Uncle Bob's clean code suggestions and specifically to keep methods short.
I find myself unable to shorten this logic though:
if (checkCondition()) {addAlert(1);}
else if (...
- 559
4
votes
2
answers
16k
views
PHP : Better way to print html in if-else conditions
Please refer the following two forms of the same code
First:
<?php if(some_condition){
?>
<li><a target="_blank" href="example.com/channel1/" class="xyz">If content</a>&...
- 173
187
votes
15
answers
79k
views
Developer insists if statements shouldn't have negated conditions, and should always have an else block
I have an acquaintance, a more seasoned developer than me.
We were talking about programming practices and I was taken aback by his approach on 'if' statements.
He insists on some practices regarding ...
- 1,647
2
votes
2
answers
3k
views
Long chained method calls contained within an if statement shown on a sequence diagram
Just wondering if there is a good way to do this? Currently i'm performing the method calls as if they were happening prior to the conditional block, then comparing what would be the result in "[...
- 23
1
vote
1
answer
202
views
How do I implement a run-only-once method when all criteria are met for the first time run it?
I need a run-only-once method that when all the criteria are met, say A&B&C are true, run the codes once, but only once. So if later on all the criteria are met again (A&B&C are true ...
- 3,305
4
votes
2
answers
5k
views
Store conditional expression in database
We have an application that allows users to enter conditionals in the form bound op x op bound2, we store this as a string, and then parse it at runtime to evaluate it.
It is a decent amount of work, ...
- 313
20
votes
7
answers
3k
views
Should "else" be used in situations where control flow renders it redundant?
I sometimes stumble upon code similar to the following example (what this function does exactly is out of the scope of this question):
function doSomething(value) {
if (check1(value)) {
return -...
- 357
3
votes
3
answers
777
views
Does if-else optimization in PHP have any effect?
Consider a scenario, where A occurs frequently like 4 out 5 times, and B only in rare cases, we can write our conditional statement in two ways:
if(A)
//do something
else
// do something if B, only ...
- 255
9
votes
2
answers
11k
views
Is it good practice to use array.pop() assignment in a while loop condition?
Just saw a code snippet that used an array pop assignment in the while condition; was wondering if this is acceptable/good practice?
var arr = [0,1,2,3,4,5];
var current;
while (current = arr.pop())
{...
- 103
-2
votes
3
answers
3k
views
Nested if statements or multiple if statements [duplicate]
Which way is better?
-- Option 1-------------
if ( condition1 )
{
statement1
}
else
{
exit program
}
if ( condition2 )
{
statement2
}
else
{
exit program
}
----...
1
vote
5
answers
826
views
How to optimize performance of sequential condition checks in Java?
I am writing a program that looks for a solution of a diophantine equation. The program is cycling
for (int d = 0; d <= max; d++) {
for (int c = 0; c < d; c++) {
boolean ...
- 469