PHP Infinite Loop "While" with Class

Question

I made my scripts without class. (framework). Now I have changed my mind & I wanna make my scripts with classes. I like it. But there I have a problem.. Infinite Loop While. I didn't take this problem before with without classes..

While Rule;

while ($fetch=$db->fetchObject($db->q("SELECT * FROM auction_house.items ORDER BY id DESC LIMIT ".$min_stuff.",".$max_stuff."")))
{
    // etc
}

Class;

public function fetchObject($queryRes)
{
    $this->queryRes = $queryRes;
    $this->record = mysql_fetch_object($this->queryRes);
    return $this->record;
}

When I try to while loop, I am taking infinite loop on page. How can I solve this problem?

I am taking values like this: echo $fetch->item_name;

liveth19937
– liveth19937

2013-05-07 10:56:57 +00:00
Commented May 7, 2013 at 10:56 — liveth19937
– liveth19937, Commented May 7, 2013 at 10:56

BlitZ · Accepted Answer · 2013-05-07 10:57:27Z

4

You executing query in each iteration. It always returns a new resource.

Try to separate query and cycle:

$res = $db->q("SELECT * FROM auction_house.items ORDER BY id DESC LIMIT ".$min_stuff.",".$max_stuff."");
while ($fetch=$db->fetchObject($res))
{
    // etc
}

answered May 7, 2013 at 10:57

BlitZ

12.2k3 gold badges52 silver badges70 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

liveth19937 Over a year ago

Thanks thats working!... ; You can accept an answer in 6 minutes.. :)

jtavares · Accepted Answer · 2013-05-07 10:58:50Z

1

Your code is executing on every while loop, so if you keep the $db->q nested there it will execute the query each time it loops, returning for each while iteration the first row of you query result.

try separating your code, like this:

$result = $db->q("SELECT * FROM auction_house.items ORDER BY id DESC LIMIT ".$min_stuff.",".$max_stuff."");
while ($fetch=$db->fetchObject($result)){
    // etc
}

this way the $db->q() will only be executed once, as intended, and the while will loop trough its results.

answered May 7, 2013 at 10:58

jtavares

4492 silver badges9 bronze badges

Comments

marc_s · Accepted Answer · 2017-05-30 16:12:57Z

0

You're starting a new query at each iteration.

You need to store your queryRes:

$queryRes = $db->q("SELECT * FROM auction_house.items ORDER BY id DESC LIMIT ".$min_stuff.",".$max_stuff."");

while ($fetch=$db->fetchObject($queryRes))
{
    // etc
}

On an another side, I'm not sure you should store queryRes and record as instance variable of $db.

edited May 30, 2017 at 16:12

marc_s

760k186 gold badges1.4k silver badges1.5k bronze badges

answered May 7, 2013 at 11:02

max collomb

8727 silver badges3 bronze badges

Collectives™ on Stack Overflow

PHP Infinite Loop "While" with Class

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related