Passing arguments values to shell script

Question

I'm using the following script to purge cache from cdn,

#!/bin/bash

##  API keys ##
zone_id=""
api_key=""
login_id=""
akamai_crd=""

## URL ##

urls="$1"
[ "$urls" == "" ] && { echo "Usage: $0 url"; exit 1; }

echo "Purging $urls..."

curl -X DELETE "https://api.cloudflare.com/client/v4/zones/${zone_id}/purge_cache" \
     -H "X-Auth-Email: ${login_id}" \
     -H "X-Auth-Key: ${api_key}" \
     -H "Content-Type: application/json" \
     --data "{\"files\":[\"${urls}\"]}"

#echo "CF is done now purging from Akamai ..."

echo  "..."

curl -v -s https://api.ccu.akamai.com/ccu/v2/queues/default -H "Content-Type:application/json" -d '{"objects":["$urls"]}' -u $akamai_crd

The 1st part for cloudflare is working fine the 2nd part when I pass it to Akamai

["$urls"]

I keep getting an error and it's passing the url as an argument it returns the variable itself ($urls) not the arg value.

I ran the script as following:

sh +x  script.sh  url

Any advise here?

I would suggest to this: SCRIPTNAME=$(basename "$0") if [ $# != 1 ] then echo "Usage: $SCRIPTNAME url" exit fi $urls="$2" — FrankTheTank_12345
– FrankTheTank_12345, Commented Jun 19, 2017 at 9:51
Then change your second curl-command like this: --data "{\"files\":[\"${urls}\"]}" — FrankTheTank_12345
– FrankTheTank_12345, Commented Jun 19, 2017 at 10:19

FrankTheTank_12345 · Accepted Answer · 2017-06-19 10:51:02Z

1

First i would change this:

SCRIPTNAME=$(basename "$0") 
...
if [ $# != 1 ] then 
    echo "Usage: $SCRIPTNAME url" 
    exit 
fi 

$urls="$1"

Change your second curl command as the following (you need to escape the quotes):

--data "{\"files\":[\"${urls}\"]}"

edited Jun 19, 2017 at 10:51

answered Jun 19, 2017 at 10:39

FrankTheTank_12345

5803 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

FrankTheTank_12345 Over a year ago

$2 was an fast copy and paste failure from me.

FrankTheTank_12345 Over a year ago

basename "$0" -> you get the scriptname wihtout "./"

John Kugelman Over a year ago

FWIW, common convention is to print usage with a raw $0. See ls --help versus /bin/ls --help, for example.

chepner · Accepted Answer · 2017-06-19 11:35:47Z

Avoid creating JSON by hand like this; you can't guarantee that the resulting JSON is properly escaped. Use a tool like jq instead.

#!/bin/bash

##  API keys ##
zone_id=""
api_key=""
login_id=""
akamai_crd=""

## URL ##

url=${1:?Usage: $0 url}

headers=(
  -H "X-Auth-Email: $login_id"
  -H "X-Auth-Key: $api_key"
  -H "Content-Type: application/json"
)

purge_endpoint="https://api.cloudflare.com/client/v4/zones/${zone_id}/purge_cache"

echo "Purging $url..."

jq -n --arg url "$url" '{files: [$url]}' | 
  curl -X DELETE "$purge_endpoing" "${headers[@]}" --data @-

#echo "CF is done now purging from Akamai ..."

echo  "..."

jq -n --arg url "$url" '{objects: [$url]}' | 
  curl -v -s -H "Content-Type:application/json" -d @- -u "$akamai_crd"

Collectives™ on Stack Overflow

Passing arguments values to shell script

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related