PowerShell command runs immediately instead of waiting for batch input

Question

When I use this simple batch code it runs the PowerShell command immediately, it should be waiting for the input of number '1' before executing the command.

The code:

@echo off
:start
Echo 1. Choose to run CMD as admin
set number=
if '%number%'=='1' goto a
:a
powershell -Command "Start-Process cmd -Verb RunAs
goto end
:end
pause

Magoo · Accepted Answer · 2017-08-25 19:22:42Z

2

set /P number=
if "%number%"=="1" goto a

The /p instructs "wait and assign input"

Double-quotes required to delimit strings

answered Aug 25, 2017 at 19:22

Magoo

80.8k8 gold badges68 silver badges92 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Maximilian Burszley Over a year ago

@Lieuwe To add on, I'd suggest using "Start-Process cmd -Verb runAs -NoNewWindow"

Compo Over a year ago

Despite the necessary change as answered by @Magoo, the powershell command will still run regardless of the value of %number%. This can be fixed easily by moving goto end to a new line above :a.

Compo · Accepted Answer · 2017-08-26 01:41:51Z

0

I would suggest something along these lines:

@Echo Off
Echo 1. Choose to run CMD as admin
Set/P "number="
If "%number%"=="1" GoTo a
GoTo end

:a
PowerShell -C "& {Start-Process Cmd -Verb RunAs -A "/K", "CD/D", "\"%~dp0""}"

:end
Pause

edited Aug 26, 2017 at 1:41

answered Aug 26, 2017 at 0:34

Compo

39k5 gold badges32 silver badges46 bronze badges

Collectives™ on Stack Overflow

PowerShell command runs immediately instead of waiting for batch input

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related