C# Iterating through list of objects

Question

First post on here so go easy on me!

I'm trying to deserialize a json document into a list of objects.

So far I've got two classes - one which contains the data structure:

 class Server
{
    public string hostname { get; set; }
    public string ipAddress { get; set; }
    public string monitoring { get; set; }
    public int pollingInterval { get; set; }

}

The other that contains the collection

    class ServerCollection 
{
    public List<Server> servers { get; set; }

}

In the applicaion I do a simple ReadAllText and I'm deserializing the object like so

private ServerCollection _servers;
string json = File.ReadAllText(@"c:\users\admin\desktop\server.monitoring\servers.json");
_servers = JsonConvert.DeserializeObject<ServerCollection>(json);

I'm struggling to iterate over this using a foreach... Can't think what I'm missing.

    Severity    Code    Description Project File    Line    Suppression State
Error   CS1579  foreach statement cannot operate on variables of type 'ServerCollection' because 'ServerCollection' does not contain a public instance definition for 'GetEnumerator'   Server.Monitoring.Service.Core  C:\Code\Admin\Server.Monitoring\Server.Monitoring.Service.Core\GetSystemHealth.cs   25  Active

Any ideas on what I've missed?

Thanks in advance!

What does the code that has the foreach look like and what does the JSON look like? — fredrik
– fredrik, Commented Feb 17, 2020 at 18:44

JSteward · Accepted Answer · 2020-02-17 18:43:46Z

1

class ServerCollection 
{
    public List<Server> servers { get; set; }

}

Is not a collection but Servers is, you need to iterate over that.

foreach (var server in _servers.servers)
{
    //do something with  server
}

answered Feb 17, 2020 at 18:43

JSteward

7,1312 gold badges24 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Syngate Over a year ago

Thanks, so simple! Just forgetting that last '.servers'

Jesse de gans Over a year ago

@Syngate you should mark this as the right answer ;)

mmathis · Accepted Answer · 2020-02-17 18:53:14Z

0

Your ServerCollection class does not implement the IEnumerable interface. You have two options:

Have ServerCollection implement that interface (i.e., public class ServerCollection : IEnumerable<Server> and add the necessary methods)
Loop over _servers.servers instead

The second option is the easier one to get you going, but implementing the interface may have other benefits down the road

edited Feb 17, 2020 at 18:53

answered Feb 17, 2020 at 18:44

mmathis

1,61020 silver badges33 bronze badges

Collectives™ on Stack Overflow

C# Iterating through list of objects

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related