async keyword not working on function using node js

Question

I don't know why i am getting this error

uncaughtException: await is only valid in async function

as i am using async keyword at getChild function still i am getting this error

my code:

async function filterFile(folderPath) {
  try {
    wantExt = [".jpg"];
    let parts;
    const paths = await checkFileLoc(folderPath, 3);
    const otherFiles = [];

    for (const filePath of paths) {
      parts = filePath.split("/");
      let splitFileName = parts[parts.length - 1].split(".");
      if (wantExt.includes(`.${splitFileName[splitFileName.length - 1]}`)) {
        otherFiles.push(filePath);
      }
    }
    let ignoreFile = otherFiles.filter((x) =>
      x.endsWith("_bio.jpg")
    );
    let test = otherFiles.filter((x) => !ignoreZipFile.includes(x));
    return { test };
  } catch (error) {
    console.log("error:", error);
  }
}

async function getChild(parents) {
  return new Promise(function (resolve, reject) {
    Shop.findAll({
      where: {
        shop_no: parents.id,
      },
      attributes: ["id", "name"],
    })
      .then((children) => {

        let gotValue= await filterFile(children);
        console.log(gotValue);

        resolve(children);
      })
      .catch(function (err) {
        reject(err);
      });
  });
}

and if i remove async from the function then I am getting gotValue as promise don't know how to get value

Oh, right, look at your getChild function. You use await but inside a non-async anonymous function (which is inside non-async Promise). You can't do that. — freakish
– freakish, Commented May 26, 2021 at 10:03
Shop.findAll is already a Promise. Why wrap it inside another Promise? — Jeremy Thille
– Jeremy Thille, Commented May 26, 2021 at 10:07

Vinod Bhatia · Accepted Answer · 2021-05-26 10:04:59Z

1

Try adding async to callback function in findAll

async function getChild(parents) {
  return new Promise(function (resolve, reject) {
    Shop.findAll({
      where: {
        shop_no: parents.id,
      },
      attributes: ["id", "name"],
    })
      .then(async (children) => { // Add it here

        let gotValue= await filterFile(children);
        console.log(gotValue);

        resolve(children);
      })
      .catch(function (err) {
        reject(err);
      });
  });
}

answered May 26, 2021 at 10:04

Vinod Bhatia

1114 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jeremy Thille Over a year ago

Shop.findAll is already a Promise. Why wrap it inside another Promise?

Majid Karimizadeh · Accepted Answer · 2021-05-26 10:05:17Z

1

You missed async keyword before

(children) => {
     let gotValue = await filterFile(children);
     console.log(gotValue);
     resolve(children);
}

function. It should be

async (children) => {
     let gotValue = await filterFile(children);
     console.log(gotValue);
     resolve(children);
}

answered May 26, 2021 at 10:05

Majid Karimizadeh

981 gold badge3 silver badges10 bronze badges

Comments

Isaac Khoo · Accepted Answer · 2021-05-26 10:05:20Z

1

"await is only valid in async function" Exactly as the error says, await is used inside an async function.

const fn = async () => { await someAsyncFunction() };

So in your scenario, make the callback async as well to await the filterFile code.

.then(async (children) => {
    let gotValue= await filterFile(children);
    console.log(gotValue);

    resolve(children);
 })

answered May 26, 2021 at 10:05

Isaac Khoo

5553 silver badges10 bronze badges

Comments

kayuapi_my · Accepted Answer · 2021-05-26 10:14:07Z

1

async function filterFile(folderPath) {
  try {
    wantExt = [".jpg"];
    let parts;
    const paths = await checkFileLoc(folderPath, 3);
    const otherFiles = [];

    for (const filePath of paths) {
      parts = filePath.split("/");
      let splitFileName = parts[parts.length - 1].split(".");
      if (wantExt.includes(`.${splitFileName[splitFileName.length - 1]}`)) {
        otherFiles.push(filePath);
      }
    }
    let ignoreFile = otherFiles.filter((x) =>
      x.endsWith("_bio.jpg")
    );
    let test = otherFiles.filter((x) => !ignoreZipFile.includes(x));
    return { test };
  } catch (error) {
    console.log("error:", error);
  }
}

async function getChild(parents) {
  try {
    const children = await Shop.findAll({
      where: {
        shop_no: parents.id,
      },
      attributes: ["id", "name"],
    });
    let gotValue= await filterFile(children);
    console.log(gotValue);
    return children;
  } catch(err) {
    throw(err);
  }
}

edited May 26, 2021 at 10:14

answered May 26, 2021 at 10:03

kayuapi_my

5081 gold badge6 silver badges9 bronze badges

2 Comments

Jeremy Thille Over a year ago

Shop.findAll is already a Promise. Why wrap it inside another Promise?

kayuapi_my Over a year ago

@JeremyThille you're right, I edited the answer.

Collectives™ on Stack Overflow

async keyword not working on function using node js

4 Answers 4

1 Comment

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related