Skip to content

feat(matter): adds rain sensor matter endpoint #12100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2025
Merged

feat(matter): adds rain sensor matter endpoint #12100

merged 3 commits into from
Dec 4, 2025
+648 −0

Conversation

@SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Dec 3, 2025

Description of Change

Adds a new Matter Endpoint: Rain Sensor, with related example, readme and documentation.

Test Scenarios

ESP32-S3

Related links

None

@SuGlider SuGlider added this to the 3.3.0 milestone Dec 3, 2025
@SuGlider SuGlider self-assigned this Dec 3, 2025
@SuGlider SuGlider added the Area: Matter Issues and Feature Request about Matter Protocol label Dec 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello SuGlider, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against f113707

@SuGlider SuGlider moved this from Todo to In Progress in Arduino ESP32 Core Project Roadmap Dec 3, 2025
@SuGlider SuGlider marked this pull request as draft December 3, 2025 17:38
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025 •
edited
Loading

Test Results

 83 files   83 suites   27m 23s ⏱️
 55 tests  55 ✅ 0 💤 0 ❌
598 runs  598 ✅ 0 💤 0 ❌

Results for commit f113707.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025 •
edited
Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5000.000.00000.000.00
ESP32S30⚠️ +1120.00⚠️ +0.01000.000.00
ESP32S20⚠️ +1120.00⚠️ +0.01000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP320⚠️ +1120.00⚠️ +0.01000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/Matter/examples/MatterColorLight00⚠️ +1120⚠️ +1120000000⚠️ +1120
libraries/Matter/examples/MatterCommissionTest00⚠️ +1120⚠️ +1120000000⚠️ +960
libraries/Matter/examples/MatterComposedLights00⚠️ +1120⚠️ +1120000000⚠️ +1120
libraries/Matter/examples/MatterContactSensor00⚠️ +1120⚠️ +1120000000⚠️ +1120
libraries/Matter/examples/MatterDimmableLight00⚠️ +1120⚠️ +1120000000⚠️ +1120
libraries/Matter/examples/MatterEnhancedColorLight00⚠️ +1120⚠️ +1120000000⚠️ +1120
libraries/Matter/examples/MatterEvents00⚠️ +1120⚠️ +1120000000⚠️ +1120
libraries/Matter/examples/MatterFan00⚠️ +1120⚠️ +1120000000⚠️ +1120
libraries/Matter/examples/MatterHumiditySensor00⚠️ +1120⚠️ +1120000000⚠️ +1120
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs00⚠️ +1120⚠️ +1120000000⚠️ +1120
libraries/Matter/examples/MatterMinimum00⚠️ +1120⚠️ +1120000000⚠️ +1120
libraries/Matter/examples/MatterOccupancySensor00⚠️ +1120⚠️ +1120000000⚠️ +1120
libraries/Matter/examples/MatterOnIdentify00⚠️ +1120⚠️ +1120000000⚠️ +1120
libraries/Matter/examples/MatterOnOffLight00⚠️ +1120⚠️ +1120000000⚠️ +1120
libraries/Matter/examples/MatterOnOffPlugin00⚠️ +1120⚠️ +1120000000⚠️ +1120
libraries/Matter/examples/MatterPressureSensor00⚠️ +1120⚠️ +1120000000⚠️ +1120
libraries/Matter/examples/MatterRainSensor--------------
libraries/Matter/examples/MatterSmartButton00⚠️ +1120⚠️ +1120000000⚠️ +1120
libraries/Matter/examples/MatterTemperatureLight00⚠️ +1120⚠️ +1120000000⚠️ +1120
libraries/Matter/examples/MatterTemperatureSensor00⚠️ +1120⚠️ +1120000000⚠️ +1120
libraries/Matter/examples/MatterThermostat00⚠️ +1120⚠️ +1120000000⚠️ +1120

@SuGlider SuGlider moved this from In Progress to In Review in Arduino ESP32 Core Project Roadmap Dec 3, 2025
@SuGlider SuGlider added the Status: Review needed Issue or PR is awaiting review label Dec 3, 2025
@SuGlider SuGlider marked this pull request as ready for review December 3, 2025 18:47
@SuGlider SuGlider requested a review from me-no-dev as a code owner December 3, 2025 18:47
@SuGlider SuGlider requested a review from P-R-O-C-H-Y December 3, 2025 18:47
@me-no-dev me-no-dev requested a review from Copilot December 4, 2025 09:25
Copilot finished reviewing on behalf of me-no-dev December 4, 2025 09:28
Copilot AI reviewed Dec 4, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new Matter endpoint for rain sensors, enabling ESP32 devices to function as Matter-compatible rain detection sensors. The implementation follows the established pattern of similar boolean state sensors in the codebase.

Key changes:

  • New MatterRainSensor class implementing rain detection state (detected/not detected)
  • Complete example demonstrating rain sensor functionality with button control and automatic simulation
  • Comprehensive documentation including API reference and integration guides

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
libraries/Matter/src/MatterEndpoints/MatterRainSensor.h Defines the MatterRainSensor class with rain detection state management and boolean operators
libraries/Matter/src/MatterEndpoints/MatterRainSensor.cpp Implements rain sensor initialization, state management, and Matter attribute handling
libraries/Matter/src/Matter.h Adds MatterRainSensor include and friend class declaration for integration
libraries/Matter/keywords.txt Adds syntax highlighting keywords for MatterRainSensor, setRain, and getRain
libraries/Matter/examples/MatterRainSensor/MatterRainSensor.ino Complete working example with button control, LED indication, and automatic state simulation
libraries/Matter/examples/MatterRainSensor/README.md Comprehensive documentation covering hardware setup, configuration, and smart home integration
libraries/Matter/examples/MatterRainSensor/ci.yml CI configuration specifying required partition scheme and Matter data model
docs/en/matter/ep_rain_sensor.rst API reference documentation with detailed method descriptions and usage examples
docs/en/matter/matter.rst Updates endpoint list to include MatterRainSensor
CMakeLists.txt Adds MatterRainSensor.cpp to the build configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pedrominatel
pedrominatel approved these changes Dec 4, 2025
View reviewed changes
Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Dec 4, 2025
@me-no-dev me-no-dev merged commit e540af2 into master Dec 4, 2025
80 checks passed
@me-no-dev me-no-dev deleted the matter_rain_sensor_ep branch December 4, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@pedrominatel pedrominatel pedrominatel approved these changes

@me-no-dev me-no-dev me-no-dev approved these changes

@lucasssvaz lucasssvaz lucasssvaz approved these changes

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

@SuGlider SuGlider

Labels

Area: Matter Issues and Feature Request about Matter Protocol Status: Pending Merge Pull Request is ready to be merged

Projects

Arduino ESP32 Core Project Roadmap
Status: Done

Milestone

3.3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@SuGlider @pedrominatel @me-no-dev @lucasssvaz @P-R-O-C-H-Y