[CI][UR] Bump DPC++ version used in UR workflow #20781
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pip install -r third_party/requirements.txt | ||
| pip install -r third_party/requirements_testing.txt | ||
| - name: Download DPC++ |
Contributor
Author
There was a problem hiding this comment.
my thought here is - when we first introduced this workflow it was the easiest way of using dpc++ in UR workflow. We didn't want to introduce too much changes in CI... but now, almost one year later we're still using this approach. It doesn't look too good, am I wrong?
Perhaps, we should use nightly docker images or integrate this workflow into sycl-linux-precommit and make use of toolchain_artifact...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.