MySQL Update Statement Not Working Correctly

Question

I am updating my database with a form. I have it outputting the values of everything to check to make sure everyting is working correctly and it is, but when it adds it to the database everything is wrong. If the quantity is 20000 it just changes the quantity in the inventory to 1. I dont understand. I am still learning MySQL but this is irritating

<?php
if($_SERVER['REQUEST_METHOD'] == 'POST')
{
    require("serverInfo.php");
    for($i = 0; $i < 10; $i++){
        $quantity = $_POST['quantity'.$i];
        $company = $_POST['company'.$i];
        $size = $_POST['cardSize'.$i];

        if(isset($_POST['box'.$i])){
            echo $quantity . "<br / >";
            echo $size . "<br / >";
            echo $company . "<br / >";
            mysql_query("UPDATE `printRun` SET Quantity = '$quantity' AND Size = '$size'  where status='Open' AND Company = '$company'");
        }
    }
    mysql_close($link);
}
?>

What are the "Types" set as? What character limit did you give them? — Paul Dessert
– Paul Dessert, Commented Apr 6, 2012 at 20:35
In other words, is the database columnn Quantity an integer or a character string (varchar)? — David Gorsline
– David Gorsline, Commented Apr 6, 2012 at 20:37

philwinkle · Accepted Answer · 2012-04-06 20:35:58Z

4

I will spare you the usual lecture about echoing and updating into your database unfiltered form data .... but your update syntax is incorrect. Try this instead (no AND in the column list)

UPDATE printRun SET quantity='$quantity', size = '$size' where status='Open' AND Company = '$company'

http://dev.mysql.com/doc/refman/4.1/en/update.html

answered Apr 6, 2012 at 20:35

philwinkle

7,0193 gold badges29 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

philwinkle Over a year ago

I would most certainly research MySQL prepared statements which will help you to maintain your code more effectively and ward off the most blatant of attacks such as SQL injection.

Sensa · Accepted Answer · 2012-04-06 20:36:00Z

3

Try

mysql_query("UPDATE `printRun` SET Quantity = '$quantity', Size = '$size'  where status='Open' AND Company = '$company'");

answered Apr 6, 2012 at 20:36

Sensa

3933 gold badges6 silver badges21 bronze badges

1 Comment

shinjuo Over a year ago

that did indeed fix it. Thanks

Collectives™ on Stack Overflow

MySQL Update Statement Not Working Correctly

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related