Foreach loop : duplicates output error

Question

My code is as follows

$aNewCodes = array("93", "355", "213");
$aServiceProviderId = array();
$oTerminationRate = new TerminationRate();

foreach ($aNewCodes as $iNewCodesKey => $iNewCodesValue)
{
    $oTerminationRate->GetServiceProviders($aServiceProviderId, $iNewCodesValue);

    foreach($aServiceProviderId as $iProviderKey => $iProviderValue)
    {
        echo $iNewCodesValue." :: ".$iProviderValue."<br>";
    }
}

And it gives me output like this -

93 :: 1
93 :: 2
355 :: 1
355 :: 2
355 :: 1
355 :: 2
213 :: 1
213 :: 2
213 :: 1
213 :: 2
213 :: 1
213 :: 2

Actually I am expecting output like this -

93 :: 1
93 :: 2
355 :: 1
355 :: 2
213 :: 1
213 :: 2

Tried a lot to get that output, but no success. Where am I missing out ?

You are probably missing the part where GetServiceProviders accepts its first argument by reference and adds two items to it. If it did not, your code would not give any output. — Jon
– Jon, Commented Apr 17, 2012 at 10:34
yes, it accepts by reference, and the code does gives the output.. — skos
– skos, Commented Apr 17, 2012 at 10:37

Aleks G · Accepted Answer · 2012-04-17 10:36:37Z

1

Your problem is that you are not deleting previous entries from the aServiceProviderId array on each iteration of the loop. Put line

$aServiceProviderId = array();

inside the first loop - right before

$oTerminationRate->GetServiceProviders($aServiceProviderId, $iNewCodesValue);

And you should be ok.

answered Apr 17, 2012 at 10:36

Aleks G

57.5k34 gold badges180 silver badges280 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Jon Over a year ago

So, resetting the value of the one variable that is not used anywhere in this snippet will fix the problem?

skos Over a year ago

$oProviderForCountry = new ProviderForCountry(); is unnecessary in the code

Aleks G Over a year ago

@Jon Sorry, I copied/pasted a wrong line from the OP's code. I now corrected it. You could have just edited the answer

Aleks G Over a year ago

@Sachyn I corrected my mistake in the code - wrong copy/paste

Jon Over a year ago

@AleksG: Removed the downvote, but this is still wrong and two wrongs do not make a right. GetServiceProviders is in obvious need of refactoring; slapping a band-aid on a broken design does not fix the design or prevent more problems in the future.

|

Collectives™ on Stack Overflow

Foreach loop : duplicates output error

1 Answer 1

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related