function will not call another function, javascript

Question

For a class project i am trying to count the number of clicks a button gets, save the search term, and then open a new html file. my problem is that the "doCoolThings" function will not call the "newWindow" function. I cannot figure out how to get the newWindow function to execute after i click submit.

here is my code:

window.onload = init;
function init() {
    var myButton = document.getElementById("submitButton");
    myButton.onclick = doCoolThings;
    }


function doCoolThings(){
    alert("test count");
    localStorage.searchTerms = document.getElementById("searchWord").value;
    //var searchOutput = document.getElementById("searchOutput");
    searchWord.innerHTML = searchTerms;

    if (localStorage.clickcount)
        {
        localStorage.clickcount=Number(localStorage.clickcount)+1;
        //window.open("scroogleresults.html");
        }
    else
        {
        localStorage.clickcount=1;
        //window.location="scroogleresults.html";       
        }
    var myCounter = document.getElementById("numberClicks");
    var counter = localStorage.clickcount;
    myCounter.innerHTML = counter;
    newWindow();
}
function newWindow(){       
        alert("new window");
        window.open("scroogleresults.html");            
    }

What, if any, output do you see in your console when attempting to run this? A very basic representation of this setup works as expected: jsbin.com/izeyej/3/edit — Sampson
– Sampson, Commented Apr 23, 2012 at 4:17
okay change window.onload = init; to window.onload = init(); and check — Adil
– Adil, Commented Apr 23, 2012 at 4:19
i get the alert about the test count, but not a new window/i changed it to window.location to open in the same window. I can tell the doCoolThings function works because i use the results in a different window — user1350447
– user1350447, Commented Apr 23, 2012 at 4:20

jfriend00 · Accepted Answer · 2012-04-23 04:18:05Z

1

If this is the extent of your code, it looks to me like you have some javascript errors. You should be checking the error console or debug console in your browser for javascript errors that cause your scripts to abort. Here are a couple errors I see:

Error #1

In doCoolThings(), when you do this:

searchWord.innerHTML = searchTerms;

I don't see any place that searchTerms is defined so this would generate a script error.

Error #2

You should be using getItem() and setItem() to access localStorage.

edited Apr 23, 2012 at 4:18

answered Apr 23, 2012 at 4:12

jfriend00

711k104 gold badges1.1k silver badges1k bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

function will not call another function, javascript

1 Answer 1

Error #1

Error #2

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Error #1

Error #2

Comments

Your Answer

Sign up or log in

Post as a guest

Related