Php Validation inside if statement

Question

I'd like to know if the following php validation is properly coded. It works, but I'd like to know if there's a better way to do it.

if(isset($_POST['account_type']) && $_POST['account_type']==2){

if ((strlen(utf8_decode($this->request->post['cnpj'])) < 3) || (strlen(utf8_decode($this->request->post['cnpj'])) > 32)) {
            $this->error['cnpj'] = $this->language->get('error_cnpj');
        }   
}

I need it like this because I have a hidden required field that is shown only to the customers who are applying for a corporate account. The field is shown after clicking a radio button. So I only need to validate that field [cnpj] when a customer clicks on the retailer account radio button with a value=2.

Thanks a lot.

Marvin M

What is the expected value of $this->request->post['cnpj']? int or string? — Lawrence Cherone
– Lawrence Cherone, Commented Apr 26, 2012 at 4:50
@Chandresh... and your comment is relevant to my question because... — codekmarv
– codekmarv, Commented Apr 26, 2012 at 5:18
.... because people won't feel inclined to help if you don't accept their answers. That's why. — maiorano84
– maiorano84, Commented Apr 26, 2012 at 5:31
25% accept is unacceptable. People more likely to help if the poster gives them points. It's just a game to everyone. — Jack
– Jack, Commented Apr 26, 2012 at 6:00

Chandresh M · Accepted Answer · 2012-04-26 05:10:22Z

1

You can do your code like below lines of code:

if($_POST['account_type']==2 && $this->formValidation()){

       // Do your next process what you want to do if all set

}else{

     return $this->error;

}

// function for form validation

function formValidation(){

if ((strlen(utf8_decode($this->request->post['cnpj'])) < 3) || (strlen(utf8_decode($this->request->post['cnpj'])) > 32)) {
            $this->error['cnpj'] = $this->language->get('error_cnpj');
        }   

}

I think this would be a batter way to do all the form validation at server side. and also most of MVC structures follow this way.

answered Apr 26, 2012 at 5:10

Chandresh M

3,4932 gold badges27 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Php Validation inside if statement

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related