I've heard that the static_cast function should be preferred to C-style or simple function-style casting. Is this true? Why?
-
47Objection your honour, asked and answered.Graeme Perrow– Graeme Perrow2008-09-19 16:36:23 +00:00Commented Sep 19, 2008 at 16:36
-
36I disagree, this other question was about describing the differences between casts introduces in C++. This question is about the real usefulness of static_cast, which is slightly different.Vincent Robert– Vincent Robert2008-09-19 16:40:48 +00:00Commented Sep 19, 2008 at 16:40
-
2We could certainly merge the two questions, but what we'd need to preserve from this thread is the advantage of using functions over C-style casting, which is currently only mentioned in a one-line answer in the other thread, with no votes.Tommy Herbert– Tommy Herbert2008-09-20 08:26:35 +00:00Commented Sep 20, 2008 at 8:26
-
7This question is about "built-in" types, like int, whereas that question is about class types. That seems like a significant enough difference to merit a separate explanation.user153275– user1532752011-04-19 21:21:07 +00:00Commented Apr 19, 2011 at 21:21
-
13static_cast is actually an operator, not a function.ThomasMcLeod– ThomasMcLeod2013-02-25 13:47:12 +00:00Commented Feb 25, 2013 at 13:47
9 Answers
The main reason is that classic C casts make no distinction between what we call static_cast<>(), reinterpret_cast<>(), const_cast<>(), and dynamic_cast<>(). These four things are completely different.
A static_cast<>() is usually safe. There is a valid conversion in the language, or an appropriate constructor that makes it possible. The only time it's a bit risky is when you cast down to an inherited class; you must make sure that the object is actually the descendant that you claim it is, by means external to the language (like a flag in the object). A dynamic_cast<>() is safe as long as the result is checked (pointer) or a possible exception is taken into account (reference).
A reinterpret_cast<>() (or a const_cast<>()) on the other hand is always dangerous. You tell the compiler: "trust me: I know this doesn't look like a foo (this looks as if it isn't mutable), but it is".
The first problem is that it's almost impossible to tell which one will occur in a C-style cast without looking at large and disperse pieces of code and knowing all the rules.
Let's assume these:
class CDerivedClass : public CMyBase {...};
class CMyOtherStuff {...} ;
CMyBase *pSomething; // filled somewhere
Now, these two are compiled the same way:
CDerivedClass *pMyObject;
pMyObject = static_cast<CDerivedClass*>(pSomething); // Safe; as long as we checked
pMyObject = (CDerivedClass*)(pSomething); // Same as static_cast<>
// Safe; as long as we checked
// but harder to read
However, let's see this almost identical code:
CMyOtherStuff *pOther;
pOther = static_cast<CMyOtherStuff*>(pSomething); // Compiler error: Can't convert
pOther = (CMyOtherStuff*)(pSomething); // No compiler error.
// Same as reinterpret_cast<>
// and it's wrong!!!
As you can see, there is no easy way to distinguish between the two situations without knowing a lot about all the classes involved.
The second problem is that the C-style casts are too hard to locate. In complex expressions it can be very hard to see C-style casts. It is virtually impossible to write an automated tool that needs to locate C-style casts (for example a search tool) without a full blown C++ compiler front-end. On the other hand, it's easy to search for "static_cast<" or "reinterpret_cast<".
pOther = reinterpret_cast<CMyOtherStuff*>(pSomething);
// No compiler error.
// but the presence of a reinterpret_cast<> is
// like a Siren with Red Flashing Lights in your code.
// The mere typing of it should cause you to feel VERY uncomfortable.
That means that, not only are C-style casts more dangerous, but it's a lot harder to find them all to make sure that they are correct.
28 Comments
static_cast for casting down an inheritance hierarchy, but rather dynamic_cast. That will return either the null pointer or a valid pointer.static_cast in that situation. dynamic_cast might be safer, but it's not always the best option. Sometimes you do know that a pointer points to a given subtype, by means opaque to the compiler, and a static_cast is faster. In at least some environments, dynamic_cast requires optional compiler support and runtime cost (enabling RTTI), and you might not want to enable it just for a couple of checks you can do yourself. C++'s RTTI is only one possible solution to the problem.static_cast. The C equivalent of reinterpret_cast is *(destination_type *)&, i.e. taking the address of the object, casting that address to a pointer to a different type, and then dereferencing. Except in the case of character types or certain struct types for which C defines the behavior of this construct, it generally results in undefined behavior in C.int (and int alone), why use static_cast<int> vs. (int) as the only benefit seems to be with class variables and pointers. Request that you elaborate on this.int dynamic_cast doesn't apply, but all the other reasons stand. For example: let's say v is a function parameter declared as float, then (int)v is static_cast<int>(v). But if you change the parameter to float*, (int)v quietly becomes reinterpret_cast<int>(v) while static_cast<int>(v) is illegal and correctly caught by the compiler.One pragmatic tip: you can search easily for the static_cast keyword in your source code if you plan to tidy up the project.
5 Comments
int parameter.In short:
static_cast<>()gives you a compile time checking ability, C-Style cast doesn't.static_cast<>()can be spotted easily anywhere inside a C++ source code; in contrast, C_Style cast is harder to spot.- Intentions are conveyed much better using C++ casts.
More Explanation:
The static cast performs conversions between compatible types. It is similar to the C-style cast, but is more restrictive. For example, the C-style cast would allow an integer pointer to point to a char.
char c = 10; // 1 byte int *p = (int*)&c; // 4 bytesSince this results in a 4-byte pointer pointing to 1 byte of allocated memory, writing to this pointer will either cause a run-time error or will overwrite some adjacent memory.
*p = 5; // run-time error: stack corruptionIn contrast to the C-style cast, the static cast will allow the compiler to check that the pointer and pointee data types are compatible, which allows the programmer to catch this incorrect pointer assignment during compilation.
int *q = static_cast<int*>(&c); // compile-time error
Read more on:
What is the difference between static_cast<> and C style casting
and
Regular cast vs. static_cast vs. dynamic_cast
8 Comments
static_cast<>() is more readable. I mean, sometimes it is, but most of the time — especially on basic integer types — it's just horribly and unnecessarily verbose. For example: This is a function that swaps the bytes of a 32-bit word. It would be nearly impossible to read using static_cast<uint##>() casts, but is quite easy to understand using (uint##) casts. Picture of code: imgur.com/NoHbGvealways either. (but most of the times yes) There sure are cases where the c style cast is way more readable. Thats one of the reasons c style casting is still live and kicking in c++ imho. :) By the way that was a very nice example(uint32_t)(uint8_t)) to achieve that bytes besides lowest are reset. For that there is bitwise and (0xFF &). Usage of casts is obfuscating the intention.The question is bigger than just using whether static_cast<> or C-style casting because there are different things that happen when using C-style casts. The C++ casting operators are intended to make those different operations more explicit.
On the surface static_cast<> and C-style casts appear to be the same thing, for example when casting one value to another:
int i;
double d = (double)i; //C-style cast
double d2 = static_cast<double>( i ); //C++ cast
Both of those cast the integer value to a double. However when working with pointers things get more complicated. Some examples:
class A {};
class B : public A {};
A* a = new B;
B* b = (B*)a; //(1) what is this supposed to do?
char* c = (char*)new int( 5 ); //(2) that weird?
char* c1 = static_cast<char*>( new int( 5 ) ); //(3) compile time error
In this example (1) may be OK because the object pointed to by A is really an instance of B. But what if you don't know at that point in code what a actually points to?
(2) may be perfectly legal (you only want to look at one byte of the integer), but it could also be a mistake in which case an error would be nice, like (3).
The C++ casting operators are intended to expose these issues in the code by providing compile-time or run-time errors when possible.
So, for strict "value casting" you can use static_cast<>. If you want run-time polymorphic casting of pointers use dynamic_cast<>. If you really want to forget about types, you can use reintrepret_cast<>. And to just throw const out the window there is const_cast<>.
They just make the code more explicit so that it looks like you know what you were doing.
Comments
static_cast means that you can't accidentally const_cast or reinterpret_cast, which is a good thing.
2 Comments
- Allows casts to be found easily in your code using grep or similar tools.
- Makes it explicit what kind of cast you are doing, and engaging the compiler's help in enforcing it. If you only want to cast away const-ness, then you can use const_cast, which will not allow you to do other types of conversions.
- Casts are inherently ugly -- you as a programmer are overruling how the compiler would ordinarily treat your code. You are saying to the compiler, "I know better than you." That being the case, it makes sense that performing a cast should be a moderately painful thing to do, and that they should stick out in your code, since they are a likely source of problems.
See Effective C++ Introduction
4 Comments
C Style casts are easy to miss in a block of code. C++ style casts are not only better practice; they offer a much greater degree of flexibility.
reinterpret_cast allows integral to pointer type conversions, however can be unsafe if misused.
static_cast offers good conversion for numeric types e.g. from as enums to ints or ints to floats or any data types you are confident of type. It does not perform any run time checks.
dynamic_cast on the other hand will perform these checks flagging any ambiguous assignments or conversions. It only works on pointers and references and incurs an overhead.
There are a couple of others but these are the main ones you will come across.
Comments
It's about how much type-safety you want to impose.
When you write (bar) foo (which is equivalent to reinterpret_cast<bar> foo if you haven't provided a type conversion operator) you are telling the compiler to ignore type safety, and just do as it's told.
When you write static_cast<bar> foo you are asking the compiler to at least check that the type conversion makes sense and, for integral types, to insert some conversion code.
EDIT 2014-02-26
I wrote this answer more than 5 years ago, and I got it wrong. (See comments.) But it still gets upvotes!
3 Comments
static_cast<bar>(foo), with parentheses. Same for reinterpret_cast<bar>(foo).static_cast, aside from manipulating pointers to classes, can also be used to perform conversions explicitly defined in classes, as well as to perform standard conversions between fundamental types:
double d = 3.14159265;
int i = static_cast<int>(d);
5 Comments
static_cast<int>(d), though, when (int)d is so much more concise and readable? (I mean in the case of basic types, not object pointers.)(int)d when int{d} is so much more readable? Constructor, or function-like if you have (), syntax isn't nearly so fast to devolve into a nightmarish maze of parentheses in complex expressions. In this case, it'd be int i{d} instead of int i = (int)d. Far better IMO. That said, when I just need a temporary in an expression, I use static_cast and have never used constructor casts, I don't think. I only use (C)casts when hurriedly writing debug couts...