Having trouble copying a String in an array to a String variable

Question

I'm doing a relatively simple file read, and I've been experiencing anomalies in my validation between an input value and a data value read from a flat file and stored in an array. I've traced the error to the firstName field. I'm defining this field as equal to array[0]. While array[0] displays perfectly in my output, fieldName does not...it's either blank or null.

Here's my code, with an output sample.

I'm not sure if Stringbuilder is most appropriately used here? or one of the deep String methods? None of what I've tried seems to work. What am I missing...I know it's something obvious that I just can't see.

public class DisplaySelectedNumbers
{
    public static void main(String[] args)
    {
        final String FN = "            ";
        final String LN = "            ";
        final String PHONE = "0000000000";
        String delimiter = ",";
        String s = FN + delimiter + LN + delimiter + PHONE + System.getProperty("line.separator");
        final int RECSIZE = s.length();
        String[] array = new String[3];
        Scanner kb = new Scanner(System.in);
        Path file = Paths.get("PhoneList.txt");
        String fName = JOptionPane.showInputDialog(null,"Enter first name to search");
        try
        {
            InputStream iStream=new BufferedInputStream(Files.newInputStream(file));
            BufferedReader reader=new BufferedReader(new InputStreamReader(iStream));
            while ((s = reader.readLine()) != null)
            {
                array = s.split(delimiter);
                String dispString = array[0]+" "+array[1]+" "+array[2]+"\n";
                System.out.println("array[0]="+array[0]);
                System.out.println("array[1]="+array[1]);
                System.out.println("array[2]="+array[2]);
                String firstName = array[0];
                System.out.println("firstName=");
                    s=reader.readLine();
            }
        }
        catch(Exception e)
        {
            System.out.println("Message: " + e);
        }
    }
}


array[0]=D
array[1]=JJ
array[2]=0123450000
firstName=
array[0]=B
array[1]=EE
array[2]=1111111111
firstName=
array[0]=D
array[1]=GG
array[2]=0033333333
firstName=

Lol, you seriously are not able to figure it out? :P This is what happens when you over think stuff :-) — noMAD
– noMAD, Commented Apr 30, 2012 at 17:56

Attila · Accepted Answer · 2012-04-30 17:54:15Z

5

You forgot to actually print the firstName variable:

System.out.println("firstName=");

You need instead:

System.out.println("firstName=" + firstName);

answered Apr 30, 2012 at 17:54

Attila

28.9k3 gold badges50 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

dwwilson66 Over a year ago

Hey, guess what! It works! OMG. Can I downvote myself for being blind? Thansk for the second set of eyes.

Ido.Co Over a year ago

Don't worry and no need to downvote. This can happen to anyone!

Community · Accepted Answer · 2017-05-23 12:29:07Z

1

Not really a complete answer for your question, but yes, using StringBuilder in your code would be better if you need to improve String concatenation speed, specially in a loop.

StringBuilder vs String concatenation

edited May 23, 2017 at 12:29

CommunityBot

11 silver badge

answered Apr 30, 2012 at 18:06

ceklock

6,42111 gold badges59 silver badges79 bronze badges

Collectives™ on Stack Overflow

Having trouble copying a String in an array to a String variable

2 Answers 2

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related