php inserting preg_match_all array

Question

this is a code to catch all url in the POST and shorting them then insert each of them in row in mysql ..... but here it is inserting all the url in one row ?? so how can i make it catch the first url then insert it in database then go back for the second one and do the same..???

$urlinput=mysql_real_escape_string($_POST['url']); 
$pattren="/(http:\/\/)[a-zA-Z0-9]*\.[a-z]*(.*)|(www)\.[a-zA-Z0-9]*\.[com]*(.*)/";
preg_match_all( $pattren, $urlinput, $matches );
foreach($matches[0] as $match) {

$id=rand(10000,99999);
$shorturl=base_convert($id,20,36);
$sql = "insert into url values('$id','$match','$shorturl')";
mysql_query($sql,$con);
}

what's your input look like? What is between the urls? spaces? new lines? — Gavriel
– Gavriel, Commented May 11, 2012 at 7:29

Gavriel · Accepted Answer · 2012-05-11 07:32:32Z

1

Here http://php.net/manual/en/function.preg-match-all.php you can read about the 4th parameter of preg_match_all. You can loop over the urls found. I changed the end of your regular expression, so it won't catch the whole line:

$urlinput=mysql_real_escape_string($_POST['url']); 
$pattren="/(http:\/\/)[a-zA-Z0-9]*\.[a-z]*(.*)|(www)\.[a-zA-Z0-9]*\.[com]*([a-zA-Z0-9\.\-_\/\?=\:]*)/";
preg_match_all( $pattren, $urlinput, $matches, PREG_SET_ORDER );
foreach($matches as $match) {
  $id=rand(10000,99999);
  $shorturl=base_convert($id,20,36);
  $sql = "insert into url values('$id','" . mysql_real_escape_string($match[0]) . "','$shorturl')";
  mysql_query($sql,$con);
}

Also be careful with SQL injection, and use mysql_real_escape_string when you use user data in your queries.

edited May 11, 2012 at 7:32

answered May 11, 2012 at 7:03

Gavriel

19.3k13 gold badges73 silver badges116 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

eggyal Over a year ago

You might want to check the documentation for preg_match_all(): elements of $matches correspond to each parenthesised subpattern (except $matches[0] which are the full pattern matches).

Timothée Groleau · Accepted Answer · 2012-05-11 07:05:44Z

0

well, "(.*)" in your regex matches everything after it has found the beginning of a url. so if you're expecting multiple urls in one string, or coma separated or what not, they will all be bundled together.

You need to be able to split your input first, and then validate that each element is a valid url before you pick it up for insertion.

answered May 11, 2012 at 7:05

Timothée Groleau

1,96013 silver badges18 bronze badges

Collectives™ on Stack Overflow

php inserting preg_match_all array

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related