2

I am new to android and java. I made an application which works fine except that i get java.lang.OutOfMemoryError exception when i scroll down the listviews in my app which increase dynamically (10 items) every time i scroll to the bottom. after scrolling some 4-5 pages i get this exception. can any one hep me solve this exception and some tips to avoid such exceptions.

My Adapter:

public class LazyAdapter extends BaseAdapter{

    private static LayoutInflater inflater = null;
    private Activity activity;
    public ImageLoader imageLoader;
    public static ArrayList<Product> values;
    private String product_action;

    public LazyAdapter(Activity a, ArrayList<Product> arg3) {

        values = arg3;
        activity = a;
        inflater = (LayoutInflater) activity
                .getSystemService(Context.LAYOUT_INFLATER_SERVICE);
        imageLoader = new ImageLoader(activity.getApplicationContext());
    }

    public int getCount() {

        return values.size();
    }

    public Object getItem(int position) {

        return position;
    }

    public long getItemId(int position) {

        return position;
    }

    public static class ViewHolder {

        public TextView text;
        public ImageView image;
    }

    public View getView(int position, View convertView, ViewGroup parent) {

        View vi = convertView;
        ViewHolder holder;

        Product p = values.get(position);

        if (convertView == null) {
            vi = inflater.inflate(R.layout.feed_items, null);
            holder = new ViewHolder();
            holder.text = (TextView) vi.findViewById(R.id.label);
            ;
            holder.image = (ImageView) vi.findViewById(R.id.logo);
            vi.setTag(holder);
        } else {
            holder = (ViewHolder) vi.getTag();
        }

        if (condition1) {
            holder.text.setText(myText);
            holder.image.setTag(imageUrl);

            imageLoader.DisplayImage(imgURL, activity, holder.image);
        } else if (condition2) {
            holder.text.setText(myText);
                    holder.image.setTag(imageUrl);
            imageLoader.DisplayImage(imgURL, activity, holder.image);
        } else if (condition3) {
            holder.text.setText(myText);
            holder.image.setTag(imageUrl);

            imageLoader.DisplayImage(imgURL), activity,
                    holder.image);
        }

        return vi;
    }

    public void add(Product product) {

        values.add(product);
    }

}
2
  • You have a whole lot of code here that is pretty hard to read and should probably be refactored, but what's the implementation of LazyAdapter? Commented May 23, 2012 at 3:48
  • i added my adapter code to the question please check Commented May 23, 2012 at 3:56

1 Answer 1

2

java.lang.outofmemmory error occur when dvm have no memory space. This is the issue of memory leaks. A memory leak happens when the application keeps more and more references to objects and never releases them. The garbage collector will therefore never collect those objects and less and less free memory will be available until we reach the point where not enough free memory is available for the application to function normally.

Thrown when a request for memory is made that can not be satisfied using the available platform resources. Such a request may be made by both the running application or by an internal function of the VM. one thing more every time you scroll the list then vm needs memory to show that list so that to free the list object with previous view.

To fix this, first create an XML file in which you create a ListView like this (Xmlfilename is yourlist.xml):

<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:id="@+id/linearlayout_id"
    android:layout_width="fill_parent"
    android:layout_height="fill_parent"
    android:orientation="vertical" 
    android:background="@color/encode_view">

<ListView
    android:id="@+id/info_list_id"
    android:layout_width="fill_parent"
    android:layout_height="wrap_content"
    android:layout_alignParentTop="true"
    android:layout_above="@+id/cancelinfobtn_id" >
</ListView>
</RelativeLayout>

Now create an XML in which your ImageView and TextView is created. (XML file name: yourimagetextlayout.xml):

<?xml version="1.0" encoding="utf-8"?>
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:padding="5dp" 
    android:background="#ffffff">
    <ImageView
        android:id="@+id/logo"
        android:layout_width="50px"
        android:layout_height="50px"
        android:layout_marginLeft="5px"
        android:layout_marginRight="20px"
        android:layout_marginTop="5px"
        android:layout_weight="0.25"
        android:src="@drawable/your image source name" />

    <TextView
        android:id="@+id/label"
        android:layout_width="fill_parent"
        android:layout_height="wrap_content"
        android:layout_centerVertical="true"
        android:layout_toRightOf="@+id/logo"
        android:text="@+id/label"
        android:textSize="16px" 
        android:textColor="@color/contents_text"/>

</RelativeLayout>

Now you have your Activity class where you can find your ListView by its id and create a custom adapter class in which you can fill your list like this:

public class MobileArrayAdapter extends ArrayAdapter<String>
{
    private final Context context;
    private ArrayList<String> contactNamesList;
    View rowView;
    ImageView imageview;

    public MobileArrayAdapter(Context context, ArrayList<String> contactNamesList) {
        super(context, R.layout.yourimagetextlayout, contactNamesList);
        this.context = context;
        this.contactNamesList = new ArrayList<String>();
        this.contactNamesList.addAll(contactNamesList);
    }

    public View getView(int position, View convertView, ViewGroup parent) {
        LayoutInflater inflater = (LayoutInflater) context
                .getSystemService(Context.LAYOUT_INFLATER_SERVICE);
        rowView = inflater.inflate(R.layout.yourimagetextlayout, parent, false);
        TextView textView = (TextView) rowView.findViewById(R.id.label);
        imageview = (ImageView) rowView.findViewById(R.id.logo);
        String findname=contactNamesList.get(position);
        textView.setText(contactNamesList.get(position));
        imageview.setImageBitmap(ur image phto path);
        return rowView;
    }

}

Now in your Activity class find your ListView by its id:

ListView listview = (ListView)findViewById(R.id.info_list_id);

Just instantiate the adapter class like this:

MobileArrayAdapter mobileadapter = new MobileArrayAdapter(this, yourarraylist);

and add this adapter into your ListView:

listview.setAdapter(mobileadapter);
Sign up to request clarification or add additional context in comments.

Comments

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.