Javascript and a href with variables

Question

I have a little doubt about javascript, a new language that I'm studying...

I have a variables that contains a link, like

var Link = "http://www.example.com/search?q=javascriptvariable&k=&e=1";

I'd like to press a button and go to the link, that I've saved in a the variable Link. I've tryed with:

<a href=Link><input type="submit" value="Go" /></a>

What's wrong?

PS

The link I want to edit is not the link of my page (I can't use this.document.location.href). My button should redirect the user to another website and do a custom search.

PPS If you want an example. I have a textbox on my website. If the user write something in my textbox and clicks the Go button the text in my textbox will replace JAVASCRIPTVARIABLE in http://search.aol.com/aol/search?enabled_terms=&s_it=comsearch51&q=JAVASCRIPTVARIABLE and will open the AOL research page.

You cannot use JavaScript variables as values for HTML attributes like this. Why do you think you can? You should read more introductory material. Also, having a button inside a link is very odd. — Felix Kling
– Felix Kling, Commented Jun 15, 2012 at 14:19
@FelixKling keep in mind the OP said they are learning. Be helpful rather than judgmental. — KP.
– KP., Commented Jun 15, 2012 at 14:25
@user1453638 your edit / intended purpose sounds a little suspect? — KP.
– KP., Commented Jun 15, 2012 at 14:26
Why can't you use document.location.href? It allows you to do everything a link can. — trumank
– trumank, Commented Jun 15, 2012 at 14:28

Mike · Accepted Answer · 2012-06-15 14:20:45Z

2

Give the link an ID first,

<a id="someLink"><input type="submit" value="Go" /></a>

Then, in your javascript you will need

var Link = "http://www.example.com/search?q=javascriptvariable&k=&e=1";
document.getElementById('someLink').href = Link;

answered Jun 15, 2012 at 14:20

Mike

7812 gold badges7 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

acme Over a year ago

I think that's the best approach as the html code stays pure html and the coding is done separately.

Philip Kirkbride · Accepted Answer · 2012-06-15 14:24:50Z

1

Make your link

<input type="button" value="Go" onclick="document.location= Link;" />

edited Jun 15, 2012 at 14:24

answered Jun 15, 2012 at 14:19

Philip Kirkbride

23.1k39 gold badges134 silver badges238 bronze badges

2 Comments

Felix Kling Over a year ago

Really? I would suggest to remove the link completely, or the button, one of them.

Mike Over a year ago

buttons are ugly and hard to style - you could always add the link programatically but personally I prefer to do it this way so that I can see what my layout will look like

Felix Kling · Accepted Answer · 2012-06-15 14:25:54Z

1

You need to set it with JavaScript. It is also better to use a button.

HTML:

<button id="go">Go!</button>

JavaScript:

var Link = 'http://jsfiddle.net'

document.getElementById('go').onclick = function () {
    document.location= Link;
};

Working example: http://jsfiddle.net/PfWdW/

edited Jun 15, 2012 at 14:25

Felix Kling

820k181 gold badges1.1k silver badges1.2k bronze badges

answered Jun 15, 2012 at 14:18

trumank

2,7943 gold badges23 silver badges31 bronze badges

1 Comment

Felix Kling Over a year ago

That is true, but I don't think it's a very helpful answer.

KP. · Accepted Answer · 2012-06-15 14:20:29Z

0

<input type="button" value="Go" onclick="location.href=Link;" />

Just noting I wouldn't recommend this type of approach.. but to answer it directly the above works. Why not just use a normal link without script?

answered Jun 15, 2012 at 14:20

KP.

13.8k3 gold badges42 silver badges60 bronze badges

Comments

Bunlong · Accepted Answer · 2012-06-15 15:16:45Z

0

Please try this code:

<input type="button" value="Go" onclick="window.location.href='http://www.example.com/search?q=javascriptvariable&k=&e=1'" />

answered Jun 15, 2012 at 15:16

Bunlong

6621 gold badge9 silver badges22 bronze badges

Collectives™ on Stack Overflow

Javascript and a href with variables

5 Answers 5

1 Comment

2 Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

2 Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related