Ruby on Rails model method 'new' doesn't accept extra parameters

Question

UPDATE

I answered my question below, but I am still asking for a prettier way to achieve my goal. I have a feeling my controller knows too much about how to do things.

I have a create action in my VideoController :

def create
  method = 'get_' + params[:video][:provider] + '_video_id'
  provider_video_id = Video.send(method, params[:video][:url])
  thumb = Video.get_thumb_from_youtube(provider_video_id)

  @video = Video.new(params[:video], :provider_video_id => provider_video_id, :thumb => thumb, :views => 0, :likes => 0)
  if @video.save!
    redirect_to video_path('1'), notice:'Video added successfully.'
  else
    render :new
  end
end

I call Video.new with params[:video] with get its information from a form the user fills in. I then manipulate the URL the user passed in with the form to recover the video_provider_idand thethumb.

However, Rails is not saving the video with provider_video_idand thumb... I get this error on save :

Validation failed: Thumb can't be blank, Thumb is invalid, Provider video can't be blank

My guess is the newmethod doesn't accept extra parameters...

Zach Briggs · Accepted Answer · 2012-06-30 16:17:17Z

1

How about a before save callback in your model? This is an off-the-top-of-my-head default value example, but you could pass params in too.

after_initialize :url


private
def url
  self.provider_video_id ||= "default value"
end

answered Jun 30, 2012 at 16:17

Zach Briggs

638 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Justin D. Over a year ago

Your solution seems good, but I'm not sure I understand it well. I need to call a method to get provider_video_id, so could I write : self.provider_video_id = get_provider_video_id(params[:video][:url]?

Greg Funtusov · Accepted Answer · 2012-06-30 23:42:36Z

1

You may want to use .merge():

Instead of

method = 'get_' + params[:video][:provider] + '_video_id'
params[:video][:provider_video_id] = Video.send(method, params[:video][:url])
params[:video][:thumb] = Video.get_thumb_from_youtube(params[:video][:provider_video_id])
params[:video][:views] = params[:video][:likes] = 0    

@video = Video.new(params[:video])

You can do (modifying code from the original question):

@video = Video.new(params[:video].merge(:provider_video_id => provider_video_id, :thumb => thumb, :views => 0, :likes => 0))

That will merge the params into one hash.

answered Jun 30, 2012 at 23:42

Greg Funtusov

1,44716 silver badges19 bronze badges

Comments

halfer · Accepted Answer · 2018-08-17 00:34:28Z

1

But if you want, you can always override the default new action with something like

class Video 

   def new(attr1, attr2)
     super
     #do something with attr2
   end

end

edited Aug 17, 2018 at 0:34

halfer

20.2k20 gold badges110 silver badges207 bronze badges

answered Jun 30, 2012 at 18:35

sameera207

16.6k20 gold badges92 silver badges156 bronze badges

1 Comment

Justin D. Over a year ago

Nice solution, but it is not exactly what I am looking for. Thanks a lot!

Justin D. · Accepted Answer · 2012-06-30 15:54:46Z

0

I solved the problem. I think Ruby on Rails' newmethod doesn't accept more than one parameter, which usually is params. What I did is I the following :

method = 'get_' + params[:video][:provider] + '_video_id'
params[:video][:provider_video_id] = Video.send(method, params[:video][:url])
params[:video][:thumb] = Video.get_thumb_from_youtube(params[:video][:provider_video_id])
params[:video][:views] = params[:video][:likes] = 0    

@video = Video.new(params[:video])

Now, it seems to work.

answered Jun 30, 2012 at 15:54

Justin D.

4,9867 gold badges39 silver badges70 bronze badges

Collectives™ on Stack Overflow

Ruby on Rails model method 'new' doesn't accept extra parameters

4 Answers 4

1 Comment

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related