SqlDataAdapter does not fill DataSet

Question

I'm using VS2012 and SQL Server Express 2008. I've boiled down my connection/query to try and find out why my DataSet is not being filled. The connection is completed successfully, and no exceptions are thrown, but the adapter does not fill the DataSet. The database that this is pulling from is on the same PC and using localhost\SQLEXPRESS does not change the result. Thanks for any input!

SqlConnection questionConnection = new SqlConnection(ConfigurationManager.ConnectionStrings["DefaultConnection"].ConnectionString);
questionConnection.Open();
String sql = "SELECT * FROM HRA.dbo.Questions";
SqlDataAdapter adapter = new SqlDataAdapter();
DataSet ds = new DataSet();
SqlCommand command = new SqlCommand(sql, questionConnection);
adapter.SelectCommand = command;
adapter.Fill(ds);
adapter.Dispose();
command.Dispose();
questionConnection.Close();

Connection String:

<add name="DefaultConnection" providerName="System.Data.SqlClient" connectionString="Data Source=CODING-PC\SQLEXPRESS;Initial Catalog=HRA;User ID=sa; Password= TEST" />

Check data is there are not........... you will get data in ds.Tables[0] — andy
– andy, Commented Oct 30, 2012 at 12:07

AnandPhadke · Accepted Answer · 2012-10-30 12:09:05Z

7

try this:

SqlConnection questionConnection = new SqlConnection(ConfigurationManager.ConnectionStrings["DefaultConnection"].ConnectionString);
questionConnection.Open();
DataSet ds = new DataSet();
String sql = "SELECT * FROM HRA.dbo.Questions";
SqlDataAdapter adapter = new SqlDataAdapter(sql, questionConnection);
adapter.Fill(ds);

adapter.Dispose();
command.Dispose();
questionConnection.Close();

answered Oct 30, 2012 at 12:09

AnandPhadke

13.5k5 gold badges28 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Tim Schmelter Over a year ago

Can you explain the difference? "Try this" is not really helpful.

GarethD · Accepted Answer · 2012-10-30 12:28:41Z

7

It appears the answer has already been found, however, I am posting one anyway to advocate the use of using blocks, and also letting the .NET framework do the hardwork for you. Your 11 lines of code can be rewritten in 3:

DataSet ds = new DataSet();
using (var adapter = new SqlDataAdapter("SELECT * FROM HRA.dbo.Questions", ConfigurationManager.ConnectionStrings["DefaultConnection"].ConnectionString))
{
    adapter.Fill(ds);
}

answered Oct 30, 2012 at 12:28

GarethD

70k11 gold badges90 silver badges130 bronze badges

Comments

MarioDS · Accepted Answer · 2012-10-30 12:10:18Z

0

Is "HRA.dbo.Questions" an actual table?

Your connectionstring contains an Initial Catalog with value "HRA", and the SQL should only contain dbo.Questions as far as I know.

answered Oct 30, 2012 at 12:10

MarioDS

13.1k15 gold badges70 silver badges123 bronze badges

1 Comment

AnandPhadke Over a year ago

This does not matter here.Connection string property is just to connect to the server and DB.

Robert Peter Bronstein · Accepted Answer · 2021-04-15 06:10:22Z

0

Check that you dont have the fill statement in another part of the code such as in the page load event.

answered Apr 15, 2021 at 6:10

Robert Peter Bronstein

1661 silver badge8 bronze badges

Collectives™ on Stack Overflow

SqlDataAdapter does not fill DataSet

4 Answers 4

1 Comment

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related