Can I extend the iterator function in async.js forEach?

Question

I am using async.js to run a for loop over a collection. For performance reasons, I want to pass in a database connection into the iterator method, so that it's not opening/closing a db connection each time the iterator runs. I am using mongoose.js for my data models.

The code below gets all the Artists in mongo, and then adds a song for each. My question is, how can I use the same db connection from updateAllArtists in addArtistSong?

function updateAllArtists() {
    var db = mongoose.createConnection('localhost/dbname');
    var Artist = db.model('Artist', artistSchema);
    Artist.find({}, function(err, artists) {
       // for each artist, add a song
       async.forEach(artists, addArtistSong, function(err) {
    });
}

function addArtistSong(artist, cb) {
    // THIS IS WHERE I NEED A DB CONNECTION
    var Song = db.model('Song', songSchema);
}

Can I extend the iterator signature somehow, like addArtistSong(artist, db, cb)? Then how would I pass this in from the forEach call?

You should generally be calling createConnection and registering your schema models once, at app startup. The connection that Mongoose creates is actually a pool of connections that can be freely shared across your code. — JohnnyHK
– JohnnyHK, Commented Nov 30, 2012 at 0:47

slebetman · Accepted Answer · 2012-11-30 03:55:41Z

2

One option is to make the db connection a global variable. But if you don't want that you can always use a closure to create a shared variable between functions:

(function(){
  // create db in this closure
  var db = mongoose.createConnection('localhost/dbname');

  function updateAllArtists() {
    // now db is available here
    var Artist = db.model('Artist', artistSchema);
    Artist.find({}, function(err, artists) {
      // for each artist, add a song
      async.forEach(artists, addArtistSong, function(err) {});
    });
  }

  function addArtistSong(artist, cb) {
    // and also available here
    var Song = db.model('Song', songSchema);
  }
})()

Another option is to pass it as a parameter to addArtistSong. Since async.forEach expect the iterator function to accept only 2 parameters we can use an anonymous function wrapper to pass 3 parameters to addArtistSong:

function addArtistSong(db,artist,callback) {
    db.model(); //...
}

and calling it in async.forEach:

async.forEach(
  artists,
  function(x,cb){addArtistSong(db,x,cb)},
  function(err) {}
);

answered Nov 30, 2012 at 3:55

slebetman

115k19 gold badges148 silver badges180 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

emilebaizel Over a year ago

that second option is what i was looking for. i will try it out.

emilebaizel Over a year ago

the anonymous function worked perfectly. never knew how that worked before but it's pretty neat. thanks.

Collectives™ on Stack Overflow

Can I extend the iterator function in async.js forEach?

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related