PHP Variables echoing properly but not entering into the database

Question

I am trying to enter 5 variables into a MySQL database. Here is the code:

    foreach ($avail_t as $row) {
    $ava = explode("+",$row);
    $day = $ava[0];
    $from = $ava[1];
    $to = $ava[2];
    //echo $day." ".$from." ".$to;
    $query = "INSERT INTO availability (username, login_value, day, from, to) VALUES ('{$_SESSION['username']}', '{$_SESSION['login_value']}', '{$day}', '{$from}', '{$to}')";
    mysql_query($query);
}

When I uncomment that echo statement all variables print out just fine, but when I process the query it doesn't enter into the database. Weirdly, if I cut out $from and $to and just enter $day it will enter the day. When I put back the $from and $to nothing gets entered.

Do you see any problems with this code? Data type is integer in military time format 2100, 1300 etc. for $from and $to.

check mysql_error() for any syntax errors, as well as the return value of mysql_query — Frank Farmer
– Frank Farmer, Commented Dec 6, 2012 at 20:12
Try to echo $query;, to make sure it contains what you think it does. — gen_Eric
– gen_Eric, Commented Dec 6, 2012 at 20:14
For future users seeing your questions. If you know this, great! Please, don't use mysql_* functions in new code. They are no longer maintained and the deprecation process has begun on it. See the red box? Learn about prepared statements instead, and use PDO or MySQLi - this article will help you decide which. If you choose PDO, here is a good tutorial. — WhoaItsAFactorial
– WhoaItsAFactorial, Commented Dec 6, 2012 at 20:15

Mr. Alien · Accepted Answer · 2012-12-06 20:13:18Z

7

You are using from and to as a column name which are reserved keywords, escape them using backticks ` in your query

$query = "INSERT INTO availability (username, login_value, day, `from`, `to`) VALUES ('".$_SESSION['username']."', '".$_SESSION['login_value']."', '$day', '$from', '$to')";

answered Dec 6, 2012 at 20:13

Mr. Alien

158k36 gold badges307 silver badges287 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Kermit Over a year ago

Need backticks for to as well

Madara's Ghost Over a year ago

It's considered good practice to blindly surround all table/database names with backticks, be it a reserved word or not.

Kermit Over a year ago

@MadaraUchiha I have never heard that before. I have heard it's better practice to not used reserved words.

Arun Over a year ago

Perfect! I actually just changed the names altogether to prevent any issues later down the line. Thank you!

Mr. Alien Over a year ago

@Arun that's what you should do, be sure you ignore reserved words henceforth

Lotzki · Accepted Answer · 2012-12-06 20:16:52Z

0

You can't use from or to, those are reserved words.

answered Dec 6, 2012 at 20:16

Lotzki

5292 gold badges4 silver badges18 bronze badges

2 Comments

NullPoiиteя Over a year ago

looks like he can just need to surrounded with `

Lotzki Over a year ago

This is frowned upon since it can lead to confusions like this

Collectives™ on Stack Overflow

PHP Variables echoing properly but not entering into the database

2 Answers 2

5 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related