Using foreach statement

Question

I was trying to see if I could use the foreach statement to try and get the program I made to search through an entire array since I don't have a preset size for it and I don't want to play a guessing game for it. I tried this block of code but it tells me, "cannot implicitly convert type 'string' to 'int' and it points to the line 'if (query == search[k])

I'm not sure exactly what it is talking about but can someone please assist? Thank you.

    private void findLast_Click(object sender, EventArgs e)
    {
        query = textBox2.Text;
        search = File.ReadAllText(fileName).Split(new string[] { "\n", "\r\n", ":" }, StringSplitOptions.RemoveEmptyEntries);
        foreach (string k in search)
        {
            if (query == search[k])
            {
                MessageBox.Show("Match");
            }
            else
                MessageBox.Show("No Match");
        }
    }

Pow-Ian · Accepted Answer · 2012-12-06 21:52:28Z

3

in an each loop you have the object already.

private void findLast_Click(object sender, EventArgs e)
    {
        query = textBox2.Text;
        search = File.ReadAllText(fileName).Split(new string[] { "\n", "\r\n", ":" }, StringSplitOptions.RemoveEmptyEntries);
        foreach (string k in search)
        {
            if (query == k)
            {
                MessageBox.Show("Match");
            }
            else
                MessageBox.Show("No Match");
        }
    }

answered Dec 6, 2012 at 21:52

Pow-Ian

3,6351 gold badge25 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Philip Kendall · Accepted Answer · 2012-12-06 21:51:19Z

2

k is a string - therefore you can't use it as the index of an array. Try just query == k instead.

answered Dec 6, 2012 at 21:51

Philip Kendall

4,3241 gold badge25 silver badges44 bronze badges

2 Comments

Skynet Over a year ago

Wow, Worked. Thank you. I would of assumed that if I were to do it this way it would do it but to avoid further silly questions from me, what exactly is foreach and how do I use it? My understanding is that it is so you can go through the entire array or whatever you are looking at so you don't have to guess and input large numbers and such

Philip Kendall Over a year ago

Without wanting to be too harsh here, I think the best thing you could do would be to get a good introductory C# textbook - that should explain what foreach (and ever other keyword) does.

Steve · Accepted Answer · 2012-12-06 21:51:35Z

1

Change your test to

if (query == k)

the syntax that you are using is for simple for loop

for(int k; k < search.Length; k++)
{
   if (query == search[k])
       .....
}

answered Dec 6, 2012 at 21:51

Steve

217k22 gold badges242 silver badges296 bronze badges

Comments

Alexei Levenkov · Accepted Answer · 2012-12-06 21:52:59Z

1

C# is not JavaScript... foreach gives you value of element, not an index:

 foreach (string currentItem in search)
 {
    if (query == currentItem)
    {...

answered Dec 6, 2012 at 21:52

Alexei Levenkov

101k15 gold badges138 silver badges189 bronze badges

Collectives™ on Stack Overflow

Using foreach statement

4 Answers 4

Comments

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related