Replace text by html. Jquery

Question

I'm trying to replace text by html tags. I'm using this code:

  $('p').each(function () {
    $(this).text($(this).text().replace(/(http:\/\/.+?)(\s|$)/g, function(text, link) {
               return '<a href="'+ link +'" target="blank">'+ link +'</a>';
            }).replace(/(www\..+?)(\s|$)/g, function(text, link) {
               return '<a href="http://'+ link +'" target="blank">'+ link +'</a>';
                })
            );  
        });

But the problem is that it's not replacing the text by html, but by another text.

For example:

          www.google.com

becomes (still in text):

          <a href="http://www.google.fr" target="blank">www.google.fr</a>

Any idea on how I could solve that?

You've created an XSS hole.

SLaks
– SLaks

2013-01-16 19:56:29 +00:00
Commented Jan 16, 2013 at 19:56 — SLaks
– SLaks, Commented Jan 16, 2013 at 19:56

SLaks · Accepted Answer · 2013-01-16 19:55:54Z

4

$(this).text(...)

You're setting the text of the element.

To set HTML, call .html().

answered Jan 16, 2013 at 19:55

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Zaheer Ahmed · Accepted Answer · 2013-01-16 20:00:32Z

1

use .html() :

 $('p').each(function () {
    $(this).html($(this).text().replace(/(http:\/\/.+?)(\s|$)/g, function(text, link) {
               return '<a href="'+ link +'" target="blank">'+ link +'</a>';
            }).replace(/(www\..+?)(\s|$)/g, function(text, link) {
               return '<a href="http://'+ link +'" target="blank">'+ link +'</a>';
                })
            );  
        });

Working Demo

answered Jan 16, 2013 at 20:00

Zaheer Ahmed

28.7k12 gold badges77 silver badges113 bronze badges

Collectives™ on Stack Overflow

Replace text by html. Jquery

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related