5

I am trying to write to a file from an html form, however the write part of the javascript doesn't do anything.

Only the validate part of the script seems to be working.

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">

<script LANGUAGE="JavaScript">
function Write(input1, input2)
{
    var fso =  new ActiveXObject("Scripting.FileSystemObject");  
    var s = fso.OpenTextFile("C:\\test.txt", true);
    s.WriteLine(input1 + "," + input2);
    s.Close();
}

function validateForm() {
    var x1=document.userform.pwd.value;
    var x2=document.userform.re_pwd.value;
    if (x2 == x1){
        Write(document.userform.user.value, document.userform.pwd.value);
    }
    else{alert("Passwords are not the same, Re-enter password");}
}
</SCRIPT>

<head>

    <link rel="stylesheet" href="css/screen.css" media="screen" />
</head>
<body>

<div id="container">

        <h2>Create a new account <?php echo "It works!"; ?></h2>
        <form id="form1" NAME="userform" METHOD="GET" ONSUBMIT="return validateForm()" ACTION="">   

            <fieldset><legend>Create a new Account</legend>
                <p class="first">
                    <label for="username">Username</label>
                    <input type="text" name="user" size="30" />
                </p>
                <p>
                    <label for="password">Password</label>
                    <input type="password" name="pwd" size="30" />
                </p>
                <p>
                    <label for="repassword">Re-enter Password</label>
                    <input type="password" name="re_pwd" size="30" />
                </p>

            </fieldset>             

            <p class="submit"><button type="submit" value="Submit">Signup</button></p>          

        </form> 

</div>
</body>
</html>
8
  • Why are you storing plaintext credentials as a file on a user's computer using non-universal outdated technology? We have hashing and cookies, you know. Commented Feb 10, 2013 at 6:37
  • 2
    Are you using Internet Explorer? Not every browser supports ActiveX natively as far as I know. Commented Feb 10, 2013 at 6:39
  • Good luck saving text file with browsers other than IE. Commented Feb 10, 2013 at 6:40
  • 1
    Only way that wil work is if you save the HTML file with extension .HTA Commented Feb 10, 2013 at 6:49
  • 1
    What is your end goal with this? If you're trying to make a web application that users can sign up for and log into, Javascript isn't going to cut it. Commented Feb 10, 2013 at 6:51

1 Answer 1

9

I pulled out my general .HTA read/write routines and dropped them in here for you.

  • Removed the XHTML stuff and switched to the HTML 5 doctype
  • Cleaned up markup to be HTML5 compliant.
  • Fixed the ID's in your INPUTS. The label element matches by ID, not name.
  • Added a return false to your form.

General notes:

  • Only constructors should start with a capital letter.
  • This must be saved with a .HTA file name
  • Needless to say, this is windows only.

<!doctype html>
<html>

<script>

var ie_writeFile = function (fname, data) {
    var fso, fileHandle;
    fso = new ActiveXObject("Scripting.FileSystemObject");
    fileHandle = fso.CreateTextFile(fname, true);
    fileHandle.write(data);
    fileHandle.close();
  };

var ie_readFile = function (fname) {
    try {
      fso = new ActiveXObject("Scripting.FileSystemObject");
      var fso, filehandle, contents;
      filehandle = fso.OpenTextFile(fname, 1);
      contents = filehandle.ReadAll();
      filehandle.Close();
      return contents;
    } catch (err) {
      return null;
    }
  };



function Write(input1, input2)
{
    var s = input1 + "," + input2;
    ie_writeFile("test.txt", s);
}

function validateForm() {
    var x1=document.userform.pwd.value;
    var x2=document.userform.re_pwd.value;
    if (x2 == x1){
        Write(document.userform.user.value, document.userform.pwd.value);
    }
    else{alert("Passwords are not the same, Re-enter password");}
}
</script>

<head>

    <link rel="stylesheet" href="css/screen.css" media="screen">
</head>
<body>

<div id="container">

        <h2>Create a new account <?php echo "It works!"; ?></h2>


        <!-- return false added to keep the form from reloading -->

        <form id="form1" NAME="userform" METHOD="GET" ONSUBMIT="return validateForm();return false" ACTION="">   

            <fieldset><legend>Create a new Account</legend>
                <p class="first">
                    <label for="username">Username</label>
                    <input type="text" name="user" id="user" size="30">
                </p>
                <p>
                    <label for="pwd">Password</label>
                    <input type="password" name="pwd" id="pwd" size="30" />
                </p>
                <p>
                    <label for="repassword">Re-enter Password</label>
                    <input type="password" name="repassword" id="repassword" size="30" />
                </p>

            </fieldset>             

            <p class="submit"><button type="submit" value="Submit">Signup</button></p>          

        </form> 

</div>
</body>
</html>
Sign up to request clarification or add additional context in comments.

1 Comment

No problem. Took me a while to get the syntax of everything right myself. All of the examples I found where in vbscript.

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.