Javascript boolean if statement not working

Question

I'm trying to animate a panel to come in and out from the top of the page. Unfortunately my if statement is not working. Here's my code:

var panelShown = false;
$(document).ready(function(){
    $('#nav_arrow').click(function(){
        panelShown = true;
        $('#nav_panel').animate({top: '0px'}, 1000, function(){});
        $('#nav_bar');
    });
    if(panelShown == true){//originally written as if(panelShown){
        $(document).click(function(){
            panelShown = false;
            $('#nav_panel').animate({top: '-200px'}, 1000, function(){});
        });
    }
});

The first part works fine, the panel animates down. But I can never get into the if statement. Any help would be greatly appreciated.

Damn, I'm an idiot. The if statement needs to be inside the click listener. :/ — gaynorvader
– gaynorvader, Commented Feb 28, 2013 at 11:20
Stepping through your code (i.e. debugging) would have made this immediately apparent. — Grant Thomas
– Grant Thomas, Commented Feb 28, 2013 at 11:21
It looks like StackOverflow is now a hi-tech version of Rubber Duck debugger ;-) — strah
– strah, Commented Feb 28, 2013 at 11:29
I'm using a notepad, I don't have much debugging. I tried using console.log, but I just missed that it was only running once. — gaynorvader
– gaynorvader, Commented Feb 28, 2013 at 11:31

CD.. · Accepted Answer · 2013-02-28 11:19:45Z

1

It really whould never be called because on ready it will be false.

Try this:

var panelShown = false;
$(document).ready(function(){
    $('#nav_arrow').click(function(){  
        $('#nav_panel').animate({top: (panelShown ?'-200px' : '0px')}, 1000, function(){});
        panelShown = !panelShown;
    });
});

answered Feb 28, 2013 at 11:19

CD..

74.4k25 gold badges160 silver badges170 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

gaynorvader Over a year ago

Yeah, just realised that there, thanks :) 9 minutes until I can accept your answer.

Collectives™ on Stack Overflow

Javascript boolean if statement not working

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related