why this mysql insert is failing in java JDBC

Question

try
         {
            String sql="INSERT INTO `task`(`task`,`time`) VALUES(?,?)";
            PreparedStatement stmt=this.connection.prepareStatement(sql);
            stmt.setString(1, this.task);
            stmt.setInt(2, this.time);
            //stmt.
            Boolean res= stmt.execute(sql);
         }
         catch(Exception e)
         {
             System.err.println(e);
         }

ERROR:

com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '?,?)' at line 1

jlordo · Accepted Answer · 2013-03-15 07:43:41Z

2

Don't use

stmt.execute(sql);

use

stmt.execute();

to execute your PreparedStatement.

The first one you are using tries to execute the given string, which is obviously not what you want to execute due to the placeholder '?' values in it (it is a method of the java.sql.Statement interface).

The second one is a method from java.sql.PreparedStatement and executes the PreparedStatement with the values you entered through the setXXX() methods.

Also, in your case you don't need ticks in your string, you can just write

String sql="INSERT INTO task(task,time) VALUES(?,?)";

edited Mar 15, 2013 at 7:43

answered Mar 15, 2013 at 7:32

jlordo

37.9k7 gold badges63 silver badges84 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Jevgeni Smirnov Over a year ago

MySql expects for String 'value' not value, so try to put ? into quotes.

jlordo Over a year ago

@JevgeniSmirnov: No, don't need it, PreparedStatement takes care of that for you.

Mark Rotteveel Over a year ago

@jlordo With JDBC you could also need backticks, but only where it is actually required (just like with all other MySQL uses, see dev.mysql.com/doc/refman/5.5/en/identifiers.html).

Jevgeni Smirnov Over a year ago

@jlordo, oh ok. Will put a note to myself.

theyuv Over a year ago

@MarkRotteveel should we always use backticks then in the query String, or only if it is a reserved word (eg: event)?

|

Collectives™ on Stack Overflow

why this mysql insert is failing in java JDBC

1 Answer 1

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related