Strange behavior when iterating over HTMLCollection from getElementsByClassName

Question

I wrote a function to change the class of elements to change their properties. For some reason, only some of the elements have changed. It took me a few hours to find a solution, but it seems odd to me. Perhaps you can explain this to me.

This isn’t working:

function replace(){
  var elements = document.getElementsByClassName('classOne');

  for (var i = 0; i < elements.length; i++) {
    elements[i].className = 'classTwo';               
  }
}

See the JSFiddle: only every second item is affected; only every second red element changes color to blue.

So I changed the final expression of the for loop to not increment i anymore:

function replace(){
  var elements = document.getElementsByClassName('classOne');

  for (var i = 0; i < elements.length; i) { // Here’s the difference
    elements[i].className = 'classTwo';               
  }
}

This works well! It seems as though push is called and no increment is needed. Is this normal? It is different from the examples I’ve seen.

I have never heard the term “loop coefficient”. JavaScript calls the last part of a for loop the “final expression” (or “increment” in certain contexts of the spec) and i++ an “increment” (or, generalized, “UpdateExpression” in the spec). — Sebastian Simon
– Sebastian Simon, Commented Aug 17, 2019 at 8:35

Community · Accepted Answer · 2017-05-23 11:53:25Z

21

What's going on is an odd side effect. When you reassign className for each element of elements, the element gets removed from the array! (Actually, as @ user2428118 points out, elements is an array-like object, not an array. See this thread for the difference.) This is because it no longer has the classOne class name. When your loop exits (in the second case), the elements array will be empty.

You could write your loop as:

while (elements.length) {
    elements[0].className = 'classTwo'; // removes elements[0] from elements!
}

In your first case, by incrementing i, you are skipping half of the (original) elements that have class classOne.

Excellent question, by the way. Well-researched and clear.

edited May 23, 2017 at 11:53

CommunityBot

11 silver badge

answered Mar 22, 2013 at 4:03

Ted Hopp

235k48 gold badges412 silver badges533 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

MeNa Over a year ago

Thank you! sounds right.. but... it is sense programming? "elements" is an exist object, not dynamically object that can change without you?

Ted Hopp Over a year ago

@MeNa - While the elements variable is local to your function, the array that it references is also accessible to (and maintained by) the DOM. The className property of each element actually triggers a setter function within the DOM machinery. One of the side effects of that function is to remove the element from the array that elements references. So it doesn't change "without you"; it changes because you changed the className attribute of one of its elements. To quote the sages of old: "That's not a bug; that's a feature!"

MeNa Over a year ago

@TedHopp - Thank you again! now all is clearly. (PS, thanks about the 'while()', it's a nicely and elegant solution.)

user2428118 Over a year ago

You should probably mention that elements isn't actually an array, but merely an array-like datastructure

NoodleFolk · Accepted Answer · 2013-03-22 06:21:25Z

4

getElementsByClassName returns a NodeList. A NodeList collection is a live collection, which means that the modification of the document affects the collection. more

answered Mar 22, 2013 at 6:21

NoodleFolk

2,0692 gold badges17 silver badges24 bronze badges

3 Comments

MeNa Over a year ago

Tnx. Indeed the 'live collection' term explains the point well.

SHH Over a year ago

NOT all NodeList collection is live. Some "fetch" methods such as querySelectorAll(), returns STATIC NodeList which are not affected by subsequent DOM changes.

pilchard Over a year ago

It returns an live HTMLCollection

Gerry · Accepted Answer · 2014-12-01 14:53:57Z

-3

Or revert the loop, beginning by length-1 and step down to 0

answered Dec 1, 2014 at 14:53

Gerry

1

1 Comment

Bergi Over a year ago

Yes, that would work as well, but the question begs for an explanation rather than a solution.

Collectives™ on Stack Overflow

Strange behavior when iterating over HTMLCollection from getElementsByClassName

3 Answers 3

4 Comments

3 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related