java.lang.IllegalStateException: Activity has been destroyed

Question

Working with Robolectric , I'm very new to android. I made a first test class using Activity. It worked nicely. Now I want make a test for fragment.

@RunWith(RobolectricTestRunner.class)
public class LoginFragmentTest {
    private LoginFragment fragment;

    @Before
    public void setup() {
        fragment = new LoginFragment();
        startFragment(fragment);
        assertThat(fragment, notNullValue());
        assertThat(fragment.getActivity(), notNullValue());
    }

    private void startFragment(LoginFragment fragment) {
        FragmentManager fragmentManager = new FragmentActivity().getSupportFragmentManager();
        FragmentTransaction fragmentTransaction = fragmentManager.beginTransaction();
        fragmentTransaction.add(fragment, null);
        fragmentTransaction.commit();
    }

    @Test
    public void login() {
        EditText idEditText = (EditText)fragment.getActivity().findViewById(R.id.main_id);
        assertThat(idEditText, notNullValue());
    }
}

This is my first test class for Fragment class. It throws

"java.lang.IllegalStateException: Activity has been destroyed" in startFragment#fragmentTransaction.commit().

Anyone knows how to fix this ?

You can find whole source from https://github.com/msbaek/frame-test

Thanks in advance !!

hum, don't destroy your activity before commiting a fragment transaction ? — njzk2
– njzk2, Commented Mar 22, 2013 at 10:31

Felipe Conde · Accepted Answer · 2013-06-24 17:47:50Z

4

In my case, specifically, my problem was when creating the activity. I was using

 activity = Robolectric.buildActivity(MyActivity.class).get();

And it should be

 activity = Robolectric.buildActivity(MyActivity.class).create().get();

Hope it helps someone :D

answered Jun 24, 2013 at 17:47

Felipe Conde

2,05423 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Myeonseok Baek · Accepted Answer · 2013-04-02 07:33:25Z

@RunWith(RobolectricTestRunner.class)
public class LoginFragmentTest {
    private LoginFragment fragment;

    @Before
    public void setup() {
        fragment = new LoginFragment();
        startFragment();
        assertThat(fragment, notNullValue());
        assertThat(fragment.getActivity(), notNullValue());
    }

    private void startFragment() {
        FragmentActivity activity = new FragmentActivity();
        shadowOf(activity).callOnCreate(null);
        shadowOf(activity).callOnStart();
        shadowOf(activity).callOnResume();

        FragmentManager fragmentManager = activity.getSupportFragmentManager();
        FragmentTransaction fragmentTransaction = fragmentManager.beginTransaction();
        fragmentTransaction.add(fragment, null);
        fragmentTransaction.commit();
    }

    @Test
    public void login() {
        EditText idEditText = (EditText) fragment.getView().findViewById(R.id.main_id);
        assertThat(idEditText, notNullValue());
    }
}

This is working version. Following 3 lines are important(it's from robolectric source - DialogFragmentTest).

        shadowOf(activity).callOnCreate(null);
        shadowOf(activity).callOnStart();
        shadowOf(activity).callOnResume();

azertiti · Accepted Answer · 2013-03-22 10:52:12Z

1

The fragments are supposed to be displayed from an Activity. The flow should be:

allocate a new fragment object in a FragmentActivity class
get the fragment manager to add the newly allocated fragment

In your case you do not have a connection to a real activity. You allocate a FragmentActivity with new FragmentActivity() and try to get the support manager. While this compiles there is no "real" activity able to manage your fragment. Fragments can be added on activities already displayed and here it's not the case.

I recommend reading this page as it explains these things very well: http://developer.android.com/guide/components/fragments.html

answered Mar 22, 2013 at 10:52

azertiti

3,1501 gold badge19 silver badges19 bronze badges

3 Comments

Myeonseok Baek Over a year ago

Thanks !! I succeeded in connect activity to fragment.

MaciejGórski Over a year ago

What does "real" activity mean in context of Robolectric?

muneikh Over a year ago

@백명석 What did you do to connect the fragment to the activity? I am experiencing the similar problem.

Malachiasz · Accepted Answer · 2013-08-09 16:19:37Z

1

That happened for me when I used fragmentTransaction.commitAllowingStateLoss(); from sub Fragment whose parent fragment had setRetainInstance(true); I had activity as property what lead to leaking activity on rotation.

answered Aug 9, 2013 at 16:19

Malachiasz

7,2462 gold badges37 silver badges50 bronze badges

Collectives™ on Stack Overflow

java.lang.IllegalStateException: Activity has been destroyed

4 Answers 4

Comments

Comments

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related