Appending string to URL

Question

I'm trying to modify the DIV tag content on server side.

string url = "www.mypage.com";
string html = "<a href='http://www.facebook.com/sharer.php?u='"+url+" title='Submit to Facebook' target='blank'><img src='http://itprism.com/plugins/content/itpsocialbuttons/images/big/facebook.png' alt='Submit to Facebook'></a>" +
"<a href='http://twitter.com/share?text=Atlas Paving &url='" + url + " title='Submit to Twitter' target='blank'><img src='http://itprism.com/plugins/content/itpsocialbuttons/images/big/twitter.png' alt='Submit to Twitter'></a>";

divSocial.InnerHtml = html;

When i try to navigate to the appended URL i can see that the URL is not generated correctly. appended url is empty. Whats wrong here

enter image description here

Petar Ivanov · Accepted Answer · 2013-03-29 04:39:19Z

6

Your closing ' is not correct. It should be closed after the url:

string html = "<a href='http://www.facebook.com/sharer.php?u=" + url + "' title= ...

A good practice to avoid such hard to find errors and to have easier to read code is to use string.Format:

string html = string.Format("<a href='http://www.facebook.com/sharer.php?u={0}' title= ...", url);

answered Mar 29, 2013 at 4:39

Petar Ivanov

93.4k11 gold badges84 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mr_Green · Accepted Answer · 2013-03-29 04:41:34Z

1

Can you try:

string html = "<a href='http://www.facebook.com/sharer.php?u="+url+"' title='Submit to Facebook' target='blank'>

instead of:

<a href='http://www.facebook.com/sharer.php?u='"+url+" title='Submit to Facebook' target='blank'>

I think you closed your href attribute a bit too early.

edited Mar 29, 2013 at 4:41

Mr_Green

42k48 gold badges171 silver badges277 bronze badges

answered Mar 29, 2013 at 4:40

Belle Lam

837 bronze badges

Collectives™ on Stack Overflow

Appending string to URL

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related