PHP Session in Class

Question

<?
session_start();
class DB_MSSQL {
  protected $Host;
  protected $Database;
  protected $User;
  protected $Password;
  protected $Link_ID  = 0;
  protected $Query_ID = 0;
  protected $Record   = array();
  protected $Row      = 0;
  protected $Errno    = 0;
  protected $Error    = "";
  protected $Halt_On_Error = "yes";
  protected $Auto_Free = 1;     
  protected $PConnect  = 0;
    function _construct(){
   $this->Host = $_SESSION['SQLIP'];
     $this->Database = $_SESSION['SQLDB'];
     $this->User = $_SESSION['SQLUSER'];
     $this->Password = $_SESSION['SQLPASS'];
  }

  function DB_MSSQL($query = "") {
    if($query) {
      $this->query($query);
    }
  }
  function connect() {
    if ( 0 == $this->Link_ID ) {
      if(!$this->PConnect) {
        $this->Link_ID = mssql_connect($this->Host, $this->User, $this->Password);
      } else {
        $this->Link_ID = mssql_pconnect($this->Host, $this->User, $this->Password);
      }
      if (!$this->Link_ID)
        $this->connect_failed("connect ($this->Host, $this->User, \$Password) failed");
      else
        if (!mssql_select_db($this->Database, $this->Link_ID)) {
          $this->connect_failed("cannot use database ".$this->Database);
        }
    }
  }
  function connect_failed($message) {
    $this->Halt_On_Error = "yes";
    $this->halt($message);
  }

  function free_result(){
      mssql_free_result($this->Query_ID);
    $this->Query_ID = 0;
  }

  function query($Query_String) 
  {

    /* No empty queries, please, since PHP4 chokes on them. */
    if ($Query_String == "")
      /* The empty query string is passed on from the constructor,
       * when calling the class without a query, e.g. in situations
       * like these: '$db = new DB_Sql_Subclass;'
       */
      return 0;

    if (!$this->Link_ID)
        $this->connect();
//    printf("<br>Debug: query = %s<br>\n", $Query_String);

    $this->Query_ID = mssql_query($Query_String, $this->Link_ID);
    $this->Row = 0;
    if (!$this->Query_ID) {
      $this->Errno = 1;
      $this->Error = "General Error (The MSSQL interface cannot return detailed error messages).";
      $this->halt("Invalid SQL: ");
    }
    return $this->Query_ID;
  }

  function next_record() {

    if ($this->Record = mssql_fetch_row($this->Query_ID)) {
      // add to Record[<key>]
      $count = mssql_num_fields($this->Query_ID);
      for ($i=0; $i<$count; $i++){
        $fieldinfo = mssql_fetch_field($this->Query_ID,$i);
        $this->Record[strtolower($fieldinfo->name)] = $this->Record[$i];
      }
      $this->Row += 1;
      $stat = 1;
    } else {
      if ($this->Auto_Free) {
            $this->free_result();
        }
      $stat = 0;
    }
    return $stat;
  }

  function seek($pos) {
        mssql_data_seek($this->Query_ID,$pos);
    $this->Row = $pos;
  }

  function metadata($table) {
    $count = 0;
    $id    = 0;
    $res   = array();

    $this->connect();
    $id = mssql_query("select * from $table", $this->Link_ID);
    if (!$id) {
      $this->Errno = 1;
      $this->Error = "General Error (The MSSQL interface cannot return detailed error messages).";
      $this->halt("Metadata query failed.");
    }
    $count = mssql_num_fields($id);

    for ($i=0; $i<$count; $i++) {
        $info = mssql_fetch_field($id, $i);
      $res[$i]["table"] = $table;
      $res[$i]["name"]  = $info->name;
      $res[$i]["len"]   = $info->max_length;
      $res[$i]["flags"] = $info->numeric;
    }
    $this->free_result();
    return $res;
  }

  function affected_rows() {
// Not a supported function in PHP3/4.  Chris Johnson, 16May2001.
//    return mssql_affected_rows($this->Query_ID);
    $rsRows = mssql_query("Select @@rowcount as rows", $this->Link_ID);
    if ($rsRows) {       
       return mssql_result($rsRows, 0, "rows");
    }
  }

  function num_rows() {
    return mssql_num_rows($this->Query_ID);
  }

  function num_fields() {
    return mssql_num_fields($this->Query_ID);
  }

  function nf() {
    return $this->num_rows();
  }

  function np() {
    print $this->num_rows();
  }

  function f($Field_Name) {
    return $this->Record[strtolower($Field_Name)];
  }

  function p($Field_Name) {
    print $this->f($Field_Name);
  }

  function halt($msg) {
    if ("no" == $this->Halt_On_Error)
      return;

    $this->haltmsg($msg);

    if ("report" != $this->Halt_On_Error)
      die("Session halted.");
  }

  function haltmsg($msg) {
    printf("<p>Server have a critical error!<br><br><br>We are very sorry for any inconvenience!<br><br>\n", $msg);
    printf("<b>MSSQL Error</b>: %s (%s)</p>\n",
      $this->Errno,
      $this->Error);
  }
}
?>

Faild to connect.. if i put $Host;$Database;$User;$Password; manually is work fine. but with constructor can't connect. ($_SESSION have correct value)

But i don't know how to echo $obj->Host,Password,user,etc.

And what happens if this variable ($_SESSION['SQLIP']) changes? Trust in global state is bad. — Peter Kiss
– Peter Kiss, Commented May 6, 2013 at 12:16
Still the same issue. The other thing is that when you are storing the database credentials in your session state then the PHP by default will write it on the system hard drive the full session data including your credetnials which is a vulnerability. Make a constructior which accepts 4 parameters and inject them into it a different way (not from session). — Peter Kiss
– Peter Kiss, Commented May 6, 2013 at 15:39

Rikesh · Accepted Answer · 2013-05-06 12:12:57Z

5

You can assigning session value like below in class constructor,

class Foo {
    public $Host;
    public function __construct() {
        $this->Host = $_SESSION['SQLIP'];
    }
}

Prefer use public keyword instead of var for declaring a variable.

Note: The PHP 4 method of declaring a variable with the var keyword is still supported for compatibility reasons (as a synonym for the public keyword). In PHP 5 before 5.1.3, its usage would generate an E_STRICT warning.

http://www.php.net/manual/en/language.oop5.visibility.php

edited May 6, 2013 at 12:12

answered May 6, 2013 at 12:10

Rikesh

26.5k14 gold badges82 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sid · Accepted Answer · 2013-05-06 12:44:54Z

1

You cannot assign value to class variable directly. Assign value to variable inside class constructor.

class DB_MSSQL {
    public $Host;

    function __construct(){
        $this->Host = $_SESSION['SQLIP'];
    }
}

find my below edited ans for your problem

class DB_MSSQL {
  public $Host;
  public $Database;
  public $User;
  public $Password;

  public $Link_ID;
  public $PConnect;

    function _construct(){
        $this->Host = $_SESSION['SQLIP'];
        $this->Database = $_SESSION['SQLDB'];
        $this->User = $_SESSION['SQLUSER'];
        $this->Password = $_SESSION['SQLPASS'];
    }


  function connect() {
    if ( 0 == $this->Link_ID ) {
      if(!$this->PConnect) {
        $this->Link_ID = mssql_connect($this->Host, $this->User, $this->Password);
      } else {
        $this->Link_ID = mssql_pconnect($this->Host, $this->User, $this->Password);
      }
      if (!$this->Link_ID)
        $this->connect_failed("connect ($this->Host, $this->User, \$Password) failed");
      else
        if (!mssql_select_db($this->Database, $this->Link_ID)) {
          $this->connect_failed("cannot use database ".$this->Database);
        }
    }
  }

But its better to use protected instead of public for db variables

edited May 6, 2013 at 12:44

answered May 6, 2013 at 12:07

Sid

5607 silver badges17 bronze badges

8 Comments

Mihai Oprea Over a year ago

can you give me a example please?

Peter Over a year ago

'var' is an outdated way of declaring variables (php 4)

Mihai Oprea Over a year ago

How i can echo $this->Host = $_SESSION['SQLIP']; to view if have the correct value?

Sid Over a year ago

You can put echo inside constructor or echo object variable $obj->Host .

Sid Over a year ago

below code shows the object of your class. Give a try $obj = new DB_MSSQL(); echo $obj->Host; echo $obj->User ; echo $obj->Password ; $obj->connect();

|

Collectives™ on Stack Overflow

PHP Session in Class

2 Answers 2

Comments

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related