php class variables

Question

I have a class named MyCart.

Class MyCartClass
{
var $MyCart;  

function getCart(){
  return $this->MyCart;
}

function addItem($item){

    if ($this->MyCart){
        $this->MyCart .= ','.$item;
    } 
    else{
        $this->MyCart = $item;
    }

}

};

$globalCart = new MyCartClass; // create an instance of the class

The variable "$MyCart" is a string containing all the items in the cart, separated with a comma.

Now, I save this class to a file named "cart.php" and I include it in another file.

HOWEVER, every time I call the function "addItem", the if statement goes to the else branch, which means that the "$MyCart" variable does not contain the current state of the cart.

Do i need to store the state of my cart into a "session" variable? Cause this way it will be accessible from all files for sure..

I would appreciate any kind of help!

Thanks.

I can't see anything wrong with that code, provided you are calling it within the same program run (HTTP call, or whatever). Nothing will persist between HTTP calls unless you use a session. — Colin Fine
– Colin Fine, Commented Jun 7, 2011 at 13:02

Daniel Quinn · Accepted Answer · 2011-06-07 13:01:32Z

5

Don't use a string to store a list. It's just a bad idea all around.

Instead, store $items as an array, and define it in the constructor

class Cart {

    function __construct() {
        $this->items = array();
    }

    function add($item) {
        $this->items[] = $item;
    }

    function save() {
        $SESSION["cart"] = $this->items;
    }

    function get_items_string() {
        return join(",", $this->items);
    }

}

My PHP is a little rusty, but that should get you started.

answered Jun 7, 2011 at 13:01

Daniel Quinn

6,4786 gold badges44 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

dynamic Over a year ago

the question wasnt' about how to properly store it.

yorgos Over a year ago

Thank you. So, by storing the result of the "add new item" function into this array is not enough to hold this result in the entire site, right? I definitely need a session. Is that correct. Thank all of you guys for the immediate response!

Daniel Quinn Over a year ago

Yup, definitely use a session, and yes, I know the question wasn't about how to store it, but I thought the OP had the false impression that sessions can only store strings, which isn't true.

dynamic · Accepted Answer · 2011-06-07 12:59:41Z

2

If you mean saving it between request then yes you need to put it in $_SESSION.

Otherwise within one request you can use your $globalCart and not lose the contents of your $myCart var.

answered Jun 7, 2011 at 12:59

dynamic

48.2k56 gold badges163 silver badges236 bronze badges

1 Comment

yorgos Over a year ago

Thank you "yes123". It seems that there is no other way than storing it into $_SESSION I guess.

Scott Keck-Warren · Accepted Answer · 2011-06-07 13:01:55Z

1

To simplify this just store the data in an array and use serialize and deserialize to store the data:

Class MyCartClass { 
    var $MyCart = array();

    public function __construct(){
        $this->MyCart = deserialize($_SESSION['CART']);
    }

    public function __destruct(){
        $_SESSION['CART'] = serialize($this->MyCart);
    }


    function getCart(){
        return $this->MyCart;
    }

    function addItem($item){
        $this->MyCart[] = $item;   
    }
}

Please note I just wrote this quickly and didn't run it as I don't have access to run it right now. :-)

answered Jun 7, 2011 at 13:01

Scott Keck-Warren

1,9723 gold badges19 silver badges33 bronze badges

1 Comment

Daniel Quinn Over a year ago

I'm pretty sure that you don't need to serialise session data.

publikz.com · Accepted Answer · 2011-06-07 13:02:29Z

0

your can even serialise all class to $_SESSION[] ... but generally good idea is to store in session some id - as example user id & store all all other data in mysql. Getting it each time, is needed ...

answered Jun 7, 2011 at 13:02

publikz.com

9611 gold badge12 silver badges22 bronze badges

Collectives™ on Stack Overflow

php class variables

4 Answers 4

3 Comments

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related