264

Trying to create a macro which can be used for print debug messages when DEBUG is defined, like the following pseudo code:

#define DEBUG 1
#define debug_print(args ...) if (DEBUG) fprintf(stderr, args)

How is this accomplished with a macro?

2
  • 1
    Will the compiler (gcc) optimize statements like if(DEBUG) {...} out, if in production code the DEBUG macro is set to 0 ? I understand that there are good reasons to leave the debug statements visible to the compiler, but a bad feeling remains. -Pat Commented Feb 2, 2010 at 10:48
  • 1
    Also see Error when defining a stringising macro with __VA_ARGS__ Commented Feb 25, 2019 at 5:40

15 Answers 15

509

If you use a C99 or later compiler

#define debug_print(fmt, ...) \
            do { if (DEBUG) fprintf(stderr, fmt, __VA_ARGS__); } while (0)

It assumes you are using C99 (the variable argument list notation is not supported in earlier versions). The do { ... } while (0) idiom ensures that the code acts like a statement (function call). The unconditional use of the code ensures that the compiler always checks that your debug code is valid — but the optimizer will remove the code when DEBUG is 0.

If you want to work with #ifdef DEBUG, then change the test condition:

#ifdef DEBUG
#define DEBUG_TEST 1
#else
#define DEBUG_TEST 0
#endif

And then use DEBUG_TEST where I used DEBUG.

If you insist on a string literal for the format string (probably a good idea anyway), you can also introduce things like __FILE__, __LINE__ and __func__ into the output, which can improve the diagnostics:

#define debug_print(fmt, ...) \
        do { if (DEBUG) fprintf(stderr, "%s:%d:%s(): " fmt, __FILE__, \
                                __LINE__, __func__, __VA_ARGS__); } while (0)

This relies on string concatenation to create a bigger format string than the programmer writes.

If you use a C89 compiler

If you are stuck with C89 and no useful compiler extension, then there isn't a particularly clean way to handle it. The technique I used to use was:

#define TRACE(x) do { if (DEBUG) dbg_printf x; } while (0)

And then, in the code, write:

TRACE(("message %d\n", var));

The double-parentheses are crucial — and are why you have the funny notation in the macro expansion. As before, the compiler always checks the code for syntactic validity (which is good) but the optimizer only invokes the printing function if the DEBUG macro evaluates to non-zero.

This does require a support function — dbg_printf() in the example — to handle things like stderr. It requires you to know how to write varargs functions, but that isn't hard:

#include <stdarg.h>
#include <stdio.h>

void dbg_printf(const char *fmt, ...)
{
    va_list args;
    va_start(args, fmt);
    vfprintf(stderr, fmt, args);
    va_end(args);
}

You can also use this technique in C99, of course, but the __VA_ARGS__ technique is neater because it uses regular function notation, not the double-parentheses hack.

Why is it crucial that the compiler always see the debug code?

[Rehashing comments made to another answer.]

One central idea behind both the C99 and C89 implementations above is that the compiler proper always sees the debugging printf-like statements. This is important for long-term code — code that will last a decade or two.

Suppose a piece of code has been mostly dormant (stable) for a number of years, but now needs to be changed. You re-enable debugging trace - but it is frustrating to have to debug the debugging (tracing) code because it refers to variables that have been renamed or retyped, during the years of stable maintenance. If the compiler (post pre-processor) always sees the print statement, it ensures that any surrounding changes have not invalidated the diagnostics. If the compiler does not see the print statement, it cannot protect you against your own carelessness (or the carelessness of your colleagues or collaborators). See 'The Practice of Programming' by Kernighan and Pike, especially Chapter 8 (see also Wikipedia on TPOP).

This is a 'been there, done that' experience — I used essentially the technique described in other answers where the non-debug build does not see the printf-like statements for a number of years (more than a decade). But I came across the advice in TPOP (see my previous comment), and then did enable some debugging code after a number of years, and ran into problems of changed context breaking the debugging. Several times, having the printing always validated has saved me from later problems.

I use NDEBUG to control assertions only, and a separate macro (usually DEBUG) to control whether debug tracing is built into the program. Even when the debug tracing is built in, I frequently do not want debug output to appear unconditionally, so I have mechanism to control whether the output appears (debug levels, and instead of calling fprintf() directly, I call a debug print function that only conditionally prints so the same build of the code can print or not print based on program options). I also have a 'multiple-subsystem' version of the code for bigger programs, so that I can have different sections of the program producing different amounts of trace - under runtime control.

I am advocating that for all builds, the compiler should see the diagnostic statements; however, the compiler won't generate any code for the debugging trace statements unless debug is enabled. Basically, it means that all of your code is checked by the compiler every time you compile - whether for release or debugging. This is a good thing!

debug.h - version 1.2 (1990-05-01)

/*
@(#)File:            $RCSfile: debug.h,v $
@(#)Version:         $Revision: 1.2 $
@(#)Last changed:    $Date: 1990/05/01 12:55:39 $
@(#)Purpose:         Definitions for the debugging system
@(#)Author:          J Leffler
*/

#ifndef DEBUG_H
#define DEBUG_H

/* -- Macro Definitions */

#ifdef DEBUG
#define TRACE(x)    db_print x
#else
#define TRACE(x)
#endif /* DEBUG */

/* -- Declarations */

#ifdef DEBUG
extern  int     debug;
#endif

#endif  /* DEBUG_H */

debug.h - version 3.6 (2008-02-11)

/*
@(#)File:           $RCSfile: debug.h,v $
@(#)Version:        $Revision: 3.6 $
@(#)Last changed:   $Date: 2008/02/11 06:46:37 $
@(#)Purpose:        Definitions for the debugging system
@(#)Author:         J Leffler
@(#)Copyright:      (C) JLSS 1990-93,1997-99,2003,2005,2008
@(#)Product:        :PRODUCT:
*/

#ifndef DEBUG_H
#define DEBUG_H

#ifdef HAVE_CONFIG_H
#include "config.h"
#endif /* HAVE_CONFIG_H */

/*
** Usage:  TRACE((level, fmt, ...))
** "level" is the debugging level which must be operational for the output
** to appear. "fmt" is a printf format string. "..." is whatever extra
** arguments fmt requires (possibly nothing).
** The non-debug macro means that the code is validated but never called.
** -- See chapter 8 of 'The Practice of Programming', by Kernighan and Pike.
*/
#ifdef DEBUG
#define TRACE(x)    db_print x
#else
#define TRACE(x)    do { if (0) db_print x; } while (0)
#endif /* DEBUG */

#ifndef lint
#ifdef DEBUG
/* This string can't be made extern - multiple definition in general */
static const char jlss_id_debug_enabled[] = "@(#)*** DEBUG ***";
#endif /* DEBUG */
#ifdef MAIN_PROGRAM
const char jlss_id_debug_h[] = "@(#)$Id: debug.h,v 3.6 2008/02/11 06:46:37 jleffler Exp $";
#endif /* MAIN_PROGRAM */
#endif /* lint */

#include <stdio.h>

extern int      db_getdebug(void);
extern int      db_newindent(void);
extern int      db_oldindent(void);
extern int      db_setdebug(int level);
extern int      db_setindent(int i);
extern void     db_print(int level, const char *fmt,...);
extern void     db_setfilename(const char *fn);
extern void     db_setfileptr(FILE *fp);
extern FILE    *db_getfileptr(void);

/* Semi-private function */
extern const char *db_indent(void);

/**************************************\
** MULTIPLE DEBUGGING SUBSYSTEMS CODE **
\**************************************/

/*
** Usage:  MDTRACE((subsys, level, fmt, ...))
** "subsys" is the debugging system to which this statement belongs.
** The significance of the subsystems is determined by the programmer,
** except that the functions such as db_print refer to subsystem 0.
** "level" is the debugging level which must be operational for the
** output to appear. "fmt" is a printf format string. "..." is
** whatever extra arguments fmt requires (possibly nothing).
** The non-debug macro means that the code is validated but never called.
*/
#ifdef DEBUG
#define MDTRACE(x)  db_mdprint x
#else
#define MDTRACE(x)  do { if (0) db_mdprint x; } while (0)
#endif /* DEBUG */

extern int      db_mdgetdebug(int subsys);
extern int      db_mdparsearg(char *arg);
extern int      db_mdsetdebug(int subsys, int level);
extern void     db_mdprint(int subsys, int level, const char *fmt,...);
extern void     db_mdsubsysnames(char const * const *names);

#endif /* DEBUG_H */

Single argument variant for C99 or later

Kyle Brandt asked:

Anyway to do this so debug_print still works even if there are no arguments? For example:

    debug_print("Foo");

There's one simple, old-fashioned hack:

debug_print("%s\n", "Foo");

The GCC-only solution shown below also provides support for that.

However, you can do it with the straight C99 system by using:

#define debug_print(...) \
            do { if (DEBUG) fprintf(stderr, __VA_ARGS__); } while (0)

Compared to the first version, you lose the limited checking that requires the fmt argument, which means that someone could try to call debug_print() with no arguments (but the trailing comma in the argument list to fprintf() would fail to compile). Whether the loss of checking is a problem at all is debatable.

GCC-specific technique for a single argument

Some compilers may offer extensions for other ways of handling variable-length argument lists in macros. Specifically, as first noted in the comments by Hugo Ideler (now deleted, I believe), GCC allows you to omit the comma that would normally appear after the last 'fixed' argument to the macro. It also allows you to use ##__VA_ARGS__ in the macro replacement text, which deletes the comma preceding the notation if, but only if, the previous token is a comma:

#define debug_print(fmt, ...) \
            do { if (DEBUG) fprintf(stderr, fmt, ##__VA_ARGS__); } while (0)

This solution retains the benefit of requiring the format argument while accepting optional arguments after the format.

This technique is also supported by Clang for GCC compatibility.

You can enclose that variant in #ifdef __GNUC__ / #endif so that it is only used when the code is compiled by GCC. Note that if you use the -pedantic option, you will get a warning (or error if you're using -Werror):

ISO C99 requires at least one argument for the ‘...’ in a variadic macro

You can't use the GCC diagnostic pragmas to suppress it, either:

‘-pedantic’ is not an option that controls warnings

C23 and __VA_OPT__

Both C++20 (and later) and C23 (and later) add the __VA_OPT__ mechanism to handle the problem with __VA_ARGS__ that is handled by GCC using the , ## __VA_ARGS__ notation.

You simply use:

#define debug_print(fmt, ...) \
        do { if (DEBUG) fprintf(stderr, fmt __VA_OPT__(,) __VA_ARGS__); } while (0)

The argument to __VA_OPT__ is added to the output if __VA_ARGS__ is not empty (and nothing is added if __VA_ARGS__ is empty). This should be available if __STDC_VERSION__ >= 202311L — but be aware that GCC 14.1.0 (still) sets __STDC_VERSION__ == 202000 when compiling with -std=c23 or -std=iso9899:2024.

Note that C23 §6.10.5 "Macro Replacement" allows a macro with no named arguments:

#define debug_print(...) \
        do { if (DEBUG) fprintf(stderr, __VA_ARGS__); } while (0)

Used like this, you must still provide at least one argument (the format argument for fprintf()), but you do not need to provide any more arguments. This is not a good way of writing the macro, but it is allowed and it works.


Why the do-while loop?

What's the purpose of the do while here?

You want to be able to use the macro so it looks like a function call, which means it will be followed by a semi-colon. Therefore, you have to package the macro body to suit. If you use an if statement without the surrounding do { ... } while (0), you will have:

/* BAD - BAD - BAD */
#define debug_print(...) \
            if (DEBUG) fprintf(stderr, __VA_ARGS__)

Now, suppose you write:

if (x > y)
    debug_print("x (%d) > y (%d)\n", x, y);
else
    do_something_useful(x, y);

Unfortunately, that indentation doesn't reflect the actual control of flow, because the preprocessor produces code equivalent to this (indented and braces added to emphasize the actual meaning):

if (x > y)
{
    if (DEBUG)
        fprintf(stderr, "x (%d) > y (%d)\n", x, y);
    else
        do_something_useful(x, y);
}

The next attempt at the macro might be:

/* BAD - BAD - BAD */
#define debug_print(...) \
            if (DEBUG) { fprintf(stderr, __VA_ARGS__); }

And the same code fragment now produces:

if (x > y)
    if (DEBUG)
    {
        fprintf(stderr, "x (%d) > y (%d)\n", x, y);
    }
; // Null statement from semi-colon after macro
else
    do_something_useful(x, y);

And the else is now a syntax error. The do { ... } while(0) loop avoids both these problems.

There's one other way of writing the macro which might work:

/* BAD - BAD - BAD */
#define debug_print(...) \
            ((void)((DEBUG) ? fprintf(stderr, __VA_ARGS__) : 0))

This leaves the program fragment shown as valid. The (void) cast prevents it being used in contexts where a value is required — but it could be used as the left operand of a comma operator where the do { ... } while (0) version cannot. If you think you should be able to embed debug code into such expressions, you might prefer this. If you prefer to require the debug print to act as a full statement, then the do { ... } while (0) version is better. Note that if the body of the macro involved any semi-colons (roughly speaking), then you can only use the do { ... } while(0) notation. It always works; the expression statement mechanism can be more difficult to apply. You might also get warnings from the compiler with the expression form that you'd prefer to avoid; it will depend on the compiler and the flags you use.


GCC Statement Expressions

Atreyagaurav commented:

How about using ({ … }) to put that if (DEBUG) {code} part into a block? Then that if won't matter for an else statement outside.

I answered unnecessarily tersely — for which I now apologize:

That’s not C. I don’t use that feature of GCC.

However, a more reasonable response would be:

That extension feature of GCC is called an Statement Expression. If you don't mind being bound to the GCC or Clang compilers (or any other compiler that provides the feature for compatibility with GCC), and if you do want to use the debug statement as a general expression rather than as an "expression statement" (an expression followed by a semicolon), then by all means use it.



_TPOP was previously at http://plan9.bell-labs.com/cm/cs/tpop and http://cm.bell-labs.com/cm/cs/tpop but both are now (2015-08-10) broken._

Code in GitHub

If you're curious, you can look at this code in GitHub in my SOQ (Stack Overflow Questions) repository as files debug.c, debug.h, mddebug.c and mddebug.h in the src/libsoq sub-directory.

Sign up to request clarification or add additional context in comments.

30 Comments

Years later, and this answer is still the most useful out of all the internets, on how to alias printk! vfprintf does not work in kernel space since stdio is not available. Thank you! #define debug(...) \ do { if (DEBUG) \ printk("DRIVER_NAME:"); \ printk(__VA_ARGS__); \ printk("\n"); \ } while (0)
In your example with the keywords __FILE__, __LINE__, __func__, __VA_ARGS__, it won't compile if you have no printf parameters, i.e. if you just call debug_print("Some msg\n"); You can fix this by using fprintf(stderr, "%s:%d:%s(): " fmt, __FILE__, __LINE__, __func__, ##__VA_ARGS__); The ##__VA_ARGS__ allows passing no parameters to the function.
@LogicTom: the difference is between #define debug_print(fmt, ...) and #define debug_print(...). The first of these requires at least one argument, the format string (fmt) and zero or more other arguments; the second requires zero or more arguments in total. If you use debug_print() with the first, you get an error from the preprocessor about misusing the macro, whereas the second does not. However, you still get compilation errors because the replacement text is not valid C. So, it really isn't much of an difference — hence the use of the term 'limited checking'.
@JonathanLeffler Im afraid, I need more of your explanation, of what did you mean with handles the printing itself, and why do you mention flockfile() ?
The variant shown abover, @St.Antario, uses a single active debugging level across the entire application, and I usually use command line options to allow the debugging level to be set when the program is run. I also have a variant that recognizes multiple different subsystems, each of which is given a name and its own debugging level, so that I can use -D input=4,macros=9,rules=2 to set the debug level of the input system to 4, the macros system to 9 (undergoing intense scrutiny) and the rules system to 2. There are endless variations on the theme; use whatever suits you.
|
32

I use something like this:

#ifdef DEBUG
 #define D if(1) 
#else
 #define D if(0) 
#endif

Than I just use D as a prefix:

D printf("x=%0.3f\n",x);

Compiler sees the debug code, there is no comma problem and it works everywhere. Also it works when printf is not enough, say when you must dump an array or calculate some diagnosing value that is redundant to the program itself.

EDIT: Ok, it might generate a problem when there is else somewhere near that can be intercepted by this injected if. This is a version that goes over it:

#ifdef DEBUG
 #define D 
#else
 #define D for(;0;)
#endif

3 Comments

As for for(;0;), it might generate a problem when you write something like D continue; or D break;.
Got me; it seems very unlikely that it may occur on accident, though.
A more readable version just for printing might be #define PRINTF if (0) printf, as then you don't need the prefix everywhere.
11

Here's the version I use:

#ifdef NDEBUG
#define Dprintf(FORMAT, ...) ((void)0)
#define Dputs(MSG) ((void)0)
#else
#define Dprintf(FORMAT, ...) \
    fprintf(stderr, "%s() in %s, line %i: " FORMAT "\n", \
        __func__, __FILE__, __LINE__, __VA_ARGS__)
#define Dputs(MSG) Dprintf("%s", MSG)
#endif

Comments

11

For a portable (ISO C90) implementation, you could use double parentheses, like this;

#include <stdio.h>
#include <stdarg.h>

#ifndef NDEBUG
#  define debug_print(msg) stderr_printf msg
#else
#  define debug_print(msg) (void)0
#endif

void
stderr_printf(const char *fmt, ...)
{
  va_list ap;
  va_start(ap, fmt);
  vfprintf(stderr, fmt, ap);
  va_end(ap);
}

int
main(int argc, char *argv[])
{
  debug_print(("argv[0] is %s, argc is %d\n", argv[0], argc));
  return 0;
}

or (hackish, wouldn't recommend it)

#include <stdio.h>

#define _ ,
#ifndef NDEBUG
#  define debug_print(msg) fprintf(stderr, msg)
#else
#  define debug_print(msg) (void)0
#endif

int
main(int argc, char *argv[])
{
  debug_print("argv[0] is %s, argc is %d"_ argv[0] _ argc);
  return 0;
}

1 Comment

@LB: to make the preprocessor `think' there's just one argument, while letting _ to be expanded at a later stage.
9

I would do something like

#ifdef DEBUG
#define debug_print(fmt, ...) fprintf(stderr, fmt, __VA_ARGS__)
#else
#define debug_print(fmt, ...) do {} while (0)
#endif

I think this is cleaner.

11 Comments

I don't really like the idea of using a macro inside a test as a flag. Could you explain why the debug printing should be always checked ?
@Jonathan: If the code only ever gets executed in debug mode, why should you care if it compiles in non-debug mode? assert() from the stdlib works the same way and I normally just re-use the NDEBUG macro for my own debugging code...
using DEBUG in the test, if someone does an uncontrolled undef DEBUG, your code no longer compiles. right ?
It is frustrating to enable debugging and then have to debug the debugging code because it refers to variables that have been renamed or retyped, etc. If the compiler (post pre-processor) always sees the print statement, it ensures that any surrounding changes have not invalidated the diagnostics. If the compiler does not see the print statement, it cannot protect you against your own carelessness (or the carelessness of your colleagues or collaborators). See 'The Practice of Programming' by Kernighan and Pike - plan9.bell-labs.com/cm/cs/tpop.
@Christoph: well, sort of...I use NDEBUG to control assertions only, and a separate macro (usually DEBUG) to control debug tracing. I frequently do not want debug output to appear unconditionally, so I have mechanism to control whether the output appears (debug levels, and instead of calling fprintf() directly, I call a debug print function that only conditionally prints so the same build of the code can print or not print based on program options). I am advocating that for all builds, the compiler should see the diagnostic statements; however, it won't generate code unless debug is enabled.
|
9

According to http://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html, there should be a ## before __VA_ARGS__.

Otherwise, a macro #define dbg_print(format, ...) printf(format, __VA_ARGS__) will not compile the following example: dbg_print("hello world");.

1 Comment

Welcome to Stack Overflow. You are correct that GCC has the non-standard extension that you reference. The currently accepted answer does in fact mention this, including exactly the reference URL you give.
8
#define debug_print(FMT, ARGS...) do { \
    if (DEBUG) \
        fprintf(stderr, "%s:%d " FMT "\n", __FUNCTION__, __LINE__, ## ARGS); \
    } while (0)

4 Comments

Which version of C supports that notation? And, if it worked, the token pasting all the arguments like that means that you have only a very limited set of options for the format string, doesn't it?
@Jonathan: gcc (Debian 4.3.3-13) 4.3.3
OK - agreed: it is documented as an old GNU extension (section 5.17 of the GCC 4.4.1 manual). But you should probably document that it will only work with GCC - or maybe we've done that between us in these comments.
My intention was to show another style of using args and mainly to demonstrate the usage of FUNCTION and LINE
2

This is what I use:

#if DBG
#include <stdio.h>
#define DBGPRINT printf
#else
#define DBGPRINT(...) /**/  
#endif

It has the nice benefit to handle printf properly, even without additional arguments. In case DBG ==0, even the dumbest compiler gets nothing to chew upon, so no code is generated.

1 Comment

It is better to have the compiler always check the debug code.
2

So, when using gcc, I like:

#define DBGI(expr) ({int g2rE3=expr; fprintf(stderr, "%s:%d:%s(): ""%s->%i\n", __FILE__,  __LINE__, __func__, #expr, g2rE3); g2rE3;})

Because it can be inserted into code.

Suppose you're trying to debug

printf("%i\n", (1*2*3*4*5*6));

720

Then you can change it to:

printf("%i\n", DBGI(1*2*3*4*5*6));

hello.c:86:main(): 1*2*3*4*5*6->720
720

And you can get an analysis of what expression was evaluated to what.

It's protected against the double-evaluation problem, but the absence of gensyms does leave it open to name-collisions.

However it does nest:

DBGI(printf("%i\n", DBGI(1*2*3*4*5*6)));

hello.c:86:main(): 1*2*3*4*5*6->720
720
hello.c:86:main(): printf("%i\n", DBGI(1*2*3*4*5*6))->4

So I think that as long as you avoid using g2rE3 as a variable name, you'll be OK.

Certainly I've found it (and allied versions for strings, and versions for debug levels etc) invaluable.

Comments

2

I've been stewing on how to do this for years, and finally come up with a solution. However, I didn't know that there were other solutions here already. First, at difference with Leffler's answer, I don't see his argument that debug prints should always be compiled. I'd rather not have tons of unneeded code executing in my project, when not needed, in cases where I need to test and they might not be getting optimized out.

Not compiling every time might sound worse than it is in actual practice. You do wind up with debug prints that don't compile sometimes, but it's not so hard to compile and test them before finalizing a project. With this system, if you are using three levels of debugs, just put it on debug message level three, fix your compile errors and check for any others before you finalize yer code. (Since of course, debug statements compiling are no guarantee that they are still working as intended.)

My solution provides for levels of debug detail also; and if you set it to the highest level, they all compile. If you've been using a high debug detail level recently, they all were able to compile at that time. Final updates should be pretty easy. I've never needed more than three levels, but Jonathan says he's used nine. This method (like Leffler's) can be extended to any number of levels. The usage of my method may be simpler; requiring just two statements when used in your code. I am, however, coding the CLOSE macro too - although it doesn't do anything. It might if I were sending to a file.

Against the cost the extra step of testing them to see that they will compile before delivery, is that

  1. You must trust them to get optimized out, which admittedly SHOULD happen if you have a sufficient optimization level.
  2. Furthermore, they probably won't if you make a release compile with optimization turned off for testing purposes (which is admittedly rare); and they almost certainly won't at all during debug - thereby executing dozens or hundreds of "if (DEBUG)" statements at runtime; thus slowing execution (which is my principle objection) and less importantly, increasing your executable or dll size; and hence execution and compile times. Jonathan, however, informs me his method can be made to also not compile statements at all.

Branches are actually relatively pretty costly in modern pre-fetching processors. Maybe not a big deal if your app is not a time-critical one; but if performance is an issue, then, yes, a big enough deal that I'd prefer to opt for somewhat faster-executing debug code (and possibly faster release, in rare cases, as noted).

So, what I wanted is a debug print macro that does not compile if it is not to be printed, but does if it is. I also wanted levels of debugging, so that, e.g. if I wanted performance-crucial parts of the code not to print at some times, but to print at others, I could set a debug level, and have extra debug prints kick in. I came across a way to implement debug levels that determined if the print was even compiled or not. I achieved it this way:

DebugLog.h:

// FILE: DebugLog.h
// REMARKS: This is a generic pair of files useful for debugging.  It provides three levels of 
// debug logging, currently; in addition to disabling it.  Level 3 is the most information.
// Levels 2 and 1 have progressively more.  Thus, you can write: 
//     DEBUGLOG_LOG(1, "a number=%d", 7);
// and it will be seen if DEBUG is anything other than undefined or zero.  If you write
//     DEBUGLOG_LOG(3, "another number=%d", 15);
// it will only be seen if DEBUG is 3.  When not being displayed, these routines compile
// to NOTHING.  I reject the argument that debug code needs to always be compiled so as to 
// keep it current.  I would rather have a leaner and faster app, and just not be lazy, and 
// maintain debugs as needed.  I don't know if this works with the C preprocessor or not, 
// but the rest of the code is fully C compliant also if it is.

#define DEBUG 1

#ifdef DEBUG
#define DEBUGLOG_INIT(filename) debuglog_init(filename)
#else
#define debuglog_init(...)
#endif

#ifdef DEBUG
#define DEBUGLOG_CLOSE debuglog_close
#else
#define debuglog_close(...)
#endif

#define DEBUGLOG_LOG(level, fmt, ...) DEBUGLOG_LOG ## level (fmt, ##__VA_ARGS__)

#if DEBUG == 0
#define DEBUGLOG_LOG0(...)
#endif

#if DEBUG >= 1
#define DEBUGLOG_LOG1(fmt, ...) debuglog_log (fmt, ##__VA_ARGS__)
#else
#define DEBUGLOG_LOG1(...)
#endif

#if DEBUG >= 2
#define DEBUGLOG_LOG2(fmt, ...) debuglog_log (fmt, ##__VA_ARGS__)
#else
#define DEBUGLOG_LOG2(...)
#endif

#if DEBUG == 3
#define DEBUGLOG_LOG3(fmt, ...) debuglog_log (fmt, ##__VA_ARGS__)
#else
#define DEBUGLOG_LOG3(...)
#endif

void debuglog_init(char *filename);
void debuglog_close(void);
void debuglog_log(char* format, ...);

DebugLog.cpp:

// FILE: DebugLog.h
// REMARKS: This is a generic pair of files useful for debugging.  It provides three levels of 
// debug logging, currently; in addition to disabling it.  See DebugLog.h's remarks for more 
// info.

#include <stdio.h>
#include <stdarg.h>

#include "DebugLog.h"

FILE *hndl;
char *savedFilename;

void debuglog_init(char *filename)
{
    savedFilename = filename;
    hndl = fopen(savedFilename, "wt");
    fclose(hndl);
}

void debuglog_close(void)
{
    //fclose(hndl);
}

void debuglog_log(char* format, ...)
{
    hndl = fopen(savedFilename,"at");
    va_list argptr;
    va_start(argptr, format);
    vfprintf(hndl, format, argptr);
    va_end(argptr);
    fputc('\n',hndl);
    fclose(hndl);
}

Using the macros

To use it, just do:

DEBUGLOG_INIT("afile.log");

To write to the log file, just do:

DEBUGLOG_LOG(1, "the value is: %d", anint);

To close it, you do:

DEBUGLOG_CLOSE();

although currently this isn't even necessary, technically speaking, as it does nothing. I'm still using the CLOSE right now, however, in case I change my mind about how it works, and want to leave the file open between logging statements.

Then, when you want to turn on debug printing, just edit the first #define in the header file to say, e.g.

#define DEBUG 1

To have logging statements compile to nothing, do

#define DEBUG 0

If you need info from a frequently executed piece of code (i.e. a high level of detail), you may want to write:

 DEBUGLOG_LOG(3, "the value is: %d", anint);

If you define DEBUG to be 3, logging levels 1, 2 & 3 compile. If you set it to 2, you get logging levels 1 & 2. If you set it to 1, you only get logging level 1 statements.

As to the do-while loop, since this evaluates to either a single function or nothing, instead of an if statement, the loop is not needed. OK, castigate me for using C instead of C++ IO (and Qt's QString::arg() is a safer way of formatting variables when in Qt, too — it's pretty slick, but takes more code and the formatting documentation isn't as organized as it might be - but still I've found cases where its preferable), but you can put whatever code in the .cpp file you want. It also might be a class, but then you would need to instantiate it and keep up with it, or do a new() and store it. This way, you just drop the #include, init and optionally close statements into your source, and you are ready to begin using it. It would make a fine class, however, if you are so inclined.

I'd previously seen a lot of solutions, but none suited my criteria as well as this one.

  1. It can be extended to do as many levels as you like.
  2. It compiles to nothing if not printing.
  3. It centralizes IO in one easy-to-edit place.
  4. It's flexible, using printf formatting.
  5. Again, it does not slow down debug runs, whereas always-compiling debug prints are always executed in debug mode. If you are doing computer science, and not easier to write information processing, you may find yourself running a CPU-consuming simulator, to see e.g. where the debugger stops it with an index out of range for a vector. These run extra-slowly in debug mode already. The mandatory execution of hundreds of debug prints will necessarily slow such runs down even further. For me, such runs are not uncommon.

Not terribly significant, but in addition:

  1. It requires no hack to print without arguments (e.g. DEBUGLOG_LOG(3, "got here!");); thus allowing you to use, e.g. Qt's safer .arg() formatting. It works on MSVC, and thus, probably gcc. It uses ## in the #defines, which is non-standard, as Leffler points out, but is widely supported. (You can recode it not to use ## if necessary, but you will have to use a hack such as he provides.)

Warning: If you forget to provide the logging level argument, MSVC unhelpfully claims the identifier is not defined.

You might want to use a preprocessor symbol name other than DEBUG, as some source also defines that symbol (eg. progs using ./configure commands to prepare for building). It seemed natural to me when I developed it. I developed it in an application where the DLL is being used by something else, and it's more convent to send log prints to a file; but changing it to vprintf() would work fine, too.

I hope this saves many of you grief about figuring out the best way to do debug logging; or shows you one you might prefer. I've half-heartedly been trying to figure this one out for decades. Works in MSVC 2012 & 2015, and thus probably on gcc; as well as probably working on many others, but I haven't tested it on them.

I mean to make a streaming version of this one day, too.

Note: Thanks go to Leffler, who has cordially helped me format my message better for StackOverflow.

9 Comments

You say "executing dozens or hundreds of if (DEBUG) statements at runtime, which do not get optimized out" — which is tilting at windmills. The whole point of the system I described is that the code is checked by the compiler (important, and automatic — no special build required) but the debug code is not generated at all because it is optimized out (so there is zero runtime impact on code size or performance because the code is not present at runtime).
Jonathan Leffler: Thx for pointing out my mis-wording. I let my thoughts race faster than my fingers, being so glad to have this finished. I've revised my objections with "... 1) you must trust them to get optimized out, which admittedly should happen if you have a sufficient optimization level. 2) Furthermore, they won't if you make a release compile with optimization turned off for testing purposes; and they probably won't at all during debug - thereby executing dozens or hundreds of 'if (DEBUG)' statements at runtime - thereby increasing your executable or dll size, and execution times."
For yours to do the other important thing mine is doing, you would have to have debug levels. While I often don't need a lot of them turned on, a few applications really benefit from being able to get a great level of detail about a time-critical loop with a simple "#define DEBUG 3", and then go back to much less verbose information with "#define DEBUG 1". I've never needed more than three levels, and thus, at least roughly 1/3 of my debugs compile already at release. If I've used level 3 recently, they probably ALL do.
YMMV. The modern system I showed supports dynamic (runtime) setting of debug levels, so you can programmatically decide how much of the debug is produced at runtime. I usually used levels 1-9, though there's no upper limit (or lower limit; the default level is 0 which is usually off, but can be explicitly requested during active development if appropriate — it is not appropriate for long-term work). I chose a default level of 3; things can be tuned. This gives me a lot of control. If you really don't want to test the debug code when inactive, change the alternative to ((void)0) — it's easy.
Ahh. It would have helped to have read the entire thing. It is a rather long post. I think that's got the essential points thus far. It turns out yours, like mine, can be used to compile or not compile all debug prints, and can support levels; although admittedly, yours can compile levels you aren't using - at a cost during debug.
|
1

My favourite of the below is var_dump, which when called as:

var_dump("%d", count);

produces output like:

patch.c:150:main(): count = 0

Credit to @"Jonathan Leffler". All are C89-happy:

Code

#define DEBUG 1
#include <stdarg.h>
#include <stdio.h>
void debug_vprintf(const char *fmt, ...)
{
    va_list args;
    va_start(args, fmt);
    vfprintf(stderr, fmt, args);
    va_end(args);
}

/* Call as: (DOUBLE PARENTHESES ARE MANDATORY) */
/* var_debug(("outfd = %d, somefailed = %d\n", outfd, somefailed)); */
#define var_debug(x) do { if (DEBUG) { debug_vprintf ("%s:%d:%s(): ", \
    __FILE__,  __LINE__, __func__); debug_vprintf x; }} while (0)

/* var_dump("%s" variable_name); */
#define var_dump(fmt, var) do { if (DEBUG) { debug_vprintf ("%s:%d:%s(): ", \
    __FILE__,  __LINE__, __func__); debug_vprintf ("%s = " fmt, #var, var); }} while (0)

#define DEBUG_HERE do { if (DEBUG) { debug_vprintf ("%s:%d:%s(): HERE\n", \
    __FILE__,  __LINE__, __func__); }} while (0)

Comments

1
#define PRINT_LOG(str_format, ...) { \
    time_t curtime=time (NULL); \
    struct tm *ltm = localtime (&curtime); \
    printf("[%d-%02d-%02d %02d:%02d:%02d] " str_format, \
        ltm->tm_year + 1900, ltm->tm_mon + 1, ltm->tm_mday, \
        ltm->tm_hour, ltm->tm_min, ltm->tm_sec, ##__VA_ARGS__); \
}
    
PRINT_LOG("[%d] Serving client, str=%s, number=%d\n", getpid(), "my str", 10);

1 Comment

Thank you for this code snippet, which might provide some limited, immediate help. A proper explanation would greatly improve its long-term value by showing why this is a good solution to the problem and would make it more useful to future readers with other, similar questions. Please edit your answer to add some explanation, including the assumptions you’ve made.
0

I believe this variation of the theme gives debug categories without the need to have a separate macro name per category.

I used this variation in an Arduino project where program space is limited to 32K and dynamic memory is limited to 2K. The addition of debug statements and trace debug strings quickly uses up space. So it is essential to be able to limit the debug trace that is included at compile time to the minimum necessary each time the code is built.

debug.h

#ifndef DEBUG_H
#define DEBUG_H

#define PRINT(DEBUG_CATEGORY, VALUE)  do { if (DEBUG_CATEGORY & DEBUG_MASK) Serial.print(VALUE);} while (0);

#endif

calling .cpp file

#define DEBUG_MASK 0x06
#include "Debug.h"

...
PRINT(4, "Time out error,\t");
...

Comments

0

If you don't care that the output goes to stdout, you can use this:

int doDebug = DEBUG;  // Where DEBUG may be supplied in compiler command
#define trace if (doDebug) printf

trace("whatever %d, %i\n", arg1, arg2);

Comments

0

Generic debugging macros to conditionally compile and run any code in C or C++ based on debug levels

Here's one way that uses the preprocessor and works with any code in C or C++:

debug.h:

#pragma once

// 1. Your debug levels to choose from:

#define DEBUG_LEVEL_OFF     100 // Print/run nothing. 

#define DEBUG_LEVEL_ERROR   50  // Print/run `DEBUG_ERROR()` statements & higher.
#define DEBUG_LEVEL_WARNING 40  // Print/run `DEBUG_WARNING()` statements & higher.
#define DEBUG_LEVEL_LOG     30  // Print/run `DEBUG_LOG()` statements & higher.
#define DEBUG_LEVEL_DEBUG   20  // Print/run `DEBUG_DEBUG()` statements & higher.
#define DEBUG_LEVEL_INFO    10  // Print/run `DEBUG_INFO()` statements & higher.

#define DEBUG_LEVEL_ALL     0   // Print/run everything. 


// 2. Your debug macros to call: 

// Call `code` if `macroDebugLevel` >= `yourDebugLevel`.
//
// Example 1: to conditionally run a **single line of code**:
// ```c
// #define MY_DEBUG_LEVEL  DEBUG_LEVEL_INFO
// DEBUG_INFO(MY_DEBUG_LEVEL, printf("vals: %i; %f\n", my_int, my_float));
// ```
//
// Example 2: to conditionally run **multiple lines of code**:
// ```c
// #define MY_DEBUG_LEVEL  DEBUG_LEVEL_INFO
// DEBUG_INFO(MY_DEBUG_LEVEL,
//     int my_int = 7;
//     float my_float = 3.14;
//     printf("vals: %i; %f\n", my_int, my_float);
//     my_int = 8;
//     my_float = 2.718;
//     printf("vals: %i; %f\n", my_int, my_float);
// );
// ```
#define DEBUG_ERROR(yourDebugLevel, code) \
    _DEBUG_RUN(DEBUG_LEVEL_ERROR, (yourDebugLevel), code)
#define DEBUG_WARNING(yourDebugLevel, code) \
    _DEBUG_RUN(DEBUG_LEVEL_WARNING, (yourDebugLevel), code)
#define DEBUG_LOG(yourDebugLevel, code) \
    _DEBUG_RUN(DEBUG_LEVEL_LOG, (yourDebugLevel), code)
#define DEBUG_DEBUG(yourDebugLevel, code) \
    _DEBUG_RUN(DEBUG_LEVEL_DEBUG, (yourDebugLevel), code)
#define DEBUG_INFO(yourDebugLevel, code) \
    _DEBUG_RUN(DEBUG_LEVEL_INFO, (yourDebugLevel), code)

// Internal macro to run `code` if `macroDebugLevel` >= `yourDebugLevel`.
// - Since the `if` statement is determined by the compiler at compile time, 
//   the entire `code` block is optimized out for all compiler optimization 
//   levels other than `-O0` (no optimization). This removes unnecessary 
//   code and runtime processing from the final binary.
#define _DEBUG_RUN(macroDebugLevel, yourDebugLevel, code) \
    do \
    { \
        if ((macroDebugLevel) >= (yourDebugLevel)) \
        { \
            code; \
        } \
    } while (0)

Usage:

#include "debug.h"

// With this define, the debug code below WILL run since I call `DEBUG_INFO()`,
// whose `macroDebugLevel` (`DEBUG_LEVEL_INFO`) **is** >= `MY_DEBUG_LEVEL` 
// (also `DEBUG_LEVEL_INFO`).
#define MY_DEBUG_LEVEL  DEBUG_LEVEL_INFO

// With this define, the debug code below will NOT run since I call 
// `DEBUG_INFO()` but the level is set higher, to `DEBUG_LEVEL_WARNING`.
// #define MY_DEBUG_LEVEL  DEBUG_LEVEL_WARNING

// Example 1: single line of code to print
// - Put this inside some function where you want to write some debug info
//   if `MY_DEBUG_LEVEL` is low enough, or otherwise stated: the `DEBUG_*()` 
//   macro is high enough.
DEBUG_INFO(MY_DEBUG_LEVEL, printf("vals: %i; %f\n", my_int, my_float));

// Example 2: multiple lines of code
// - Put this inside some function where you want to run some debug code
//   if `MY_DEBUG_LEVEL` is low enough, or otherwise stated: the `DEBUG_*()`
//   macro is high enough.
DEBUG_INFO(MY_DEBUG_LEVEL,
    int my_int = 7;
    float my_float = 3.14;
    printf("vals: %i; %f\n", my_int, my_float);
    my_int = 8;
    my_float = 2.718;
    printf("vals: %i; %f\n", my_int, my_float);
);

In the above example, the DEBUG_INFO macro will only run the passed-in code statement or statements if MY_DEBUG_LEVEL is less than or equal to DEBUG_LEVEL_INFO, or, otherwise stated, the code will run if the macro debug level is >= your debug level. To force these debug lines to run, lower MY_DEBUG_LEVEL to DEBUG_LEVEL_INFO or lower, or increase the DEBUG_INFO() macro to a sufficiently high level.

Example: if MY_DEBUG_LEVEL is set to DEBUG_LEVEL_WARNING, then the debug code will only run if you use the DEBUG_WARNING() or DEBUG_ERROR() macros to call your code to run.

The nice thing about the above technique is that it does not rely on any particular debug print mechanism or function, such as printf(). Rather, the debug code above can be universally applied to any code that you want to run conditionally based on a debug level.

Additionally, if you have compile-time optimizations turned on, you'll end up with something like this after preprocessing:

do
{
    if (2 <= 1)
    {
        printf("vals: %i; %f\n", my_int, my_float);
    }
} while (0);

...and if the if statement is false, such as if (2 <= 1) in this case, the compiler will see that it's always false, at compile time, and optimize it out so that you don't have any runtime overhead nor program memory storage for debug code that isn't supposed to run.

Note that the purpose of the do while loop is to ensure that the macro can be used in any context and is always counted as a single statement, even if you were to later add an else statement or something after your if statement.

Note: this answer was moved from here, where I've now deleted it.

See also

  1. My answer: Debug Print Macro in C? - my more specific printf() variadic macro approach

Comments

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.