Check Passwords Match Issue (JavaScript)

Question

can anybody see the issue with the following code? My script continues, ignoring my check.

The code below is only a snippet of the code but this issue is in here somewhere after doing some debugging.

function validatePasswordMatch(string1, string2) {
    if (string1 != string2) {
       return false;
    } else {
       return true;
    }
}

var validatePasswordMatchFields = ["textbox2", "textbox3"];

if (validatePasswordMatch($("#" + validatePasswordMatchFields[0]).val(), $("#" + validatePasswordMatchFields[1]).val())) {
   (some code)
} else {
   return false;
}

Well if the some code runs then it means that the two values are equal. What else did you expect? Do you run it at the wrong time? What values do the two textboxes have? — Bergi
– Bergi, Commented Jul 30, 2013 at 15:03
Ugh... if (boolean) { return false; } else { return true; }. Why do you even need this function? Just do if (expr1 == expr2) { some code } else { return false; } — NullUserException
– NullUserException, Commented Jul 30, 2013 at 15:09

Kousik · Accepted Answer · 2013-08-30 12:46:48Z

<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<title>stackoverflow</title>
<script type="text/javascript" src="https://ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js"></script>
<script>
$(document).ready(function(){
    function validatePasswordMatch(string1, string2) {
      if (string1 !== string2) {
        return false;
      } else {
        return true;
      }
    }

    var validatePasswordMatchFields = ["textbox2", "textbox3"];
    $(document).on('click','button',function(){
      result = validatePasswordMatch($("#" + validatePasswordMatchFields[0]).val(), $("#" + validatePasswordMatchFields[1]).val())
    if (result) {
      alert("match")
    } else {
      alert("not match")
    }
    })

});
</script>
</head>
<body>
<input id="textbox2" type="text" placeholder="password">
<input id="textbox3" type="text" placeholder="password">
<button type="button" id="button">Click Me!</button> 
</html>

Collectives™ on Stack Overflow

Check Passwords Match Issue (JavaScript)

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related