mysql query in a function... not working

Question

I made this function. It's actually one of the first functions I've ever made. However, I can't get it to execute. $con is defined, i just didn't paste it. In fact, all of the variables are defined.

function cleanse() {
    $cleansesql = "Select * FROM rated_teams WHERE server='$server' AND name='$myteam' AND opposition='$opposer'";
    $result = mysqli_query($con, $cleansesql)
    or die('A error occured: '.mysqli_error());
    while (($row = mysqli_fetch_array($result))) {
        if ($row['server'] == $server && $row['name'] == $myteam && $row['opposition'] == $opposer && $row['myscore'] == $myscore && $row['oscore'] == $oscore && $row['location'] == $location) {
            echo "There is a Match.";
        } else {
            echo "There are no matches";
        }
    }
}

And this is how I'm calling it.

if ($solo == "solo" || $solo == "Solo" || $solo == "SOLO") {
    echo $solo." <br />";
    if (!empty($myscore)) {
        echo $myscore." <br />";
        if (!empty($oscore)) {
            echo $oscore." <br />";
            if (!empty($location)) {
                echo $location." <br />";
                cleanse();
            }
        }
    }
}

Maybe I'm not calling it correctly. I just need someone who knows more than me to help... that'll be most of you hahaha.

where is your $con value established? I don't see you connected to the MySQL database, simply passing the variable — mattpic
– mattpic, Commented Aug 3, 2013 at 23:16
This isn't about your direct question, but you might want to incorporate strtolower() in your check for 'solo' see php.net/manual/en/function.strtolower.php for more info. — starshine531
– starshine531, Commented Aug 4, 2013 at 1:20

federicot · Accepted Answer · 2013-08-03 23:21:12Z

1

Pass the information to your cleanse function, like $con (given that you've created your connection to the database prior to calling this function), $server, $myteam and $opposer so it can work with it.

So the definition of your function would become:

function cleanse($con, $server, $myteam, $opposer) { ... }

And you'd call it this way:

cleanse($con, $server, $myteam, $opposer);

answered Aug 3, 2013 at 23:21

federicot

12.3k19 gold badges71 silver badges111 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

hdvianna · Accepted Answer · 2013-08-03 23:46:50Z

1

Notice that you are using a variable $con which is the connection to MySQL.
You have not created a connection to MySQL prior to the query.
I suggest reading the basic PHP manuals on using mysqli.
Remeber the follwing:

You need to connect to SERVER
You need to choose the DB u work against
You will execute queries against that DB.

2 is not mandatory.

edited Aug 3, 2013 at 23:46

hdvianna

4535 silver badges13 bronze badges

answered Aug 3, 2013 at 23:16

Itay Moav -Malimovka

53.8k68 gold badges198 silver badges292 bronze badges

Comments

Robert Seddon-Smith · Accepted Answer · 2013-08-03 23:34:29Z

0

Campari is right - that is why your function is not working, however:

You are duplicating your code. The function does not need to check if there is a match between your test criteria and the output of the sql because the database does that for you. What your sql says is "fetch all the results that match all of my criteria" then your function says "check all the results match my criteria" this is slow and not required. If you write your sql properly, there is rarely any need for further checking or merging of data in PHP.

function cleanse($connection, $server, $myteam, $opposer)
    {
    $cleansesql="Select * FROM rated_teams WHERE server=? AND name=? AND opposition=?";
    $stmnt=$connection->prepare($cleansesql);
    $stmnt->bind_param("sss",$server,$myteam,$opposer);
    $stmnt->execute();
    $stmnt->store_result();
    return $stmnt->num_rows;
    }

This (untested) function I've written for you should return the number of rows in rated_teams that match all of the criteria in your variables. It is also safe to input user-entered data as it uses prepared statements and is thus not susceptible to SQL injection.

answered Aug 3, 2013 at 23:34

Robert Seddon-Smith

9771 gold badge10 silver badges13 bronze badges

2 Comments

CSharpMinor Over a year ago

$con is defined. dont worry about that.

CSharpMinor Over a year ago

Fatal error: Call to a member function prepare() on a non-object in on $stmnt=$con->prepare($cleansesql);

Collectives™ on Stack Overflow

mysql query in a function... not working

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related