Spring @Cacheable doesn't cache public methods

Question

I have following method;

    @Cacheable(value = "psgSiteToMap", key = "'P2M_'.concat(#siteName)")
    public Map getSiteDetail(String siteName) {
        Map map = new HashMap();
        .....
        //construct map variable here
        .......
        return map;
    }

While project startup, cannot autowire class this method belongs to. If i change above method as following;

    @Cacheable(value = "psgSiteToMap", key = "'P2M_'.concat(#siteName)")
    private Map getSiteDetail(String siteName) {
        Map map = new HashMap();
        .....
        //construct map variable here
        ................
        return map;
    }

    public Map getSiteDetailPublic(String siteName) {
         return this.getSiteDetail(siteName);
    }

it works. Is there any restriction on @Cacheable annotation for public methods?

Thanks in advance

I have used it in my project for public methods, it just works fine. Also the Ehcache documentation doesn't say anything of that sort. The example shown in the link uses a public method. — Shashank Kadne
– Shashank Kadne, Commented Aug 12, 2013 at 11:02
@ShashankKadne In other class, i also use for public methods and it works fine. However, in this class it doesn't work for method getSiteDetail(String siteName) — Hüseyin BABAL
– Hüseyin BABAL, Commented Aug 12, 2013 at 11:05

Dherik · Accepted Answer · 2019-08-12 19:58:45Z

5

Spring AOP works only on public methods by default. You'd need AspectJ and load time or compile time weaving to make it work on private methods.

So it works in your case means that when you move the @Cacheable to the private method the proxy is not created at all and that works is autowireing, but not caching.

You probably have not set proxy-target-class property in your XML configuration or its equivalent annotation attribute. Can you please add the Spring configuration you're using and the class definition line. I'm interested if it implements any interfaces? Than I'll expand my answer with more details.

edited Aug 12, 2019 at 19:58

Dherik

19.4k15 gold badges132 silver badges177 bronze badges

answered Aug 12, 2013 at 16:12

Roadrunner

6,8411 gold badge31 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Spring @Cacheable doesn't cache public methods

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related