Rails: Issue with if statement using ajax and jquery

Question

I am posting new "tweets" and with jquery and ajax I am able to show the newly posted tweet without refreshing the page. But in my view template, I have an if statement that checks if it is the current_user and if so, displays the delete button.

But Ajax does not read the if statement and does not display the delete button. The delete button shows up if I refresh the page or if I remove the if statement. That defeats the purpose since the button shows up on other users' profiles also.

Here is my view:

<ul class="tweets>
<li>
    <span><%= tweet.content %></span><br>
    <% if current_user?(@user)%>
        <%= link_to "Delete" tweet, method: :delete, data: { confirm: "You sure?" } %>
    <%end%>
</li>
</ul>

My create.js.erb: $('.tweets').prepend('<%= j render(@tweet)%>')

do you really expect the ajax request to reread your original view?, unless you're showing the tweet partial? — apneadiving
– apneadiving, Commented Aug 16, 2013 at 14:42
In your partial, try debugging current_user and see if its actually being sent. Just at the end of your content block put a "ID: #{current_user.id}" or something along those lines to see the output. — Michael Lynch
– Michael Lynch, Commented Aug 16, 2013 at 14:52
If it does read current_user, then perhaps the if statement is executing to false? Which is strange due to the fact that it works on reload. Perhaps try using a different if syntax? (this is just a random guess / couldn't hurt to try kinda thing). Maybe try "if current_user.id == tweet.user.id" ? — Michael Lynch
– Michael Lynch, Commented Aug 16, 2013 at 15:00

Michael Lynch · Accepted Answer · 2013-08-16 15:45:20Z

2

If current_user is the user object for the current logged in user, and you have a user associated with your tweet. To verify ownership, I would recommend:

    <% if current_user.id == tweet.user.id %>

Edited:

Doing the above will require rails to perform an addition database query to obtain the tweet.user user data. Changing it to the following will eliminate the additional query:

    <% if current_user.id == tweet.user_id %>

edited Aug 16, 2013 at 15:45

answered Aug 16, 2013 at 15:09

Michael Lynch

1,73315 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Michael Lynch Over a year ago

I guess its doing an extra query to get the user data for tweet.user. Perhaps doing if current_user.id == tweet.user_id will save that extra query.

vol7ron Over a year ago

This is what I was trying to get at, nice job Michael. It's been a while since I have even looked at Ruby :)

vol7ron · Accepted Answer · 2013-08-16 15:00:41Z

1

Not at a computer, but try: if current_user == @user

answered Aug 16, 2013 at 15:00

vol7ron

42.3k22 gold badges126 silver badges178 bronze badges

3 Comments

Michael Lynch Over a year ago

So if you're setting @user = current_user in the controller and then checking if current_user == @user wouldn't that always return true?

vol7ron Over a year ago

If you're using = instead of == then this isn't the answer (you may want to create your own answer and select that). I was curious if current_user was supposed to be compared to @user, not sure if it would work if they're both null. I think I was more questioning whether the conditional is doing what you think it is current_user.

vol7ron Over a year ago

I think this answer may help explain current_user: stackoverflow.com/questions/5575188/…

MurifoX · Accepted Answer · 2013-08-16 14:42:55Z

0

Try setting the current_user to some instance variable on your controller action:

@current = current_user

I believe you don't have access to this variable there, but you do have access to all instance variables you set up before returning the response from the controller.

answered Aug 16, 2013 at 14:42

MurifoX

15.1k3 gold badges40 silver badges60 bronze badges

Collectives™ on Stack Overflow

Rails: Issue with if statement using ajax and jquery

3 Answers 3

2 Comments

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related