Java Loop or Arrays

Question

My problem is based on the compound interest formula. A = P(1 + r)^n. I have a number of values for r and n which I must store as an array. I also must output my range of final values A as an array also. I think I have stored r and n correctly as an array. However my problem is with the final values of A and storing each value A. SO far this is what I have written.

import java.util.Scanner;
import javax.swing.*;

public class Prin {
public static void main (String [] args){

    System.out.println("Please enter the Principal you wish to invest =>");
    Scanner stdio = new Scanner (System.in);
    int principal = stdio.nextInt(); 
    stdio.nextLine();

    System.out.println("This program will now calculate the final amount A for (years) n = 1,2,3,4 and the rate r = 1%, 1.5%, 2%, 2.5%, 3%");

    int yearsarray[] = {1,2,3,4};
    double ratearray[] = {0.010, 0.015, 0.020, 0.025, 0.030};

    double amountarray[];
    amountarray = new double[19];


    for(int i=0; i<=3; i++)
    {
        for(int j=0; j<=5; j++){

            amountarray[k] = principal * Math.pow((1 + ratearray[j]), yearsarray[i]);

            System.out.println(" answer " + amountarray[k] );


    }
}

Do I need another for loop to increase the values of k in amountarray[]?

I would like to have all values of amountarray i.e amountarray[0], amountarray[1], amountarray[2], .......and so on.

Thanks in advance for any help.

k = i*5 + j .. google row major order :)

Sikorski
– Sikorski

2013-08-20 12:42:02 +00:00
Commented Aug 20, 2013 at 12:42 — Sikorski
– Sikorski, Commented Aug 20, 2013 at 12:42

SpongeBobFan · Accepted Answer · 2013-08-20 11:58:56Z

3

amountarray = new double[19];

The code above is false because you need to have 4x5 = 20 double values

This code will always work properly, You should use this and you need to learn write your codes like this:

public class Prin {
public static void main (String [] args){

    //...
    int[] yearsarray = {1,2,3,4};
    double[] ratearray = {0.010, 0.015, 0.020, 0.025, 0.030};
    double[] amountarray = new double[yearsarray.length * ratearray.length];

    int k = 0;

    for(int i=0; i<yearsarray.length; i++){
        for(int j=0; j<ratearray.length; j++){
            amountarray[k] = principal * Math.pow((1 + ratearray[j]), yearsarray[i]);
            System.out.println(" answer " + amountarray[k] );
            k++;
    }
}

edited Aug 20, 2013 at 11:58

SpongeBobFan

9545 silver badges13 bronze badges

answered Aug 20, 2013 at 11:48

user2110286

Sign up to request clarification or add additional context in comments.

2 Comments

user2110286 Over a year ago

I corrected my code. In you code, the programmer will get an ArrayIndexOutOfBoundsException. 'amountarray = new double[19];'

fvu Over a year ago

indeed, I took over that part verbatim from OP. As I felt there were several minor issues I rewrote the whole loop thing to propose improvements for all those that I spotted, have a look at the new version/

Stewart · Accepted Answer · 2013-08-20 11:44:34Z

2

"This program will now calculate the final amount A for (years) n = 1,2,3,4 and the rate r = 1%, 1.5%, 2%, 2.5%, 3%"

... this implies your answer comes in the form of a 2-dimensional matrix.

Hence your amountarray needs to be defined as:

double amountarray[][] = new double[yearsarray.length][ratearray.length];

Then you would calculate:

amountarray[i][j] = principal * Math.pow((1 + ratearray[j]), yearsarray[i]);

answered Aug 20, 2013 at 11:44

Stewart

18.9k10 gold badges60 silver badges89 bronze badges

1 Comment

user2699666 Over a year ago

That does make much more sense. The specification on my question was for 2 individual arrays. I much prefer your way.

fvu · Accepted Answer · 2013-08-20 15:40:10Z

1

No, you don't

int k=0; // initialization
for(int i=0; i<=3; i++)
{
    for(int j=0; j<=5; j++){
        // use post-increment
        amountarray[k] = principal * Math.pow((1 + ratearray[j]), yearsarray[i]);
        System.out.println(" answer " + amountarray[k] );
        // now we can increment k
        k = k+1;
}

Also this: as you seem to be using yearsarray just to get a value that's i+1, why just not do

amountarray[k] = principal * Math.pow((1 + ratearray[j]), i+1);

That way you can get rid of yearsarray, at least in this case

EDIT: a reworked version that also handles a couple of other minor issues and reduced usage of "magic numbers"

public class Prin {

    public static void main(String[] args) {

        System.out.println("Please enter the Principal you wish to invest =>");
        Scanner stdio = new Scanner(System.in);
        int principal = stdio.nextInt();
        stdio.nextLine();

        System.out.println("This program will now calculate the final amount A for (years) n = 1,2,3,4 and the rate r = 1%, 1.5%, 2%, 2.5%, 3%");

        int yearsarray[] = {1, 2, 3, 4};
        double ratearray[] = {0.010, 0.015, 0.020, 0.025, 0.030};

        double amountarray[];
        // this way the array will follow the size of yearsarray and ratearray
        amountarray = new double[yearsarray.length * ratearray.length];


        int k = 0; // initialization
        for (int i = 0; i <= yearsarray.length; i++) {
            System.out.println("years=" + yearsarray[i]);
            for (int j = 0; j < ratearray.length; j++) {
                // use post-increment
                amountarray[k] = principal * Math.pow((1 + ratearray[j]), yearsarray[i]);
                System.out.println("  " + ratearray[j] + " answer " + amountarray[k]);
                k+=1;
            }
        }
    }
}

edited Aug 20, 2013 at 15:40

answered Aug 20, 2013 at 11:42

fvu

33.1k6 gold badges64 silver badges84 bronze badges

2 Comments

Stewart Over a year ago

Variable increment k++ hidden inside the System.out.println line? Ouch.

fvu Over a year ago

@Stewart yeah I agree, blame it on a series of small edits. And that's also why I offered the postincrement-less version. But you are 100% right, and that's why I removed all references to postincrements.

Stewart · Accepted Answer · 2013-08-20 15:25:00Z

0

Try to store your data in a Map, this is an example of your loop

 for(int i=0; i<=yearsarray.length; i++) {
     for(int j=0; j<=ratearray.length; j++) {
         double answer = (yearsarray, principal * Math.pow((1 + ratearray[j]), yearsarray[i]));
         Collection<Double> aux;
         if (!answers.containsKey(yearsarray[i])){
             aux = new ArrayList<Double>();         
             aux.add(answer);
         } else {
             aux = answers.get(yearsarray[i]);
             aux.add(answer);
         }
         answers.put(yearsarray[i], aux);
         // include the answers in a Map 
    }
}

Thanks

edited Aug 20, 2013 at 15:25

Stewart

18.9k10 gold badges60 silver badges89 bronze badges

answered Aug 20, 2013 at 11:54

Felquir

4411 gold badge4 silver badges12 bronze badges

2 Comments

user2699666 Over a year ago

I am not familiar with maps but it is something I will research. Thanks.

Felquir Over a year ago

you shouldn't use arrays their solution is valid but isn't correct, stackoverflow.com/questions/1589813/…

Collectives™ on Stack Overflow

Java Loop or Arrays

4 Answers 4

2 Comments

1 Comment

2 Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

1 Comment

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related