C# SQL Columns into ComboBox

Question

My SQL query isn't dropping anything into the combobox. The connection seems to be made but the while loop doesn't seem to work. Can anybody tell me what it wrong?

string sqltable = ("dbo.SLTDS_C"+id+"_table");  

SqlConnection con = new SqlConnection("Data Source=" + server   + ";Initial Catalog=" + database + ";Integrated Security=" + security);  
con.Open();

string sqldatapull = ("select name from syscolumns where id = object_id('" + sqltable + "') order by name asc");
SqlCommand cmd = new SqlCommand(sqldatapull, con);
cmd.CommandType = CommandType.Text;
SqlDataReader dr = cmd.ExecuteReader();

while (dr.Read())  
{  
    sqldatapull = dr[0].ToString();  
    comboBox1.Items.Add(sqldatapull);  
}  

dr.Close();  
con.Close();

Correction code:
string sqldatapull = ("select name from syscolumns where id = object_id('" + sqltable + "') order by name asc");

Are you sure that you're getting results back with that query? — Paul Sasik
– Paul Sasik, Commented Dec 7, 2009 at 20:47
no i'm not string sqldatapull = ("select name from syscolumns where id = object_id('" + sqltable + "') order by name asc"); fixed it all. — user222427
– user222427, Commented Dec 7, 2009 at 21:04
is there any reason you aren't using parameters/markers instead of just string concat? just trying to avoid sql injection down the line... — John Gardner
– John Gardner, Commented Dec 7, 2009 at 21:54

cjk · Accepted Answer · 2009-12-07 21:28:13Z

2

It's because you're including dbo. as part of the table name. If you run

SELECT * FROM INFORMATION_SCHEMA.COLUMNS

You will see that the table names have no schema in the TABLE_NAME column.

answered Dec 7, 2009 at 21:28

cjk

46.6k9 gold badges83 silver badges113 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

C# SQL Columns into ComboBox

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related