C# exception. File is being used by another process

Question

I'm playing around with C# and I encountered a problem. When I try to make a new file, the program breaks and says that the file is being used by another process. It's probably something stupid that I overlooked, but I cant figure it out!

Here is my code:

using System;
using System.IO;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Windows.Forms;

namespace myNameSpace
{
    public partial class MainWindow : Form
    {
        public static string folderPath = @"fullpath";
        public MainWindow()
        {
            InitializeComponent();
            StoredTb.Text = folderPath;
            String[] files = Directory.GetFiles(folderPath);
            foreach (string file in files)
                myDropDown.Items.Add(Path.GetFileNameWithoutExtension(file));
        }

        private void myDropDown_SelectedIndexChanged(object sender, EventArgs e)
        {
            this.BeginInvoke(new MethodInvoker(myDropDown_invokedMethod));
        }

        private void myDropDown_invokedMethod()
        {
            string fullpath = MainWindow.folderPath + myDropDown.SelectedText + ".txt";
            StreamReader sr = new StreamReader(fullpath);
            NameTb.Text = myDropDown.SelectedText;
            DescriptionTb.Text = sr.ReadToEnd();
            sr.Close();
        }

        private void SaveBtn_Click(object sender, EventArgs e)
        {
            File.Create(NameTb.Text + ".txt");
            TextWriter tw = new StreamWriter(NameTb.Text + ".txt"); /* this is where the problem occurs */
            tw.WriteLine("The very first line!");
            tw.Close();
        }
    }
}

Sorry for the long code snippet, but since I'm not sure where the problem originates from I had to include pretty much everything.

Arran · Accepted Answer · 2013-09-23 10:51:11Z

13

Your problem is that File.Create will open a stream allowing you to do what you like to the file:

http://msdn.microsoft.com/en-us/library/d62kzs03.aspx

A FileStream that provides read/write access to the file specified in path.

Therefore, technically, it is in use already.

Just remove the File.Create altogether. The StreamWriter will handle creating the file if it doesn't exist.

Also, invest in using constructs to properly dispose of your file connections too. Will help avoid this in the future.

answered Sep 23, 2013 at 10:51

Arran

25.1k6 gold badges71 silver badges78 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Johan Hjalmarsson Over a year ago

Thanks! It worked. I'll accept in 6 minutes (SO wont let me accept yet)

user2704193 · Accepted Answer · 2013-09-23 10:56:45Z

2

As per MSDN the File.Create Method (String) uses a FileStream which in your case is not being closed. Use something like this:

FileStream fs = new FileStream(NameTb.Text + ".txt");
File.Create(fs);
fs.Close();

or @Muctadir Dinar

var fileStream = File.Create(NameTb.Text + ".txt");
//... do all the writing using fileStream
fileStream.Close();

answered Sep 23, 2013 at 10:56

user2704193

Comments

Hamlet Hakobyan · Accepted Answer · 2013-09-23 10:50:51Z

1

Use

myDropDown_invokedMethod();

instead of

this.BeginInvoke(new MethodInvoker(myDropDown_invokedMethod));

answered Sep 23, 2013 at 10:50

Hamlet Hakobyan

33.5k6 gold badges55 silver badges70 bronze badges

1 Comment

Johan Hjalmarsson Over a year ago

Thanks! It wasn't what caused the exception, but I'll make sure to change it.

Hossain Muctadir · Accepted Answer · 2013-09-23 10:53:45Z

1

File.Create returns a FileStream object which holds your file. You should use this object for further task.

var fileStream = File.Create(NameTb.Text + ".txt");
//... do all the writing using fileStream
fileStream.Close();

or you could do just

var fs = File.Create(NameTb.Text + ".txt");
fs.Close();
TextWriter tw = new StreamWriter(NameTb.Text + ".txt"); 
tw.WriteLine("The very first line!");
tw.Close();

answered Sep 23, 2013 at 10:53

Hossain Muctadir

3,6361 gold badge22 silver badges33 bronze badges

Comments

NeverHopeless · Accepted Answer · 2013-09-23 10:54:02Z

1

Your problem seems to be in SaveBtn_Click event, you are using your destination file twice for writing:

File.Create(NameTb.Text + ".txt");
TextWriter tw = new StreamWriter(NameTb.Text + ".txt");

Remove this line:

File.Create(NameTb.Text + ".txt");

answered Sep 23, 2013 at 10:54

NeverHopeless

11.2k4 gold badges37 silver badges56 bronze badges

Comments

Jeroen van Langen · Accepted Answer · 2013-09-23 10:51:19Z

0

Thats because the File.Create(NameTb.Text + ".txt"); keeps the file open:

try use this instead:

    private void SaveBtn_Click(object sender, EventArgs e)
    {
        using(Stream stream = File.Create(NameTb.Text + ".txt"))
        {
            TextWriter tw = new StreamWriter(stream); /* this is where the problem was */
            tw.WriteLine("The very first line!");
            tw.Close();
        }
    }

This wil force the File.Create to be Disposed when the method has exits. The dispose will close the filehandle (win32 unmanaged handle). Otherwise the file will be closed by the garbage collector, but you never know when.

answered Sep 23, 2013 at 10:51

Jeroen van Langen

22.1k3 gold badges46 silver badges63 bronze badges

Comments

kain64b · Accepted Answer · 2013-09-23 10:56:43Z

0

I see 2 ways: 1)use System.IO.File.WriteAllText http://msdn.microsoft.com/en-us/library/vstudio/8bh11f1k.aspx 2)read about disposing http://msdn.microsoft.com/en-us/library/system.idisposable.aspx

answered Sep 23, 2013 at 10:56

kain64b

2,3562 gold badges15 silver badges28 bronze badges

Collectives™ on Stack Overflow

C# exception. File is being used by another process

7 Answers 7

1 Comment

Comments

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

1 Comment

Comments

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related