loop to check string array for item

Question

I have this array

public static ArrayList<String> inventory = new ArrayList<String>();

and have the players items stored inside of it.

I want to add a feature in the shop class that will sell everything but the pickaxe, how can I create a loop to check if theres something in the array other than "pickaxe" and if there is to remove it?

To remove I have a void

public void removeAllInventory() {

    inventory.clear();

}

or

public void removeInventory(String item) {

    inventory.remove(item);

}

Could I just edit the removeAllInventory to ignore the pickaxe and make a new void called removeAllShop or something? If so what would go in that void?

This is where I need to put it in:

else if  (input.input.equalsIgnoreCase("all")) {


}

Sualeh Fatehi · Accepted Answer · 2013-09-24 21:43:01Z

2

Loop over the list, check if if each element is equal to pickaxe, and remove it if it not.

Iterator<String> i = inventory.iterator();
while (i.hasNext()) {
  if (i.next().equalsIgnoreCase("pickaxe"))
    i.remove()
}

answered Sep 24, 2013 at 21:43

Sualeh Fatehi

4,7822 gold badges26 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Sualeh Fatehi Over a year ago

Note that using a for loop without an iterator will result in a java.util.ConcurrentModificationException.

pamphlet · Accepted Answer · 2013-09-24 21:51:55Z

1

You shouldn't edit removeAllInventory() to remove everything but the pickaxe. Its name would no longer make sense, and it seems a reasonable routine to keep around.

But you could add a new method, removeAllInventoryExcept(String item), that removes everything but the given the item.

Hope this helps.

EDIT: In attempt to beef up this answer, I'd also like to suggest the "out of the box" solution of:

public void removeAllInventoryExcept(String item) {
    ArrayList<String> newInv = new ArrayList<String>();
    newInv.add(item);
    inventory = newInv;
}

This avoids the costly iteration and string comparisons.

edited Sep 24, 2013 at 21:51

answered Sep 24, 2013 at 21:40

pamphlet

2,1042 gold badges17 silver badges28 bronze badges

3 Comments

Diego C Nascimento Over a year ago

Is that really worth not being a comment? It does not solve the question.

user2366842 Over a year ago

I'd agree that keeping your code as self documenting as possible is a good way to retain your sanity. Changing the functionality of removeAllInventory starts down the path of making your code...well less than understandable by a 3rd party.

Davie Brown Over a year ago

Just as an aside, if the original inventory contained multiple "pickaxe" elements, after calling removeAllInventoryExcept("pickaxe") - there would only now be 1 pickaxe which is why the iteration and string comparison might be required.

EyeOfTheHawks · Accepted Answer · 2013-09-24 21:43:31Z

0

I'm assuming all of the items in the inventory are an ancestor of an item class, and not just a String.

You could loop through the ArrayList, getting the names of each element and comparing it with the pickaxe name.

or

You could loop through the ArrayList and checking if each item is an instanceof pickaxe, and if it is not, remove it from the ArrayList

edit* It seems you specified the ArrayList is of type String, so ignore the second option

answered Sep 24, 2013 at 21:43

EyeOfTheHawks

5761 gold badge5 silver badges16 bronze badges

Comments

ssantos · Accepted Answer · 2013-09-24 21:45:05Z

0

for (String item : inventory) {
   if (!"pixckaxe".equalsIgnoreCase(item)) {
       inventory.remove(item);
   }
}

answered Sep 24, 2013 at 21:45

ssantos

16.6k7 gold badges57 silver badges82 bronze badges

1 Comment

Sualeh Fatehi Over a year ago

This code will result in a java.util.ConcurrentModificationException. Do not use!

Collectives™ on Stack Overflow

loop to check string array for item

4 Answers 4

1 Comment

3 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

3 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related