How do I test an array of strings to find if a specific string is in the array?

Question

I have this part of my code so far. It compiles fine and runs fine. But If I choose to insert a Rank that isn't in the list it still prints the value that I input.

private String         Rank;  //string r
private static String[] Ranks = {"Assistant", "Associate", "Full"};

public professor(String n, int a, int s, String r, int nc, int pp)
{
    super(n, a, s);
    setRank(r);
    setNumCo(nc);
    setPubPaps(pp);
}
//mutator to set the Rank and check to make sure it is in the string list
public void setRank(String r)
{
    boolean check = false;

    List valid = Arrays.asList(this.Ranks);

    if(valid.contains(r)) 
        check = true;

    if(check = true)
        this.Rank = r;
    else
        this.Rank = "Associate";
}

Here's an example of what I'm talking about:

 professor p2 = new professor ("Muench", 50, 222344455, "False", 3, 45);

"False" is definitely not in the list of ranks but it will still print as follows in my print window False professor Muench....

use == instead of = where you have (check = true). You use = for assigning a value and you use == for comparisons hope that helps — Ronan
– Ronan, Commented Feb 25, 2016 at 10:48
if check is true then is should be one of the ranks from the array. If not I want it to just change the rank to Associate. But thanks Ronan that worked — Gary Hanley
– Gary Hanley, Commented Feb 25, 2016 at 10:48
Also, there is no reason for the variable check. Simply use the actual condition valid.contains(r) in the second if — Yoav Gur
– Yoav Gur, Commented Feb 25, 2016 at 10:50
Consider using an enum to represent the rank. The method collapses to a simple assignment (and maybe a null check). — Andy Turner
– Andy Turner, Commented Feb 25, 2016 at 10:51

Ronan · Accepted Answer · 2016-02-25 10:53:27Z

1

writing it like this will work and a lot more readable

List valid = Arrays.asList(this.Ranks);

if(valid.contains(r)) 
    this.Rank = r;
else
    this.Rank = "Associate";

This works because the .contains method returns a boolean value so you basically end up with if(true) or if(false) when the value is returned

edited Feb 25, 2016 at 10:53

answered Feb 25, 2016 at 10:51

Ronan

6136 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Tom Over a year ago

Still suggesting to use raw-types is always bad. Either remove that part or even better fix it for him.

Musaddique S · Accepted Answer · 2016-02-25 10:52:25Z

0

if(valid.contains(r)) 
        check = true;

    if(check == true)
        this.Rank = r;
    else
        this.Rank = "Associate";

answered Feb 25, 2016 at 10:52

Musaddique S

1,5452 gold badges17 silver badges38 bronze badges

1 Comment

trincot Over a year ago

Please add why this is the answer to the question. It might not be obvious from just seeing the code block.

MT0 · Accepted Answer · 2016-02-25 10:55:34Z

0

You can also do it using your array of strings (without converting the array to a list):

public void setRank(String r)
{
  for ( final String rank : professor.Ranks ) // Static reference to Ranks class variable.
  {
    if ( rank.equals( r ) )
    {
      this.Rank = r;
      return;
    }
  }
  this.Rank = "Associate";
}

You also have an odd naming convention:

the class professor is entirely in lower case when it is usual to capitalise (or camel-case) class names.
the attribute Rank is capitolised when the normal convention is to use lower case.

answered Feb 25, 2016 at 10:55

MT0

173k12 gold badges70 silver badges136 bronze badges

Comments

Noor Nawaz · Accepted Answer · 2016-02-25 11:10:30Z

0

Using Java 8

If case sensitive

public void setRank(String r){
       this.Rank = Stream.of(Ranks).filter(p->p.equals(r)).findAny().orElse("Associate");
}

If not case sensitive

public void setRank(String r){
       this.Rank = Stream.of(Ranks).filter(p->p.equalsIgnoreCase(r)).findAny().orElse("Associate");
}

edited Feb 25, 2016 at 11:10

answered Feb 25, 2016 at 11:02

Noor Nawaz

2,23529 silver badges36 bronze badges

Collectives™ on Stack Overflow

How do I test an array of strings to find if a specific string is in the array?

4 Answers 4

1 Comment

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related