Passing variables to ajax with onclick

Question

I have a problem with the variables, that I want to pass through ajax to php.

In an php file, I generate some divs with id and name attributes.

livesrc.php

echo "<div class=\"search-results\" id=\"" . $softwareArray['Sw_idn'] . "\" 
name=\"" . $softwareArray['SoftwareName'] . "\" 
onclick=\"addBasket(this.id, this.name)\" >
" . utf8_encode($softwareArray['SoftwareName']) . "</div>";

The relevent part is this:

onclick="addBasket(this.id, this.name)

Sorry for the escapes, in html the div looks like:

<div class="search-results" id="235" 
name="Adobe Acrobat Writer 9.0 Professional"
onclick="addBasket(this.id, this.name)">...</div>

This looks okay, but in the js "addBasket", the variable sw_name is not set. (undefinded)

The JS in the head section:

<script type="text/javascript">
  function addBasket(sw_id, sw_name) 
  {
    alert(sw_name);
    $.post("assets/basket.php",{sw_id: sw_id, sw_name: sw_name}, function(data) 
  { 
      $("#basket").html(data);
    });
  }
</script>

The sw_id is set, but the sw_name is not working. Is the call in html with "this.name" correct?

Could you try $(this).attr('name') ? (if you're using jQuery? — Darren
– Darren, Commented Oct 14, 2013 at 15:50

peernohell · Accepted Answer · 2013-10-14 15:49:27Z

5

it's because this.name did not exists if you want to access the attribute you have to call this.getAttribute('name') id are particular and can be access directly.

Personally I will give juste this to the function and extract id and name in the function

 onclick="addBasket(this)";




<script type="text/javascript">
  function addBasket(el) 
  {
    var 
    sw_id = el.id,
    sw_name = $(el).attr('name');

    alert(sw_name);
    $.post("assets/basket.php",{sw_id: sw_id, sw_name: sw_name}, function(data) 
  { 
      $("#basket").html(data);
    });
  }
</script>

answered Oct 14, 2013 at 15:49

peernohell

8175 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Md Amranur Rahman Over a year ago

what does it mean that "el" in this term sw_id = el.id, sw_name = $(el).attr('name');

Speedy · Accepted Answer · 2013-10-14 15:53:15Z

0

You could pass the whole element into your js:

<div class="search-results" id="235" 
name="Adobe Acrobat Writer 9.0 Professional"
onclick="addBasket(this)">...</div>

Then grab what you want in your function

function addBasket(sw) {
    alert( sw.id + ' ' + sw.getAttribute( 'name' ) );
}

answered Oct 14, 2013 at 15:53

Speedy

1981 silver badge9 bronze badges

Collectives™ on Stack Overflow

Passing variables to ajax with onclick

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related