Null Pointer Exception?

Question

Why am I getting a NullPointerException with this code?

public static void main(String args[]) throws FileNotFoundException {

    int i = 0;
    Job[] job = new Job[100];
    File f = new File("Jobs.txt");
    Scanner input = new Scanner(f);

    while (input.hasNextInt()) {
        job[i].start = input.nextInt();
        job[i].end = input.nextInt();
        job[i].weight = input.nextInt();
        i++;
    }
}

I get the error at the very first line of the while loop on its very first run-through. I also have a separate class:

public class Job {
    public int start, end, weight;
}

and the text file:

Thank you.

Thanks all! Simple mistake, simple answer.

user2297639
– user2297639

2013-10-29 14:18:26 +00:00
Commented Oct 29, 2013 at 14:18 — user2297639
– user2297639, Commented Oct 29, 2013 at 14:18
Happens to every programmer, Someday :)

Suresh Atta
– Suresh Atta

2013-10-29 14:27:14 +00:00
Commented Oct 29, 2013 at 14:27 — Suresh Atta
– Suresh Atta, Commented Oct 29, 2013 at 14:27
NPE problem without a stacktrace.

Raedwald
– Raedwald

2013-11-04 08:14:27 +00:00
Commented Nov 4, 2013 at 8:14 — Raedwald
– Raedwald, Commented Nov 4, 2013 at 8:14

Suresh Atta · Accepted Answer · 2013-10-30 04:27:56Z

8

NullPointerException

Thrown when an application attempts to use null in a case where an object is required. These include:

Calling the instance method of a null object.
Accessing or modifying the field of a null object.
Taking the length of null as if it were an array.
Accessing or modifying the slots of null as if it were an array.
Throwing null as if it were a Throwable value.

Job[] job = new Job[100];

As of now all values in array are null. Because you not inserted any Job objects inside.

  job[i].start = input.nextInt(); // job[i]  is null.

What you have to do is just initialize a new Job object and assign to the current index.

Becomes,

while (input.hasNextInt()) {
        Job job = new Job(); 
        job.start = input.nextInt();
        job.end = input.nextInt();
        job.weight = input.nextInt();
        job[i] =job;
        i++;
    }

edited Oct 30, 2013 at 4:27

answered Oct 29, 2013 at 14:09

Suresh Atta

122k38 gold badges206 silver badges315 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Maroun · Accepted Answer · 2013-10-29 14:11:59Z

5

See 4.12.5. Initial Values of Variables:

For all reference types (§4.3), the default value is null.

You need to initialize job array before trying to access it, now it's like writing null.start, which of course causes NullPointerException.

answered Oct 29, 2013 at 14:11

Maroun

96.3k30 gold badges195 silver badges249 bronze badges

1 Comment

Maroun Over a year ago

@sᴜʀᴇsʜᴀᴛᴛᴀ Was looking for that for about 3 mins :D

Habib · Accepted Answer · 2013-10-29 14:09:23Z

4

You just initialized an array of Job type, you haven't initialized each element in the array, hence the exception.

 while (input.hasNextInt()) {
        job[i] = new Job(); // initialize here
        job[i].start = input.nextInt();
        job[i].end = input.nextInt();
        job[i].weight = input.nextInt();
        i++;
    }

answered Oct 29, 2013 at 14:09

Habib

224k30 gold badges420 silver badges446 bronze badges

Collectives™ on Stack Overflow

Null Pointer Exception?

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related