C++ constructor for inheritance

Question

I just want to check in order to inherit a constructor from the parent class is this the correct way to do it by using object composition?

and I'm getting this errors and they are all referring to my constructors.

    C:\Users\user\AppData\Local\Temp\cc0CYtVR.o:SquareImp.cpp:(.text+0x16): undefine
d reference to `vtable for Square'
C:\Users\user\AppData\Local\Temp\cc0CYtVR.o:SquareImp.cpp:(.text+0x79): undefine
d reference to `vtable for Square'
C:\Users\user\AppData\Local\Temp\cc0CYtVR.o:SquareImp.cpp:(.text$_ZN6SquareD1Ev[
Square::~Square()]+0xb): undefined reference to `vtable for Square'
collect2: ld returned 1 exit status

Sorry this is my new script as I've made try rewriting them

ShapeTwoD.h

class ShapeTwoD
{
    protected:
        string name, warpSpace;
        bool containsWarpSpace;
        int xCord, yCord, length, breath;
    public:
        //constructor
        ShapeTwoD();
        ShapeTwoD(string, bool);
};

ShapeTwoD.cpp

ShapeTwoD::ShapeTwoD()
{
    string name = "";
    bool containsWarpSpace = true;
}

ShapeTwoD::ShapeTwoD(string ShapeName, bool warpspace)
{
    name = ShapeName;
    containsWarpSpace = true;
}

square.h

class Square:public ShapeTwoD
{
    private:
        int xVal,yVal;
        int newlength, newbreath;
        double area;

    public:
        Square();
        Square(string, bool, int, int);
};

square.cpp

Square::Square()
{
    xVal = 0;
    yVal = 0;
}

  Square::Square(string ShapeName, bool warpspace, int xval, int yval):ShapeTwoD(ShapeName, warpspace), xVal(xval), yVal(yval)
    {
    xVal = xval;
    YVal = yval;
    cout << "test test" << endl;
}

int main()
{
    Square square;
    cout << "hello world" << endl;
}

What have you tried? For example, you can print statements in the constructor and determine in what order they're built. — carlosdc
– carlosdc, Commented Nov 2, 2013 at 6:04
Looks good. There is a site in the StackExchange network for code review, it may be better suited there. — nvoigt
– nvoigt, Commented Nov 2, 2013 at 6:05
OK, it seems you've edited your question. How do you declared those classes? — masoud
– masoud, Commented Nov 2, 2013 at 6:10
Ahh, but it then isn't a question about specifics of construction order. It is a question of my code won't compile. — carlosdc
– carlosdc, Commented Nov 2, 2013 at 6:12
@MM I've already updated the question but I'm still getting the same compilation error.. why is this so? — koi_s3ng
– koi_s3ng, Commented Nov 2, 2013 at 6:25

masoud · Accepted Answer · 2013-11-02 07:04:32Z

2

Yes, and also put xVal and yVal in the initializer list too:

Square::Square(string ShapeName, bool square, int xval, int yval):
      ShapeTwoD(ShapeName, square), xVal(xval), yVal(yval)
{
}

And construct base class for Square() too:

Square::Square() : ShapeTwoD(..., ...)
{
}

edited Nov 2, 2013 at 7:04

answered Nov 2, 2013 at 6:06

masoud

56.8k18 gold badges152 silver badges214 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

koi_s3ng Over a year ago

sorry why do I have to include "xVal(xval), yVal(yval)"?

masoud Over a year ago

You don't have to, your way works, but this way is standard and has good advantages specially for initializing objects.

Collectives™ on Stack Overflow

C++ constructor for inheritance

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related