error in insert statment in jdbc

Question

I'm trying to insert in dabase with following code

try{
String driver = "sun.jdbc.odbc.JdbcOdbcDriver";
String url = "jdbc:odbc:ProductDSN";
Class.forName(driver);
Connection con = DriverManager.getConnection(url);
System.out.println("Connection established");
System.out.println("clear point 1");
String sql  = "INSERT INTO product
(id,productName,category,price,availability,quantity,description)
VALUES('ID','name','catag','price','avail','quantity','discript')";
System.out.println("clear point 2");
PreparedStatement stmt = con.prepareStatement(sql);
System.out.println("clear point 3");
stmt.executeUpdate();
System.out.println("clear point 4");

JOptionPane.showMessageDialog(null, "Record Save Successfully");

if (con != null)
  stmt.close();
con.close();
System.out.println("Connection Closed");
}
catch(SQLException sqle)
{
  System.err.println("Error is in save method");
  System.err.println(sqle);
}

and following are errors in compiling..

Connection established
clear poitn 1
clear point 2
clear point 3
Error is in save method
java.sql.SQLException: General error

Please check the datatype of id,price and quantity whether they are integer or varchar — rachana
– rachana, Commented Dec 9, 2013 at 6:11

Linga · Accepted Answer · 2013-12-09 06:23:49Z

2

You are confused with the Prepared statement.

The setter methods (setShort, setString, and so on) for setting IN parameter values must specify types that are compatible with the defined SQL type of the input parameter. For instance, if the IN parameter has SQL type INTEGER, then the method setInt should be used.

So please try

String sql  = "INSERT INTO product
(id,productName,category,price,availability,quantity,description)
VALUES(?,?,?,?,?,?,?)";

and

stmt.setInt(1, value)// for Integer where 1 is the index
stmt.setString(2, value)// for string where 2 is the index
.....

and finally,

stmt.executeUpdate();

answered Dec 9, 2013 at 6:23

Linga

10.6k10 gold badges57 silver badges109 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Lijo · Accepted Answer · 2013-12-09 06:14:57Z

0

sql exception means error is int SQL query. Check your sql query separately on the query browser. Check whether you have given all attributes datatype as String.. you have given the values to insert as Strings..price,id etc..

check if it is in the same string format in the db also.. plz provide the error display so i can help you more..

answered Dec 9, 2013 at 6:14

Lijo

6,7935 gold badges51 silver badges61 bronze badges

Comments

Aditya · Accepted Answer · 2013-12-09 06:37:16Z

0

Check out for Prepared Statement format & how to use it.

answered Dec 9, 2013 at 6:37

Aditya

2,3198 gold badges40 silver badges58 bronze badges

Collectives™ on Stack Overflow

error in insert statment in jdbc

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related