How to create a CString from an array of chars?

Question

Need to log the content of buf using the LogMethod() below the problem is that LogMethos only accepts a "Const CString&"

char buf[1024];
strcpy(buf, cErrorMsg);

// need to pass to LogMethod "buf" how do i do that?
log.LogMethod(const CString &);

Thans Rev

Reversed

what is CString? do you refer to ATL/MFC? In C++, the standard string is std::string. CString can be anything, for instance a class coded by a coworker in your code base. — Gregory Pakosz
– Gregory Pakosz, Commented Jan 14, 2010 at 15:46
//log.LogDebug(CString(buf)); //log.LogDebug(buf); //str = buf; //log.LogDebug(str); Neither of the code above worked... — Reversed
– Reversed, Commented Jan 14, 2010 at 18:27
Then the problem is somewhere else. Show us the code for LogMethod. — avakar
– avakar, Commented Jan 14, 2010 at 21:47
You were right! the problem was in my LogMethod class Thanks all for your help — Reversed
– Reversed, Commented Jan 15, 2010 at 12:46

avakar · Accepted Answer · 2010-01-14 15:52:39Z

1

If you're talking about MFC CString, as far as I can tell, it should have a non-explicit constructor taking TCHAR const *. In other words, the following should work.

log.LogMethod(buf);

If it doesn't, please post the error message.

answered Jan 14, 2010 at 15:52

avakar

32.8k10 gold badges73 silver badges105 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ruddy · Accepted Answer · 2010-01-14 16:15:02Z

1

log.LogMethod(CString(buf));

This will avoid the problem where the compiler won't automatically create the CString object using the appropriate constructor since the argument is a reference (It would have if the argument was a "plain" CString).

answered Jan 14, 2010 at 16:15

Ruddy

1,75410 silver badges11 bronze badges

4 Comments

avakar Over a year ago

It makes no difference whether the parameter is CString or CString const &, in both cases the conversion will be performed. In the latter case, a temporary will be created and bound to the reference.

Ruddy Over a year ago

That is true in the general conversion case, however for CString this isn't true because the constructor (that accepts a char*) has been declared explicit which, unless i'm mistaken, keeps the compiler from being able to automatically chose it for such conversions. That said it does work in VS6 (where it is not marked explicit) when the CString& is const, but it does not work in VS2005 Reason: cannot convert from 'const char [5]' to 'const CString' Constructor for class 'ATL::CStringT<BaseType,StringTraits>' is declared 'explicit'

avakar Over a year ago

I very much doubt that Microsoft would change the explicitness between versions, as it would break a lot of existing code. Besides, documentation (msdn.microsoft.com/en-us/library/cws1zdt8%28VS.80%29.aspx) clearly shows the constructor is not explicit. Are you sure you didn't try compiling as Unicode while still passing char const * as a parameter (which indeed would trigger the explicit non-TCHAR constructor)?

Ruddy Over a year ago

@avakar - I stand corrected. I had accepted the defaults for the project, it was making "const char*" unicode, and when changed to non-unicode it worked as you describe (compiling without error).

sdornan · Accepted Answer · 2010-01-14 15:46:56Z

0

CString cs;
cs = buf;

log.LogMethod(cs)

answered Jan 14, 2010 at 15:46

sdornan

2,8452 gold badges16 silver badges7 bronze badges

Collectives™ on Stack Overflow

How to create a CString from an array of chars?

3 Answers 3

Comments

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related