CString constructor from char[]

Question

Is it good to construct CString from char[] ?

char R[5000];
CString s = R;

In these lines sometimes I have exception:

Windows has triggered a breakpoint in tst.exe.

This may be due to a corruption of the heap, which indicates a bug in tst.exe or any of the DLLs it has loaded.

This may also be due to the user pressing F12 while tst.exe has focus.

The output window may have more diagnostic information

What is the point of this code? Why would you initialize a CString object with junk data? — Cody Gray
– Cody Gray ♦, Commented May 6, 2014 at 8:54
Yes, it is good. When the char[] holds a zero-terminated string. — harper
– harper, Commented May 6, 2014 at 9:00

barak manos · Accepted Answer · 2014-05-06 08:56:28Z

2

The CString constructor attempts to copy a null-terminated string from the input argument (more precisely, from the memory address pointed by the input argument).

So it copies characters until reaching a 0 (null) character, and since the contents of R[5000] are not initialized, there's a good chance that none of the characters in it is equal to 0.

If there is no such character within the legal memory region pointed by the input argument, then the CString constructor exceeds that memory region, and most likely causes an illegal memory access.

edited May 6, 2014 at 8:56

answered May 6, 2014 at 8:45

barak manos

30.3k10 gold badges67 silver badges117 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

CString constructor from char[]

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related