Rails ActiveRecord Won't Save Associations On Create But Will On Update

Question

I have the following methods for Create and Update in my Controller:

  def new
    if request.post?
      @article = Article.new(article_params)
      @article.user = @user
      if @article.save
        redirect_to :admin_articles, :flash => { success: t(:article_created) }
      end
    else
      @article = Article.new
    end
  end

  def edit
    if request.patch?
      if @article.update(article_params)
        redirect_to :admin_articles, :flash => { success: t(:article_updated) }
      end
    end
  end

And I have the following for the article_params:

    def article_params
        article_params = params[:article].permit(:category_id, :title, :slug, :article_type, :content, :link, :summary)
        if params[:tags].present?
          tags = params[:tags].split ','
          tags_array = Array.new
          tags.each do |t|
            tags_array.append Tag.find_or_create_by slug: t
          end

          article_params[:tags] = tags_array
        end

    article_params
  end

When I do the Update it saves properly, but when I try to do the Create it says Article Tags is invalid. Does anyone know what I am doing wrong?

Hi, is it possible to determine if a record was successfully created using the create method? — Darren
– Darren, Commented Jan 1, 2014 at 1:40
Nevermind, saw it was. I did not realize this was improper convention, thanks. — Darren
– Darren, Commented Jan 1, 2014 at 1:51

Peter Alfvin · Accepted Answer · 2013-12-31 21:18:59Z

1

You don't have (or at least haven't shown) a create method in your controller, so you're just getting ActiveModel's default implementation which isn't going to pick up any of the params. If you're doing something non-standard with your routes, such that POST is getting mapped to new, please share that.

answered Dec 31, 2013 at 21:18

Peter Alfvin

29.6k9 gold badges72 silver badges114 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

Darren Over a year ago

I map it like: match 'articles/new', to: 'articles#new', via: [:get, :post], as: :article_new

Peter Alfvin Over a year ago

Can I ask how it is that you're causing the POST to go to articles/new on submission (i.e. from your view)?

Darren Over a year ago

<%= form_for @article, { :url => :admin_article_new } do |f| %>

Alex Lynham Over a year ago

Can I ask why you're not following the Rails defaults?

Peter Alfvin Over a year ago

Have you confirmed your :url parameter is working (i.e. that you're taking the request.post? branch of your if/else)?

|

Darren · Accepted Answer · 2014-01-01 18:51:47Z

0

the issue was me not understanding convention. My object had not been created therefore it did not have a tags property yet. I have changed my methods to the following:

    def article_params
        params[:article].permit(:category_id, :title, :slug, :article_type, :content, :link, :summary)
      end

      def tags
        tags = Array.new

        if params[:tags].present?
          tag_param_array = params[:tags].split ','
          tag_param_array.each do |t|
            tags.append Tag.find_or_create_by slug: t
          end
        end

        tags
      end

      def new
    @article = Article.new
  end

  def create
    @article = Article.create article_params
    if @article.valid?
      @article.tags = tags

      redirect_to :admin_articles, :flash => { :success => t(:article_created) } if @article.save
    else
      render 'new'
    end
  end

  def edit
  end

  def patch
    @article.update_attributes article_params
    if @article.valid?
      @article.tags = tags

      redirect_to :admin_articles, :flash => { :success => t(:article_updated) } if @article.save
    end
  end

edited Jan 1, 2014 at 18:51

answered Jan 1, 2014 at 2:55

Darren

11k8 gold badges46 silver badges66 bronze badges

3 Comments

tommyd456 Over a year ago

But you're still going against convention! You should really have a New and Create action to make life easier for yourself. See the intro to Rails for further info.

Darren Over a year ago

@tommyd456 I am confused. The Getting Started with Rails guide is showing to use the method before which you said was improper convention (.save). Can you explicitly link me a link to proper convention?

Darren Over a year ago

@tommyd456 I believe I understand what you meant. I have moved my create and patch logic into separate controller actions and routed them accordingly.

Collectives™ on Stack Overflow

Rails ActiveRecord Won't Save Associations On Create But Will On Update

2 Answers 2

10 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

10 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related