Call variables in string.xml [duplicate]

Question

Please see my previous question here for the full code.

In case I want to internationalize my app, I need to create string objects for some statements in my project. The one bothering me most is this code block.

    ...
    else
        Toast.makeText(MainActivity.this, 
            "Good job! The answer was " + comp + ".\n" +
            "You made " + guesses + " guesses.\n" +
            "Restart the app to try again.", 
            Toast.LENGTH_LONG).show();
    }
};

The relative part to this in the strings.xml looks like:

<string name="correct">Good job! The answer was + comp\n
               You made + guesses + guesses.\n
               Restart the app to try again.</string>

I want the comp and guesses variables to show their respective values, but I don't know how.

I plan to do this to the code block

    ...
    else
        Toast.makeText(MainActivity.this, 
            R.string.correct, 
            Toast.LENGTH_LONG).show();
    }
};

Thank you.

This has been answered elsewhere. For e.g. see this: stackoverflow.com/a/3656409/415412 — Suchintya
– Suchintya, Commented Jan 9, 2014 at 17:54
Thanks Suchintya. Didn't realize that, but it's an awesome resource. — jjkim
– jjkim, Commented Jan 9, 2014 at 17:57

Andros · Accepted Answer · 2014-01-10 08:15:29Z

14

In your xml file string.xml :

<?xml version="1.0" encoding="utf-8"?>
<resources>
     <string name="correct">Good job! The answer was %1$s\n
               You made %2$s guesses.\n
               Restart the app to try again.</string>
</resources>

If you want to put an other value in the text, you increment %2$s -> %3$s , etc ...

Then you can use it like in java like that :

Toast.makeText(MainActivity.this, getString(R.string.correct, comp, guesses), 
            Toast.LENGTH_LONG).show();

edited Jan 10, 2014 at 8:15

answered Jan 9, 2014 at 17:49

Andros

4,0691 gold badge25 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Phil Over a year ago

This is definitely the best way to handle this, and I did not know about that getString method - I've been using String.format(Locale, String, Object...). Nice!

brader24 · Accepted Answer · 2014-01-09 18:00:24Z

1

Store a format string in the resource and use String.format to replace the comp and guesses placeholders. Use the appropriate places holders for each and include the variables as arguments to format(). You can find details of what placeholders to use under the Formatter class.

The resource would then be something like:

<string name="correct">Good job! The answer was %s \n
           You made %d guesses.\n
           Restart the app to try again.</string>

And the code would be:

...
else
    String correctFormat = getString(R.string.correct);
    Toast.makeText(MainActivity.this, 
        String.format(correctFormat, comp, guesses),
        Toast.LENGTH_LONG).show();
}

};

answered Jan 9, 2014 at 18:00

brader24

4852 silver badges10 bronze badges

Comments

tyczj · Accepted Answer · 2014-01-09 17:50:03Z

0

you would use

context.getResources().getString(r.id.correct);

then create a values folder for each language you want

answered Jan 9, 2014 at 17:50

tyczj

74.8k57 gold badges209 silver badges314 bronze badges

Comments

Srikanth R · Accepted Answer · 2014-01-09 17:53:05Z

0

As @Andros said,

In your string.xml

<string name="correct">Good job! The answer was %1$s\n
           You made %2$s guesses.\n
           Restart the app to try again.</string>

In your code,

Resources res = getResources();
Toast.makeText(MainActivity.this, String.format(res.getString(R.string.correct),comp, guesses),Toast.LENGTH_LONG).show();

answered Jan 9, 2014 at 17:53

Srikanth R

4185 silver badges18 bronze badges

2 Comments

pdegand59 Over a year ago

You don't need to get the Resource because getString() is directly available from a context. And you dont have to use String.format() because with getString(int, Object ...), you can do it directly.

Srikanth R Over a year ago

Yeah, you are right. It's just a generalized answer. It works even for, say nested classes too.

AndRSoid · Accepted Answer · 2014-01-09 17:54:55Z

0

In string.xml

<string name="correct" formatted="false">Good job! The answer was %s\n
               You made %s guesses.\n
               Restart the app to try again.</string>

In java :

Toast.makeText(MainActivity.this,String.format(context.getString(R.string.correct),comp,guesses), Toast.LENGTH_LONG).show();

answered Jan 9, 2014 at 17:54

AndRSoid

1,8352 gold badges15 silver badges25 bronze badges

Collectives™ on Stack Overflow

Call variables in string.xml [duplicate]

5 Answers 5

1 Comment

Comments

Comments

2 Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

Comments

2 Comments

Comments

Linked

Related